From: Dave Gordon Subject: [PATCH 3/3] drm/i915/guc: local optimisations and updating comments Date: Tue, 19 Apr 2016 16:08:36 +0100 Message-ID: <1461078516-28678-3-git-send-email-david.s.gordon@intel.com> References: <1461078516-28678-1-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F5DF6E1EA for ; Tue, 19 Apr 2016 15:08:53 +0000 (UTC) In-Reply-To: <1461078516-28678-1-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org VGlkeWluZyB1cCBndWNfaW5pdF9wcm9jX2Rlc2MoKSBhbmQgYWRkaW5nIGNvbW1lbnRhcnkgdG8g dGhlIGNsaWVudApzdHJ1Y3R1cmUgYWZ0ZXIgdGhlIHJlY2VudCBjaGFuZ2UgaW4gR3VDIHBhZ2Ug bWFwcGluZyBzdHJhdGVneS4KClNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdv cmRvbkBpbnRlbC5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlz c2lvbi5jIHwgMzggKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCiBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9ndWMuaCAgICAgICAgICAgfCAyMyArKysrKysrKysrKysrKysrKysKIDIg ZmlsZXMgY2hhbmdlZCwgNDEgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCmluZGV4IDQ3MThiN2EuLmQ0MGMx M2YgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24u YworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKQEAgLTM1 OCwxMiArMzU4LDE0IEBAIHN0YXRpYyB2b2lkIGd1Y19pbml0X3Byb2NfZGVzYyhzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMsCiBzdGF0aWMgdm9pZCBndWNfaW5pdF9jdHhfZGVzYyhzdHJ1Y3QgaW50ZWxf Z3VjICpndWMsCiAJCQkgICAgICBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQpCiB7CisJ c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKmNsaWVudF9vYmogPSBjbGllbnQtPmNsaWVudF9v Ymo7CiAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUoZ3Vj KTsKIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7CiAJc3RydWN0IGludGVsX2NvbnRl eHQgKmN0eCA9IGNsaWVudC0+b3duZXI7CiAJc3RydWN0IGd1Y19jb250ZXh0X2Rlc2MgZGVzYzsK IAlzdHJ1Y3Qgc2dfdGFibGUgKnNnOwogCWVudW0gaW50ZWxfZW5naW5lX2lkIGlkOworCXUzMiBn ZnhfYWRkcjsKIAogCW1lbXNldCgmZGVzYywgMCwgc2l6ZW9mKGRlc2MpKTsKIApAQCAtMzkyLDE2 ICszOTQsMTcgQEAgc3RhdGljIHZvaWQgZ3VjX2luaXRfY3R4X2Rlc2Moc3RydWN0IGludGVsX2d1 YyAqZ3VjLAogCQlscmMtPmNvbnRleHRfZGVzYyA9ICh1MzIpY3R4X2Rlc2M7CiAKIAkJLyogVGhl IHN0YXRlIHBhZ2UgaXMgYWZ0ZXIgUFBIV1NQICovCi0JCWxyYy0+cmluZ19sY3JhID0gaTkxNV9n ZW1fb2JqX2dndHRfb2Zmc2V0KG9iaikgKwotCQkJCUxSQ19TVEFURV9QTiAqIFBBR0VfU0laRTsK KwkJZ2Z4X2FkZHIgPSBpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQob2JqKTsKKwkJbHJjLT5yaW5n X2xjcmEgPSBnZnhfYWRkciArIExSQ19TVEFURV9QTiAqIFBBR0VfU0laRTsKIAkJbHJjLT5jb250 ZXh0X2lkID0gKGNsaWVudC0+Y3R4X2luZGV4IDw8IEdVQ19FTENfQ1RYSURfT0ZGU0VUKSB8CiAJ CQkJKGVuZ2luZS0+Z3VjX2lkIDw8IEdVQ19FTENfRU5HSU5FX09GRlNFVCk7CiAKIAkJb2JqID0g Y3R4LT5lbmdpbmVbaWRdLnJpbmdidWYtPm9iajsKKwkJZ2Z4X2FkZHIgPSBpOTE1X2dlbV9vYmpf Z2d0dF9vZmZzZXQob2JqKTsKIAotCQlscmMtPnJpbmdfYmVnaW4gPSBpOTE1X2dlbV9vYmpfZ2d0 dF9vZmZzZXQob2JqKTsKLQkJbHJjLT5yaW5nX2VuZCA9IGxyYy0+cmluZ19iZWdpbiArIG9iai0+ YmFzZS5zaXplIC0gMTsKLQkJbHJjLT5yaW5nX25leHRfZnJlZV9sb2NhdGlvbiA9IGxyYy0+cmlu Z19iZWdpbjsKKwkJbHJjLT5yaW5nX2JlZ2luID0gZ2Z4X2FkZHI7CisJCWxyYy0+cmluZ19lbmQg PSBnZnhfYWRkciArIG9iai0+YmFzZS5zaXplIC0gMTsKKwkJbHJjLT5yaW5nX25leHRfZnJlZV9s b2NhdGlvbiA9IGdmeF9hZGRyOwogCQlscmMtPnJpbmdfY3VycmVudF90YWlsX3BvaW50ZXJfdmFs dWUgPSAwOwogCiAJCWRlc2MuZW5naW5lc191c2VkIHw9ICgxIDw8IGVuZ2luZS0+Z3VjX2lkKTsK QEAgLTQxMCwyMiArNDEzLDE3IEBAIHN0YXRpYyB2b2lkIGd1Y19pbml0X2N0eF9kZXNjKHN0cnVj dCBpbnRlbF9ndWMgKmd1YywKIAlXQVJOX09OKGRlc2MuZW5naW5lc191c2VkID09IDApOwogCiAJ LyoKLQkgKiBUaGUgQ1BVIGFkZHJlc3MgaXMgb25seSBuZWVkZWQgYXQgY2VydGFpbiBwb2ludHMs IHNvIGttYXBfYXRvbWljIG9uCi0JICogZGVtYW5kIGluc3RlYWQgb2Ygc3RvcmluZyBpdCBpbiB0 aGUgY3R4IGRlc2NyaXB0b3IuCi0JICogWFhYOiBNYXkgbWFrZSBkZWJ1ZyBlYXNpZXIgdG8gaGF2 ZSBpdCBtYXBwZWQKKwkgKiBUaGUgZG9vcmJlbGwsIHByb2Nlc3MgZGVzY3JpcHRvciwgYW5kIHdv cmtxdWV1ZSBhcmUgYWxsIHBhcnRzCisJICogb2YgdGhlIGNsaWVudCBvYmplY3QsIHdoaWNoIHRo ZSBHdUMgd2lsbCByZWZlcmVuY2UgdmlhIHRoZSBHR1RUCiAJICovCi0JZGVzYy5kYl90cmlnZ2Vy X2NwdSA9IDA7Ci0JZGVzYy5kYl90cmlnZ2VyX3VrID0gY2xpZW50LT5kb29yYmVsbF9vZmZzZXQg KwotCQlpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQoY2xpZW50LT5jbGllbnRfb2JqKTsKLQlkZXNj LmRiX3RyaWdnZXJfcGh5ID0gY2xpZW50LT5kb29yYmVsbF9vZmZzZXQgKwotCQlzZ19kbWFfYWRk cmVzcyhjbGllbnQtPmNsaWVudF9vYmotPnBhZ2VzLT5zZ2wpOwotCi0JZGVzYy5wcm9jZXNzX2Rl c2MgPSBjbGllbnQtPnByb2NfZGVzY19vZmZzZXQgKwotCQlpOTE1X2dlbV9vYmpfZ2d0dF9vZmZz ZXQoY2xpZW50LT5jbGllbnRfb2JqKTsKLQotCWRlc2Mud3FfYWRkciA9IGNsaWVudC0+d3Ffb2Zm c2V0ICsKLQkJaTkxNV9nZW1fb2JqX2dndHRfb2Zmc2V0KGNsaWVudC0+Y2xpZW50X29iaik7Ci0K KwlnZnhfYWRkciA9IGk5MTVfZ2VtX29ial9nZ3R0X29mZnNldChjbGllbnRfb2JqKTsKKwlkZXNj LmRiX3RyaWdnZXJfcGh5ID0gc2dfZG1hX2FkZHJlc3MoY2xpZW50X29iai0+cGFnZXMtPnNnbCkg KworCQkJCWNsaWVudC0+ZG9vcmJlbGxfb2Zmc2V0OworCWRlc2MuZGJfdHJpZ2dlcl9jcHUgPSAo dWludHB0cl90KWNsaWVudC0+Y2xpZW50X2Jhc2UgKworCQkJCWNsaWVudC0+ZG9vcmJlbGxfb2Zm c2V0OworCWRlc2MuZGJfdHJpZ2dlcl91ayA9IGdmeF9hZGRyICsgY2xpZW50LT5kb29yYmVsbF9v ZmZzZXQ7CisJZGVzYy5wcm9jZXNzX2Rlc2MgPSBnZnhfYWRkciArIGNsaWVudC0+cHJvY19kZXNj X29mZnNldDsKKwlkZXNjLndxX2FkZHIgPSBnZnhfYWRkciArIGNsaWVudC0+d3Ffb2Zmc2V0Owog CWRlc2Mud3Ffc2l6ZSA9IGNsaWVudC0+d3Ffc2l6ZTsKIAogCS8qCmRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2d1Yy5oCmluZGV4IDE5Y2E1OTMuLjlkNzljNGMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2d1Yy5oCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5o CkBAIC0yOSw2ICsyOSwyOSBAQAogCiBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3Q7CiAKKy8q CisgKiBUaGlzIHN0cnVjdHVyZSBwcmltYXJpbHkgZGVzY3JpYmVzIHRoZSBHRU0gb2JqZWN0IHNo YXJlZCB3aXRoIHRoZSBHdUMuCisgKiBUaGUgR0VNIG9iamVjdCBpcyBoZWxkIGZvciB0aGUgZW50 aXJlIGxpZmV0aW1lIG9mIG91ciBpbnRlcmFjdGlvbiB3aXRoCisgKiB0aGUgR3VDLCBiZWluZyBh bGxvY2F0ZWQgYmVmb3JlIHRoZSBHdUMgaXMgbG9hZGVkIHdpdGggaXRzIGZpcm13YXJlLgorICog QmVjYXVzZSB0aGVyZSdzIG5vIHdheSB0byB1cGRhdGUgdGhlIGFkZHJlc3MgdXNlZCBieSB0aGUg R3VDIGFmdGVyCisgKiBpbml0aWFsaXNhdGlvbiwgdGhlIHNoYXJlZCBvYmplY3QgbXVzdCBzdGF5 IHBpbm5lZCBpbnRvIHRoZSBHR1RUIGFzCisgKiBsb25nIGFzIHRoZSBHdUMgaXMgaW4gdXNlLiBX ZSBhbHNvIGtlZXAgdGhlIGZpcnN0IHBhZ2UgKG9ubHkpIG1hcHBlZAorICogaW50byBrZXJuZWwg YWRkcmVzcyBzcGFjZSwgYXMgaXQgaW5jbHVkZXMgc2hhcmVkIGRhdGEgdGhhdCBtdXN0IGJlCisg KiB1cGRhdGVkIG9uIGV2ZXJ5IHJlcXVlc3Qgc3VibWlzc2lvbi4KKyAqCisgKiBUaGUgc2luZ2xl IEdFTSBvYmplY3QgZGVzY3JpYmVkIGhlcmUgaXMgYWN0dWFsbHkgbWFkZSB1cCBvZiBzZXZlcmFs CisgKiBzZXBhcmF0ZSBhcmVhcywgYXMgZmFyIGFzIHRoZSBHdUMgaXMgY29uY2VybmVkLiBUaGUg Zmlyc3QgcGFnZSAoa2VwdAorICoga21hcCdkKSBpbmNsdWRlcyB0aGUgInByb2Nlc3MgZGVjcmlw dG9yIiB3aGljaCBob2xkcyBzZXF1ZW5jZSBkYXRhIGZvcgorICogdGhlIGRvb3JiZWxsLCBhbmQg b25lIGNhY2hlbGluZSB3aGljaCBhY3R1YWxseSAqaXMqIHRoZSBkb29yYmVsbDsgYQorICogd3Jp dGUgdG8gdGhpcyB3aWxsICJyaW5nIHRoZSBkb29yYmVsbCIgKGkuZS4gc2VuZCBhbiBpbnRlcnJ1 cHQgdG8gdGhlCisgKiBHdUMpLiBUaGUgc3Vic2VxdWVudCAgcGFnZXMgb2YgdGhlIGNsaWVudCBv YmplY3QgY29uc3RpdHV0ZSB0aGUgd29yaworICogcXVldWUgKGEgY2lyY3VsYXIgYXJyYXkgb2Yg d29yayBpdGVtcyksIGFnYWluIGRlc2NyaWJlZCBpbiB0aGUgcHJvY2VzcworICogZGVzY3JpcHRv ci4gV29yayBxdWV1ZSBwYWdlcyBhcmUgbWFwcGVkIG1vbWVudGFyaWx5IGFzIHJlcXVpcmVkLgor ICoKKyAqIEZpbmFsbHksIHdlIGFsc28ga2VlcCBhIGZldyBzdGF0aXN0aWNzIGhlcmUsIGluY2x1 ZGluZyB0aGUgbnVtYmVyIG9mCisgKiBzdWJtaXNzaW9ucyB0byBlYWNoIGVuZ2luZSwgYW5kIGEg cmVjb3JkIG9mIHRoZSBsYXN0IHN1Ym1pc3Npb24gZmFpbHVyZQorICogKGlmIGFueSkuCisgKi8K IHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgewogCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpj bGllbnRfb2JqOwogCXZvaWQgKmNsaWVudF9iYXNlOwkJLyogZmlyc3QgcGFnZSAob25seSkgb2Yg YWJvdmUJKi8KLS0gCjEuOS4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK