From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Date: Mon, 9 Sep 2013 01:56:51 +0200 (CEST) Subject: [U-Boot] [PATCH 5/9] ARM: mx25: convert to common timer code In-Reply-To: <1378671174-18535-6-git-send-email-robherring2@gmail.com> References: <1378671174-18535-1-git-send-email-robherring2@gmail.com> <1378671174-18535-6-git-send-email-robherring2@gmail.com> Message-ID: <1465302347.1592613.1378684611384.JavaMail.zimbra@advansee.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Rob Herring, On Sunday, September 8, 2013 10:12:50 PM, Rob Herring wrote: > From: Rob Herring > > Convert mx25 to use the commmon timer code. > > Signed-off-by: Rob Herring > --- [...] > diff --git a/include/configs/mx25pdk.h b/include/configs/mx25pdk.h > index ccd3b6c..568ed6c 100644 > --- a/include/configs/mx25pdk.h > +++ b/include/configs/mx25pdk.h > @@ -15,6 +15,9 @@ > #define CONFIG_SYS_TEXT_BASE 0x81200000 > #define CONFIG_MXC_GPIO > > +#define CONFIG_SYS_TIMER_RATE 32768 ^ MXC_CLK32 could be used here. > +#define CONFIG_SYS_TIMER_COUNTER (IMX_GPT1_BASE + 0x24) This Linux-style (base + offset) register access is against U-Boot rules. You could write: (&((struct gpt_regs *)IMX_GPT1_BASE)->counter) > + > #define CONFIG_DISPLAY_CPUINFO > #define CONFIG_DISPLAY_BOARDINFO > > diff --git a/include/configs/tx25.h b/include/configs/tx25.h > index 2d7479b..f879441 100644 > --- a/include/configs/tx25.h > +++ b/include/configs/tx25.h > @@ -15,6 +15,8 @@ > */ > #define CONFIG_MX25 > #define CONFIG_MX25_CLK32 32000 /* OSC32K frequency */ > +#define CONFIG_SYS_TIMER_RATE CONFIG_MX25_CLK32 Ditto 1. > +#define CONFIG_SYS_TIMER_COUNTER (IMX_GPT1_BASE + 0x24) Ditto 2. > > #define CONFIG_SYS_MONITOR_LEN (256 << 10) /* 256 kB for U-Boot */ > > diff --git a/include/configs/zmx25.h b/include/configs/zmx25.h > index 2e7f145..deaadfa 100644 > --- a/include/configs/zmx25.h > +++ b/include/configs/zmx25.h > @@ -14,6 +14,9 @@ > #define CONFIG_MX25 > #define CONFIG_SYS_TEXT_BASE 0xA0000000 > > +#define CONFIG_SYS_TIMER_RATE 32768 Ditto 1. > +#define CONFIG_SYS_TIMER_COUNTER (IMX_GPT1_BASE + 0x24) Ditto 2. > + > #define CONFIG_MACH_TYPE MACH_TYPE_ZMX25 > /* > * Environment settings Best regards, Beno?t