Message-ID: <1465807715.4615.14.camel@toganlabs.com>
From: Beth 'pidge' Flanagan <pidge@toganlabs.com>
To: =?ISO-8859-1?Q?An=EDbal_Lim=F3n?= <anibal.limon@linux.intel.com>, 
	"Randle, William C" <william.c.randle@intel.com>, "Lock, Joshua G"
	<joshua.g.lock@intel.com>
Date: Mon, 13 Jun 2016 09:48:35 +0100
In-Reply-To: <5759DE3F.9040002@linux.intel.com>
References: <5759DE3F.9040002@linux.intel.com>
Organization: toganlabs.com
Mime-Version: 1.0
Cc: "yocto@yoctoproject.org" <yocto@yoctoproject.org>
Subject: Re: [yocto-autobuilder] [RFC] Add support for generate bitbake error reports
Precedence: list
Reply-To: pidge@toganlabs.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2016-06-09 at 16:23 -0500, An=C3=ADbal Lim=C3=B3n wrote:
> Hi folks,
>=20
> Currently we support to send error reports to errors.yoctoproject.org
> about failing tasks on bitbake using SendErrorReport buildstep but we
> have a lack of bitbake related errors like exceptions.
>=20
> A bug exist to implement this support into Error report web [1], i'm
> working on it but for generate bitbake error reports there's a need
> of
> some process monitoring the bitbake output in this case the Yocto
> Autobuilder.
>=20
> This email is for review my current implementation for generate
> bitbake
> error reports in the Autobuilder [2] next i'll try to explain how it
> works.
>=20
> I aadded a BitbakeShellCommand [3] class for use in the buildsteps
> that
> executes bitbake the main objective of this class is to have common
> operations to be made in bitbake commands like create error reports
> if
> fails.
>=20
> For create error reports this class add an stdio observer to look at
> bitbake output and if bitbake fails review the bitbake output for
> identify if the failure is an non-related task error [4]. If the
> observer found bitbake error creates an Error report with the
> information in the master controller.
>=20
> In order to send the bitbake error to Error report web the controller
> transfer the report to the worker using a new DownloadDirectory
> implementation that i made [5], the SendErrorReport buildstep works
> on
> the worker side so it's easy to transfer the reports from master to
> worker instead of send it by master.
>=20
> Finally to complete with the job of have the bitbake errors reports
> the
> Error report web changes need=C2=A0=C2=A0(i'm working on it) to be inte=
grated
> first in order to don't break anything.
>=20
> Please review it and provide me feedback.
>=20


1. fix the commit message to ea1d5b35bc77bad5d2
2. in same, why are you removing buildset-config.controller/poky-
tiny.conf? I believe this is still supported (and even if it isn't in
master, we maintain backwards compatibility)


As a whole, I like what is being done here. I would like this put on
the devel cluster before bringing it into production, just to smoke
test this, both with nightly builds and single builds. I can't see
anything that would obviously blow up though.

cheers,


-b

--=20
Beth 'pidge' Flanagan <pidge@toganlabs.com>
toganlabs.com


> Cheers,
> 	alimon
>=20
> [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=3D7583
> [2]
> http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?h=3Dco
> ntrib/alimon/devel
> [3]
> http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/
> python2.7/site-
> packages/autobuilder/lib/buildsteps.py?h=3Dcontrib/alimon/devel#n92
> [4]
> http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/
> python2.7/site-
> packages/autobuilder/lib/buildsteps.py?h=3Dcontrib/alimon/devel#n53
> [5]
> http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?h
> =3Dcontrib/alimon/devel&id=3D4022920bb0e56d1eef3dfe7c5e9b4699f801cdf1
>=20