Message-ID: <1466696154.2253.1.camel@toganlabs.com>
From: Beth 'pidge' Flanagan <pidge@toganlabs.com>
To: =?ISO-8859-1?Q?An=EDbal_Lim=F3n?= <anibal.limon@linux.intel.com>, 
	yocto@yoctoproject.org
Date: Thu, 23 Jun 2016 17:35:54 +0200
In-Reply-To: <576BFFDD.2090500@linux.intel.com>
References: <1466550472-1365-1-git-send-email-anibal.limon@linux.intel.com>
	<1466581487.3278.17.camel@toganlabs.com>
	<576AF245.4000400@linux.intel.com>
	<576BFFDD.2090500@linux.intel.com>
Organization: toganlabs.com
Mime-Version: 1.0
Cc: joshua.g.lock@intel.com
Subject: Re: [[yocto-autobuilder][PATCHv2] 00/15] Add support for generate bitbake/oe-selftest error reports
Precedence: list
Reply-To: pidge@toganlabs.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2016-06-23 at 10:27 -0500, An=C3=ADbal Lim=C3=B3n wrote:
>=20
> On 06/22/2016 03:17 PM, An=C3=ADbal Lim=C3=B3n wrote:
> >=20
> >=20
> >=20
> > On 06/22/2016 02:44 AM, Beth 'pidge' Flanagan wrote:
> > >=20
> > > On Tue, 2016-06-21 at 18:07 -0500, An=C3=ADbal Lim=C3=B3n wrote:
> > > >=20
> > > > This v2 adds support for generate also oe-selftest reports this
> > > > is
> > > > almost
> > > > the previous version with changes requested in review [1], the
> > > > next
> > > > patches
> > > > starts from patch,
> > > >=20
> > > > 	autobuilder/lib/{ABtools,builsteps}.py: Create
> > > > save_error_report func
> > > A few comments.
> > >=20
> > > - Please rebase the last two commits. They can be merged into
> > > prior
> > > commits.=C2=A0
> > >=20
> > > Example: 0eb495d93eefa9ead8f4b1242f251f1a2288db68 should be
> > > squashed
> > > into 83b6707622128436b4ece9d4c2a89311b000c209
> > >=20
> > > We shouldn't need rename commits for a pull request that created
> > > the
> > > original thing we're renaming.
> > >=20
> > > - Please fix the title for
> > > 83b6707622128436b4ece9d4c2a89311b000c209
> > > 's/buiidsets/buildsets/'
> > I squashed the changes now at,
> >=20
> > http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?h=3D
> > contrib/alimon/devel2
> >=20
> > 	alimon
> Hi,
>=20
> The Error report web needed changes are now integrated [1], if you
> ack'ed the changes we could proceed to integrate/deploy these changes
> to
> enable send Bitbake/OE-seltest errors to ERW.
>=20
> [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=3D7583#c14
>=20
> Cheers,
> 	alimon

Let me review them tonight and if they're ok, I'll pull them into
master.

-b


>=20
> >=20
> > >=20
> > >=20
> > >=20
> > > -b
> > >=20