From: "flichtenheld (Code Review)" Date: Mon, 11 Mar 2024 15:09:52 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <146e8085c52507619c71291b6ed54d30eea0abc4-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="OLiyMM+VzSY="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Avoid SIGUR1 to SIGHUP when the configuration is read from stdin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --OLiyMM+VzSY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/533?usp=3Demail ) Change subject: Avoid SIGUR1 to SIGHUP when the configuration is read from = stdin ...................................................................... Patch Set 1: (1 comment) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/533/comment/8488b519_2420d9dd : PS1, Line 11: "close_context usr1 to hup" logic, the OpenVPN process will f= ail as tries Please add a short explanation of when this logic might be hit. It is compl= etely unclear to me from the code how you might hit this (especially since = both HUP and USR1 are blocked during init_instance). Something with managem= ent? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/533?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icfc179490d6821e22d14817941fb0bad667c713f Gerrit-Change-Number: 533 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Mon, 11 Mar 2024 15:09:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --OLiyMM+VzSY= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    Commit Message:

    • Patch Set #1, Line 11: "close_context usr1 to hup" = logic, the OpenVPN process will fail as tries

      Please add a short explanation of w= hen this logic might be hit. It is completely unclear to me from the code h= ow you might hit this (especially since both HUP and USR1 are blocked durin= g init_instance). Something with management?

To v= iew, visit change 533. To unsubscribe, or for help writing mail filters, visit <= a href=3D"http://gerrit.openvpn.net/settings">settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icfc179490d6821e22d14817941f= b0bad667c713f
Gerrit-Change-Number: 533
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Mon, 11 Mar 2024 15:09:52= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--OLiyMM+VzSY=--