From: Ben Hutchings Subject: Re: linux-firmware-i915 pull request (bxt dmc, kbl dmc) Date: Wed, 03 Aug 2016 01:09:17 +0100 Message-ID: <1470182957.4176.183.camel@decadent.org.uk> References: <1467415169.26811.149.camel@intel.com> <87lh0fsa7w.fsf@intel.com> <1470170876.5637.38.camel@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2041406209==" Return-path: Received: from shadbolt.e.decadent.org.uk (shadbolt.e.decadent.org.uk [88.96.1.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43F506E262 for ; Wed, 3 Aug 2016 00:27:40 +0000 (UTC) In-Reply-To: <1470170876.5637.38.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" , "kmcmarti@redhat.com" , "intel-gfx@lists.freedesktop.org" , "kyle@infradead.org" , "jani.nikula@linux.intel.com" , "linux-firmware@kernel.org" List-Id: intel-gfx@lists.freedesktop.org --===============2041406209== Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-IRRa0Pfp7Lt5iB/00xae" --=-IRRa0Pfp7Lt5iB/00xae Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-08-02 at 20:48 +0000, Vivi, Rodrigo wrote: > On Tue, 2016-08-02 at 14:04 +0300, Jani Nikula wrote: [...] > > Why are you deleting old versions? >=20 > Mainly to keep it clean. OSVs pack that entire repo, I don't want i915 > taking unnecessary space from final users. Any filename requested by a driver in a stable release of Linux should not be removed from linux-firmware.git. =C2=A0If it's buggy then it should be replaced it with a fixed version. =C2=A0I can envisage extreme cases where we might make an exception but AFAIK this has not happened yet. The OS vendor knows which=C2=A0kernel versions they want to support and which files can therefore be dropped. I do that for Debian periodically. >=20 > I believe this is another point in favor of bringing the sym links > back. >=20 > But also because we need to remove any firmware that we know it is bad > and that would break the user. If it was blacklisted it was removed > from repo. > > Yet another reason for symbolic link. If we know the firmware is bad it > is bad for previous versions as well, but if we stay with the version > hardcoded we are forcing the user to stay with a firmware that we know > it is bad. Indeed. =C2=A0Please don't put a full version number in the filenames requested by drivers. =C2=A0Where it's not possible to maintain ABI compatibility between driver and firmware indefinitely then include an ABI version in the filename, but not the full version. Ben. --=20 Ben Hutchings Nothing is ever a complete failure; it can always serve as a bad example. --=-IRRa0Pfp7Lt5iB/00xae Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJXoTYtAAoJEOe/yOyVhhEJlQYP/2YsYbvkfHo/1aFIIBRDAMjf 9+7ePSasaWzVgxc6uLB+u7+IoQ3RDEq4jYkbosSVJ0zgbQgAy7EcWmGS6SySWuFI Ir+NE8eUnw+qBgyNs3la/vmd5pzCHGqIk5NgfFeYLzycDAkGfSr6FQ0C3Pk70PRe AjIh4qj98ivHkDswIB9OfmGQMzkFe/UGKB4qODBAPLm2fZsen/B2BZDTugrVtPG5 nIk7XBqOQnnhA3j6YxEr/nsvWnyRDV1rNWsqCpGiTTrqYk/1U2oujn5DC1t0GGX8 1wheYzbG8npqtdkDyA2Fe6I6x9a9j37xod1WNUWAMaT4xTiW0Te7zP0XYTY27EQt +DqCWT3z7dDL8QeAjZ8YI9lF0+ErjT8wTetOAIusL140wIpqDXc2qbFlk+J9AbJL f3Ra9TRPbiK84ImAhi+GPAzz1a0ytP4v+zSWZRGFvhBtXwUAsBPBWTaVyNgomfCd vasUEdOuS6KsqZFr54NS1E57aoEpulDoJglYizkKvVinXBUef9ufuXhmnEpgCD8/ BHLZx0FIb2ge6BDtE0I7mpLdlMV0+jC8MXtoQiLpFadt/aQB7IumRejaDGRYwZau ZYgAhp2xECukZS4R8IEmiWJgbJutu9xCcYJlLnzQV4T1I1E4Arbx5AadgCnNeDfo yyQX5H0lTatRHZ6VTkQ6 =KgIA -----END PGP SIGNATURE----- --=-IRRa0Pfp7Lt5iB/00xae-- --===============2041406209== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============2041406209==--