From: Andrej Krutak Subject: [PATCH 1/3] ALSA: line6: Remove double line6_pcm_release() after failed acquire. Date: Thu, 18 Aug 2016 23:52:10 +0200 Message-ID: <1471557132-10206-2-git-send-email-dev@andree.sk> References: <1471557132-10206-1-git-send-email-dev@andree.sk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by alsa0.perex.cz (Postfix) with ESMTP id 301A42661B5 for ; Thu, 18 Aug 2016 23:52:49 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id i138so1209536wmf.3 for ; Thu, 18 Aug 2016 14:52:49 -0700 (PDT) In-Reply-To: <1471557132-10206-1-git-send-email-dev@andree.sk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: tiwai@suse.com, perex@perex.cz, stefanha@gmail.com, grabner@icg.tugraz.at, alsa-devel@alsa-project.org Cc: Andrej Krutak List-Id: alsa-devel@alsa-project.org If there's an error, pcm is released in line6_pcm_acquire already. Signed-off-by: Andrej Krutak --- sound/usb/line6/pcm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/usb/line6/pcm.c b/sound/usb/line6/pcm.c index 204cc07..2bc8879 100644 --- a/sound/usb/line6/pcm.c +++ b/sound/usb/line6/pcm.c @@ -55,7 +55,6 @@ static int snd_line6_impulse_volume_put(struct snd_kcontrol *kcontrol, err = line6_pcm_acquire(line6pcm, LINE6_STREAM_IMPULSE); if (err < 0) { line6pcm->impulse_volume = 0; - line6_pcm_release(line6pcm, LINE6_STREAM_IMPULSE); return err; } } else { -- 1.9.1