From: Xie Ziyao Date: Wed, 16 Jun 2021 20:07:41 +0800 Subject: [LTP] [PATCH] typo: Add necessary spaces in the outputs In-Reply-To: References: <20210518064506.203781-1-xieziyao@huawei.com> <730f190e-4baa-f854-2c5e-8c6b9d4267df@huawei.com> Message-ID: <147203f7-eccc-09fb-4dd5-7083881fe84b@huawei.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi, Petr, > >> Ping. I checked it based on the latest code. Are there any changes that need >> to be added? > Well, as I note previously on some places it'd be better to join string, e.g. > testcases/kernel/syscalls/setsid/setsid01.c > testcases/open_posix_testsuite/conformance/interfaces/sched_setparam/2-1.c > testcases/kernel/syscalls/sysinfo/sysinfo02.c > > The reason is that string on single line is easier to grep. > That's why checkpatch.pl from kernel relaxed max line from 80 to 100 > (good at least for string). > > But I'm ok to merge it without. > Thanks, by the way, would you mind fixing this while you merge? It's also fine that I send v2 patch later to fix the problem. Thanks for your review. Kind Regards, Ziyao