From: Joe Perches Date: Mon, 26 Sep 2016 16:23:23 +0000 Subject: Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses Message-Id: <1474907003.2238.13.camel@perches.com> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <6d4bbb77-914f-19b8-a1a9-2731d1158612@users.sourceforge.net> <063D6719AE5E284EB5DD2968C1650D6DB0109E63@AcuExch.aculab.com> In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DB0109E63@AcuExch.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: David Laight , 'SF Markus Elfring' , "gigaset307x-common@lists.sourceforge.net" , "netdev@vger.kernel.org" , Karsten Keil , Paul Bolle Cc: LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall On Mon, 2016-09-26 at 16:00 +0000, David Laight wrote: > From: SF Markus Elfring Sent: 26 September 2016 16:45 > > The script "checkpatch.pl" can point information out like the following. > > WARNING: sizeof … should be sizeof(…) > [] > > diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c [] > > @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg, > >  { > >   unsigned char outbuf[80]; > >   unsigned char c; > > - size_t space = sizeof outbuf - 1; > > + size_t space = sizeof(outbuf - 1); > wrong ... > think that is 7 instead of 79. Well, it's sizeof(pointer) so either 4 or 8, but still, what Markus proposes here is _wrong_. Markus, do you know the script probably has a lower style conversion defect introduction rate than you do when doing these mechanical things. Please use it to verify what you are doing before submitting more defective patches. Excuses and apologies aren't good enough at this point.