From: Maarten Lankhorst Subject: [PATCH] drm/atomic: Fix double free in drm_atomic_state_default_clear Date: Tue, 31 Jan 2017 10:25:25 +0100 Message-ID: <1485854725-27640-1-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: dri-devel@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org ZHJtX2F0b21pY19oZWxwZXJfcGFnZV9mbGlwIGFuZCBkcm1fYXRvbWljX2lvY3RsIHNldCB0aGVp ciBvd24gZXZlbnRzCmluIGNydGNfc3RhdGUtPmV2ZW50LiBCdXQgd2hlbiBpdCdzIHNldCB0aGUg ZXZlbnQgaXMgZnJlZWQgaW4gMiBwbGFjZXMuCgpTb2x2ZSB0aGlzIGJ5IG9ubHkgZnJlZWluZyB0 aGUgZXZlbnQgaW4gdGhlIGF0b21pYyBpb2N0bCB3aGVuIGl0CmFsbG9jYXRlZCBpdHMgb3duIGV2 ZW50LgoKVGhpcyBoYXMgYmVlbiBicm9rZW4gdHdpY2UuIFRoZSBmaXJzdCB0aW1lIHdoZW4gdGhl IGNvZGUgd2FzIGludHJvZHVjZWQsCmJ1dCBvbmx5IGluIHRoZSBjb3JuZXIgY2FzZSB3aGVuIGFu IGV2ZW50IGlzIGFsbG9jYXRlZCwgYnV0IG1vcmUgY3J0YydzCndlcmUgaW5jbHVkZWQgYnkgYXRv bWljIGNoZWNrIGFuZCB0aGVuIGZhaWxpbmcuIFRoaXMgY2FuIG1vc3RseQpoYXBwZW4gd2hlbiB5 b3UgZG8gYW4gYXRvbWljIG1vZGVzZXQgaW4gaTkxNSBhbmQgdGhlIGRpc3BsYXkgY2xvY2sgaXMK Y2hhbmdlZCwgd2hpY2ggZm9yY2VzIGFsbCBjcnRjJ3MgdG8gYmUgaW5jbHVkZWQgdG8gdGhlIHN0 YXRlLgoKVGhpcyBoYXMgYmVlbiBicm9rZW4gd29yc2UgYnkgYWRkaW5nIGluLWZlbmNlcyBzdXBw b3J0LCB3aGljaCBjYXVzZWQKdGhlIGRvdWJsZSBmcmVlIHRvIGJlIGRvbmUgdW5jb25kaXRpb25h bGx5LgoKW0lHVF0ga21zX3JvdGF0aW9uX2NyYzogc3RhcnRpbmcgc3VidGVzdCBwcmltYXJ5LXJv dGF0aW9uLTE4MAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpCVUcga21hbGxvYy0xMjggKFRhaW50ZWQ6 IEcgICAgIFUgICAgICAgICApOiBPYmplY3QgYWxyZWFkeSBmcmVlCi0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCgpEaXNhYmxpbmcgbG9jayBkZWJ1Z2dpbmcgZHVlIHRvIGtlcm5lbCB0YWludApJTkZPOiBB bGxvY2F0ZWQgaW4gZHJtX2F0b21pY19oZWxwZXJfc2V0dXBfY29tbWl0KzB4Mjg1LzB4MmYwIFtk cm1fa21zX2hlbHBlcl0gYWdlPTAgY3B1PTMgcGlkPTE1MjkKIF9fX3NsYWJfYWxsb2MrMHgzMDgv MHgzYjAKIF9fc2xhYl9hbGxvYysweGQvMHgyMAoga21lbV9jYWNoZV9hbGxvY190cmFjZSsweDky LzB4MWMwCiBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9jb21taXQrMHgyODUvMHgyZjAgW2RybV9r bXNfaGVscGVyXQogaW50ZWxfYXRvbWljX2NvbW1pdCsweDM1LzB4NGYwIFtpOTE1XQogZHJtX2F0 b21pY19jb21taXQrMHg0Ni8weDUwIFtkcm1dCiBkcm1fbW9kZV9hdG9taWNfaW9jdGwrMHg3ZDQv MHhhYjAgW2RybV0KIGRybV9pb2N0bCsweDJiMy8weDQ5MCBbZHJtXQogZG9fdmZzX2lvY3RsKzB4 NjljLzB4NzAwCiBTeVNfaW9jdGwrMHg0ZS8weDgwCiBlbnRyeV9TWVNDQUxMXzY0X2Zhc3RwYXRo KzB4MTMvMHg5NApJTkZPOiBGcmVlZCBpbiBkcm1fZXZlbnRfY2FuY2VsX2ZyZWUrMHhhMy8weGIw IFtkcm1dIGFnZT0wIGNwdT0zIHBpZD0xNTI5CiBfX3NsYWJfZnJlZSsweDQ4LzB4MmUwCiBrZnJl ZSsweDE1OS8weDFhMAogZHJtX2V2ZW50X2NhbmNlbF9mcmVlKzB4YTMvMHhiMCBbZHJtXQogZHJt X21vZGVfYXRvbWljX2lvY3RsKzB4ODZkLzB4YWIwIFtkcm1dCiBkcm1faW9jdGwrMHgyYjMvMHg0 OTAgW2RybV0KIGRvX3Zmc19pb2N0bCsweDY5Yy8weDcwMAogU3lTX2lvY3RsKzB4NGUvMHg4MAog ZW50cnlfU1lTQ0FMTF82NF9mYXN0cGF0aCsweDEzLzB4OTQKSU5GTzogU2xhYiAweGZmZmZkZTFm MDk5N2IwODAgb2JqZWN0cz0xNyB1c2VkPTIgZnA9MHhmZmZmOTJmYjY1ZWMyNTc4IGZsYWdzPTB4 MjAwMDAwMDAwMDA4MTAxCklORk86IE9iamVjdCAweGZmZmY5MmZiNjVlYzI1NzggQG9mZnNldD0x NDAwIGZwPTB4ZmZmZjkyZmI2NWVjMmFlOAoKUmVkem9uZSBmZmZmOTJmYjY1ZWMyNTcwOiBiYiBi YiBiYiBiYiBiYiBiYiBiYiBiYiAgICAgICAgICAgICAgICAgICAgICAgICAgLi4uLi4uLi4KT2Jq ZWN0IGZmZmY5MmZiNjVlYzI1Nzg6IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZi IDZiIDZiIDZiIDZiICBra2tra2tra2tra2tra2trCk9iamVjdCBmZmZmOTJmYjY1ZWMyNTg4OiA2 YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiAga2tra2tra2tr a2tra2trawpPYmplY3QgZmZmZjkyZmI2NWVjMjU5ODogNmIgNmIgNmIgNmIgNmIgNmIgNmIgNmIg NmIgNmIgNmIgNmIgNmIgNmIgNmIgNmIgIGtra2tra2tra2tra2tra2sKT2JqZWN0IGZmZmY5MmZi NjVlYzI1YTg6IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZi ICBra2tra2tra2tra2tra2trCk9iamVjdCBmZmZmOTJmYjY1ZWMyNWI4OiA2YiA2YiA2YiA2YiA2 YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiAga2tra2tra2tra2tra2trawpPYmpl Y3QgZmZmZjkyZmI2NWVjMjVjODogNmIgNmIgNmIgNmIgNmIgNmIgNmIgNmIgNmIgNmIgNmIgNmIg NmIgNmIgNmIgNmIgIGtra2tra2tra2tra2tra2sKT2JqZWN0IGZmZmY5MmZiNjVlYzI1ZDg6IDZi IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiICBra2tra2tra2tr a2tra2trCk9iamVjdCBmZmZmOTJmYjY1ZWMyNWU4OiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2YiA2 YiA2YiA2YiA2YiA2YiA2YiA2YiBhNSAga2tra2tra2tra2tra2trLgpSZWR6b25lIGZmZmY5MmZi NjVlYzI1Zjg6IGJiIGJiIGJiIGJiIGJiIGJiIGJiIGJiICAgICAgICAgICAgICAgICAgICAgICAg ICAuLi4uLi4uLgpQYWRkaW5nIGZmZmY5MmZiNjVlYzI3Mzg6IDVhIDVhIDVhIDVhIDVhIDVhIDVh IDVhICAgICAgICAgICAgICAgICAgICAgICAgICBaWlpaWlpaWgpDUFU6IDMgUElEOiAxODAgQ29t bToga3dvcmtlci8zOjIgVGFpbnRlZDogRyAgICBCVSAgICAgICAgICA0LjEwLjAtcmM2LXBhdHNl cisgIzUwMzkKSGFyZHdhcmUgbmFtZTogICAgICAgICAgICAgICAgICAvTlVDNVBQWUIsIEJJT1Mg UFlCU1dDRUwuODZBLjAwMzEuMjAxNS4wNjAxLjE3MTIgMDYvMDEvMjAxNQpXb3JrcXVldWU6IGV2 ZW50cyBpbnRlbF9hdG9taWNfaGVscGVyX2ZyZWVfc3RhdGUgW2k5MTVdCkNhbGwgVHJhY2U6CiBk dW1wX3N0YWNrKzB4NGQvMHg2ZAogcHJpbnRfdHJhaWxlcisweDIwYy8weDIyMAogZnJlZV9kZWJ1 Z19wcm9jZXNzaW5nKzB4MWM2LzB4MzMwCiA/IGRybV9hdG9taWNfc3RhdGVfZGVmYXVsdF9jbGVh cisweGY3LzB4MWMwIFtkcm1dCiBfX3NsYWJfZnJlZSsweDQ4LzB4MmUwCiA/IGRybV9hdG9taWNf c3RhdGVfZGVmYXVsdF9jbGVhcisweGY3LzB4MWMwIFtkcm1dCiBrZnJlZSsweDE1OS8weDFhMAog ZHJtX2F0b21pY19zdGF0ZV9kZWZhdWx0X2NsZWFyKzB4ZjcvMHgxYzAgW2RybV0KID8gZHJtX2F0 b21pY19zdGF0ZV9jbGVhcisweDMwLzB4MzAgW2RybV0KIGludGVsX2F0b21pY19zdGF0ZV9jbGVh cisweGQvMHgyMCBbaTkxNV0KIGRybV9hdG9taWNfc3RhdGVfY2xlYXIrMHgxYS8weDMwIFtkcm1d CiBfX2RybV9hdG9taWNfc3RhdGVfZnJlZSsweDEzLzB4NjAgW2RybV0KIGludGVsX2F0b21pY19o ZWxwZXJfZnJlZV9zdGF0ZSsweDVkLzB4NzAgW2k5MTVdCiBwcm9jZXNzX29uZV93b3JrKzB4MjYw LzB4NGEwCiB3b3JrZXJfdGhyZWFkKzB4MmQxLzB4NGYwCiBrdGhyZWFkKzB4MTI3LzB4MTMwCiA/ IHByb2Nlc3Nfb25lX3dvcmsrMHg0YTAvMHg0YTAKID8ga3RocmVhZF9zdG9wKzB4MTIwLzB4MTIw CiByZXRfZnJvbV9mb3JrKzB4MjkvMHg0MApGSVgga21hbGxvYy0xMjg6IE9iamVjdCBhdCAweGZm ZmY5MmZiNjVlYzI1Nzggbm90IGZyZWVkCgpGaXhlczogM2IyNGY3ZDY3NTgxICgiZHJtL2F0b21p YzogQWRkIHN0cnVjdCBkcm1fY3J0Y19jb21taXQgdG8gdHJhY2sgYXN5bmMgdXBkYXRlcyIpCkZp eGVzOiA5NjI2MDE0MjU4YTUgKCJkcm0vZmVuY2U6IGFkZCBpbi1mZW5jZXMgc3VwcG9ydCIpCkNj OiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC44KwpDYzogRGFuaWVsIFZldHRlciA8ZGFu aWVsLnZldHRlckBmZndsbC5jaD4KU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1h YXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0 ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Ci0tLQogZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWMuYyB8IDEzICsrKysrKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyks IDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMu YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKaW5kZXggNTBmNWNmN2I2OWQxLi5mZGZi MWVjMTdlNjYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKKysrIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwpAQCAtMjAzMiwxMyArMjAzMiwxNiBAQCBzdGF0 aWMgdm9pZCBjb21wbGV0ZV9jcnRjX3NpZ25hbGluZyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAog CX0KIAogCWZvcl9lYWNoX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkp IHsKKwkJc3RydWN0IGRybV9wZW5kaW5nX3ZibGFua19ldmVudCAqZXZlbnQgPSBjcnRjX3N0YXRl LT5ldmVudDsKIAkJLyoKLQkJICogVEVTVF9PTkxZIGFuZCBQQUdFX0ZMSVBfRVZFTlQgYXJlIG11 dHVhbGx5Ci0JCSAqIGV4Y2x1c2l2ZSwgaWYgdGhleSB3ZXJlbid0LCB0aGlzIGNvZGUgc2hvdWxk IGJlCi0JCSAqIGNhbGxlZCBvbiBzdWNjZXNzIGZvciBURVNUX09OTFkgdG9vLgorCQkgKiBGcmVl IHRoZSBhbGxvY2F0ZWQgZXZlbnQuIGRybV9hdG9taWNfaGVscGVyX3NldHVwX2NvbW1pdAorCQkg KiBjYW4gYWxsb2NhdGUgYW4gZXZlbnQgdG9vLCBzbyBvbmx5IGZyZWUgaXQgaWYgaXQncyBvdXJz CisJCSAqIHRvIHByZXZlbnQgYSBkb3VibGUgZnJlZSBpbiBkcm1fYXRvbWljX3N0YXRlX2NsZWFy LgogCQkgKi8KLQkJaWYgKGNydGNfc3RhdGUtPmV2ZW50KQotCQkJZHJtX2V2ZW50X2NhbmNlbF9m cmVlKGRldiwgJmNydGNfc3RhdGUtPmV2ZW50LT5iYXNlKTsKKwkJaWYgKGV2ZW50ICYmIChldmVu dC0+YmFzZS5mZW5jZSB8fCBldmVudC0+YmFzZS5maWxlX3ByaXYpKSB7CisJCQlkcm1fZXZlbnRf Y2FuY2VsX2ZyZWUoZGV2LCAmZXZlbnQtPmJhc2UpOworCQkJY3J0Y19zdGF0ZS0+ZXZlbnQgPSBO VUxMOworCQl9CiAJfQogCiAJaWYgKCFmZW5jZV9zdGF0ZSkKLS0gCjIuNy40CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK