Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ccef6-0003Dg-IF for mharc-grub-devel@gnu.org; Sat, 11 Feb 2017 15:52:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccef4-0003CW-LV for grub-devel@gnu.org; Sat, 11 Feb 2017 15:52:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccef1-0006yL-K5 for grub-devel@gnu.org; Sat, 11 Feb 2017 15:52:50 -0500 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:33101) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ccef1-0006xw-Cv for grub-devel@gnu.org; Sat, 11 Feb 2017 15:52:47 -0500 Received: by mail-lf0-x241.google.com with SMTP id x1so5508479lff.0 for ; Sat, 11 Feb 2017 12:52:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=fgIj40LuH4tuTYVkcjo7I+5iAJKZqTAiZ2/Fce1vqxM=; b=E4WjonvIhIiWuFrMol44yjj1Jo0T1q/gh2IINfe1j5iqUy6fkIPT8uxtf288ZtZHRH B1/15Ibt1+/lJvA5h6ZskVWTBxBrQALr6P8bjVr6c/EAOYyW6EGi3shznZABJrGd4yTw 7g6ZaqTj2FTnCTjoUWjR6hjPy8fbd2qdap2GLlOkSD1XaxAE9IZacYeSWjYD+rxs1qPa 7torU/Q2hvzuzKAwzyXgDJFZfytc+InCJ+4W0wb5TzPY4aBkYupEZAWsPvNv4awNv2tl BNkFcCluVO499dpdL7EFtodX9NH4LWGl5R0RQeWI2dFOUb3pGaKTTjT48RR7aVPgrFRi uCXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=fgIj40LuH4tuTYVkcjo7I+5iAJKZqTAiZ2/Fce1vqxM=; b=i/HROWENlrzkrsYYrXL8OT3Nas4txTARioE9w5x1jVEto+2Znxk+rnX+r1ivFyBSra V/m5MKmKxL320/kO9rADxPmG9y48qCofSnc1GK+gXpNX5R4AlEfbHceAmrPgsy1Phh0R iE0gzskOlitRSIhEcp97xEGNjC9sLvGXQWwoUtWasVUdcqf/00r/Y1iGLs4S2INlq1y4 zfZ/KWDPtHwdiQ0WqCX0ORF/XlFo8bk56YF2VDWcW6N4U9aznDXHO6KQbW2HI+fCC4WJ YrQLNTVij3236K1EItp/gi2uxadqm6YMUzV+MFw0iD6nWIDae5t6LYXvOp6pPtSRGOcp TzYw== X-Gm-Message-State: AMke39nc68RaZbBHHFTb181A84phEGkpQNDQydtWFolSMiaU7zeaVLBEmuKJcNwfeRSvVg== X-Received: by 10.25.56.21 with SMTP id f21mr1688448lfa.83.1486846365758; Sat, 11 Feb 2017 12:52:45 -0800 (PST) Received: from localhost.localdomain (ppp109-252-90-129.pppoe.spdop.ru. [109.252.90.129]) by smtp.gmail.com with ESMTPSA id v10sm1501683lja.14.2017.02.11.12.52.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 11 Feb 2017 12:52:44 -0800 (PST) From: Andrei Borzenkov To: grub-devel@gnu.org Subject: [PATCH] script: fix double free in lexer Date: Sat, 11 Feb 2017 23:52:39 +0300 Message-Id: <1486846359-28406-1-git-send-email-arvidjaar@gmail.com> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::241 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Feb 2017 20:52:51 -0000 yylex_destroy() already frees scanner. Found by: Coverity scan. CID: 176636 --- grub-core/script/lexer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/grub-core/script/lexer.c b/grub-core/script/lexer.c index 89cf677..c6bd317 100644 --- a/grub-core/script/lexer.c +++ b/grub-core/script/lexer.c @@ -251,7 +251,6 @@ grub_script_lexer_init (struct grub_parser_param *parser, char *script, { parser->lexerstate = 0; yylex_destroy (lexerstate->yyscanner); - grub_free (lexerstate->yyscanner); grub_free (lexerstate->text); grub_free (lexerstate); return 0; -- tg: (5298187..) coverity/176636 (depends on: master)