Return-Path: Received: from mga03.intel.com ([134.134.136.65]:48760 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933157AbdBPWOo (ORCPT ); Thu, 16 Feb 2017 17:14:44 -0500 From: Tim Chen To: Herbert Xu , "David S. Miller" Cc: Tim Chen , megha.dey@linux.intel.com, Dmitry Vyukov , stable@vger.kernel.org Subject: [PATCH 1/2] crypto/sha512-mb: Correct initialization value for lane lens Date: Thu, 16 Feb 2017 14:15:05 -0800 Message-Id: <1487283306-22634-1-git-send-email-tim.c.chen@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: The wrong value was used to initialize the lane lens for sha512-mb's mgr structure. This could cause a NULL pointer access of jobs structure if sha512_job_mgr_get_comp_job is called to get completed jobs. We assume that lens that don't have 0xFFFFFFFF in upper half of lens have valid job and have a job structue, leading to invalide pointer access. Cc: stable@vger.kernel.org Signed-off-by: Tim Chen --- arch/x86/crypto/sha512-mb/sha512_mb_mgr_init_avx2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/crypto/sha512-mb/sha512_mb_mgr_init_avx2.c b/arch/x86/crypto/sha512-mb/sha512_mb_mgr_init_avx2.c index 36870b2..5484d77 100644 --- a/arch/x86/crypto/sha512-mb/sha512_mb_mgr_init_avx2.c +++ b/arch/x86/crypto/sha512-mb/sha512_mb_mgr_init_avx2.c @@ -57,10 +57,10 @@ void sha512_mb_mgr_init_avx2(struct sha512_mb_mgr *state) { unsigned int j; - state->lens[0] = 0; - state->lens[1] = 1; - state->lens[2] = 2; - state->lens[3] = 3; + state->lens[0] = 0xFFFFFFFF00000000; + state->lens[1] = 0xFFFFFFFF00000001; + state->lens[2] = 0xFFFFFFFF00000002; + state->lens[3] = 0xFFFFFFFF00000003; state->unused_lanes = 0xFF03020100; for (j = 0; j < 4; j++) state->ldata[j].job_in_lane = NULL; -- 2.5.5