Message-ID: <1489393453.13980.28.camel@linuxfoundation.org>
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>,
	openembedded-core@lists.openembedded.org
Date: Mon, 13 Mar 2017 08:24:13 +0000
In-Reply-To: <4ae06894c190997f459b4d50aa09d5011b80fb7f.1489391139.git.liezhi.yang@windriver.com>
References: <cover.1489391139.git.liezhi.yang@windriver.com>
	<4ae06894c190997f459b4d50aa09d5011b80fb7f.1489391139.git.liezhi.yang@windriver.com>
Mime-Version: 1.0
Subject: Re: [PATCH 2/2] devshell.bbclass: add editors for devshell
Precedence: list
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

On Mon, 2017-03-13 at 00:46 -0700, Robert Yang wrote:
> * The vi, vim, emacs and nano can be used in devshell.
> 
> * The groups, lesspipe and dircolors are required by
> /etc/skel/.bashrc on
>   Ubuntu 14.04, otherwise, there would be warnings when start
> devshell:
>     bash: groups: command not found
>     bash: lesspipe: command not found
>     bash: dircolors: command not found
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/classes/devshell.bbclass | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/classes/devshell.bbclass
> b/meta/classes/devshell.bbclass
> index 4de7ea6fce..055d21ba50 100644
> --- a/meta/classes/devshell.bbclass
> +++ b/meta/classes/devshell.bbclass
> @@ -2,6 +2,12 @@ inherit terminal
>  
>  DEVSHELL = "${SHELL}"
>  
> +# Tools used in devshell
> +HOSTTOOLS_NONFATAL += "vi vim emacs nano"

Thinking about this further, I think we need to restore PATH for the
devshell. We can't really go down the road of trying to add in links
for any tool the developer may want to use...

Cheers,

Richard