From: Mario Kleiner Subject: [PATCH 1/2] drm/radeon: Avoid overflows/divide-by-zero in latency_watermark calculations. Date: Mon, 24 Apr 2017 01:33:08 +0200 Message-ID: <1492990389-10156-2-git-send-email-mario.kleiner.de@gmail.com> References: <1492990389-10156-1-git-send-email-mario.kleiner.de@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1492990389-10156-1-git-send-email-mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alex Deucher , mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QXQgZG90IGNsb2NrcyA+IGFwcHJveC4gMjUwIE1oeiwgc29tZSBvZiB0aGVzZSBjYWxjcyB3aWxs IG92ZXJmbG93IGFuZApjYXVzZSBtaXNjYWxjdWxhdGlvbiBvZiBsYXRlbmN5IHdhdGVybWFya3Ms IGFuZCBmb3Igc29tZSBvdmVyZmxvd3MgYWxzbwpkaXZpZGUtYnktemVybyBkcml2ZXIgY3Jhc2gu IE1ha2UgY2FsY3MgbW9yZSBvdmVyZmxvdyByZXNpc3RhbnQuCgpUaGlzIGlzIGEgZGlyZWN0IHBv cnQgb2YgdGhlIGNvcnJlc3BvbmRpbmcgcGF0Y2ggZnJvbSBhbWRncHUta21zLApjb3B5LXBhc3Rl IGZvciBjaWsgZnJvbSBkY2UtOCBhbmQgc2kgZnJvbSBkY2UtNiwgd2l0aCBhIHNsaWdodGx5CnNp bXBsZXIgdmFyaWFudCBmb3IgZXZlcmdyZWVuIGRjZS00LzUuCgpPbmx5IHRlc3RlZCBvbiBEQ0Ut NCBldmVyZ3JlZW4gd2l0aCBhIFJhZGVvbiBIRC01NzcwLgoKU2lnbmVkLW9mZi1ieTogTWFyaW8g S2xlaW5lciA8bWFyaW8ua2xlaW5lci5kZUBnbWFpbC5jb20+CkNjOiBBbGV4IERldWNoZXIgPGFs ZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9jaWsu YyAgICAgICB8IDE5ICsrKy0tLS0tLS0tLS0tLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24v ZXZlcmdyZWVuLmMgfCAgOCArLS0tLS0tLQogZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9zaS5jICAg ICAgICB8IDE5ICsrKy0tLS0tLS0tLS0tLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRp b25zKCspLCAzOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmFk ZW9uL2Npay5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9jaWsuYwppbmRleCA1MzcxMGRkLi40 ZjAzNGNiIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2Npay5jCisrKyBiL2Ry aXZlcnMvZ3B1L2RybS9yYWRlb24vY2lrLmMKQEAgLTkxNTAsMjMgKzkxNTAsMTAgQEAgc3RhdGlj IHUzMiBkY2U4X2xhdGVuY3lfd2F0ZXJtYXJrKHN0cnVjdCBkY2U4X3dtX3BhcmFtcyAqd20pCiAJ YS5mdWxsID0gZGZpeGVkX2NvbnN0KGF2YWlsYWJsZV9iYW5kd2lkdGgpOwogCWIuZnVsbCA9IGRm aXhlZF9jb25zdCh3bS0+bnVtX2hlYWRzKTsKIAlhLmZ1bGwgPSBkZml4ZWRfZGl2KGEsIGIpOwor CXRtcCA9IGRpdl91NjQoKHU2NCkgZG1pZl9zaXplICogKHU2NCkgd20tPmRpc3BfY2xrLCBtY19s YXRlbmN5ICsgNTEyKTsKKwl0bXAgPSBtaW4oZGZpeGVkX3RydW5jKGEpLCB0bXApOwogCi0JYi5m dWxsID0gZGZpeGVkX2NvbnN0KG1jX2xhdGVuY3kgKyA1MTIpOwotCWMuZnVsbCA9IGRmaXhlZF9j b25zdCh3bS0+ZGlzcF9jbGspOwotCWIuZnVsbCA9IGRmaXhlZF9kaXYoYiwgYyk7Ci0KLQljLmZ1 bGwgPSBkZml4ZWRfY29uc3QoZG1pZl9zaXplKTsKLQliLmZ1bGwgPSBkZml4ZWRfZGl2KGMsIGIp OwotCi0JdG1wID0gbWluKGRmaXhlZF90cnVuYyhhKSwgZGZpeGVkX3RydW5jKGIpKTsKLQotCWIu ZnVsbCA9IGRmaXhlZF9jb25zdCgxMDAwKTsKLQljLmZ1bGwgPSBkZml4ZWRfY29uc3Qod20tPmRp c3BfY2xrKTsKLQliLmZ1bGwgPSBkZml4ZWRfZGl2KGMsIGIpOwotCWMuZnVsbCA9IGRmaXhlZF9j b25zdCh3bS0+Ynl0ZXNfcGVyX3BpeGVsKTsKLQliLmZ1bGwgPSBkZml4ZWRfbXVsKGIsIGMpOwot Ci0JbGJfZmlsbF9idyA9IG1pbih0bXAsIGRmaXhlZF90cnVuYyhiKSk7CisJbGJfZmlsbF9idyA9 IG1pbih0bXAsIHdtLT5kaXNwX2NsayAqIHdtLT5ieXRlc19wZXJfcGl4ZWwgLyAxMDAwKTsKIAog CWEuZnVsbCA9IGRmaXhlZF9jb25zdChtYXhfc3JjX2xpbmVzX3Blcl9kc3RfbGluZSAqIHdtLT5z cmNfd2lkdGggKiB3bS0+Ynl0ZXNfcGVyX3BpeGVsKTsKIAliLmZ1bGwgPSBkZml4ZWRfY29uc3Qo MTAwMCk7CmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2ZXJncmVlbi5jIGIv ZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9ldmVyZ3JlZW4uYwppbmRleCBkMWIxZTBjLi4zYzljMTMz IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2V2ZXJncmVlbi5jCisrKyBiL2Ry aXZlcnMvZ3B1L2RybS9yYWRlb24vZXZlcmdyZWVuLmMKQEAgLTIxODgsMTMgKzIxODgsNyBAQCBz dGF0aWMgdTMyIGV2ZXJncmVlbl9sYXRlbmN5X3dhdGVybWFyayhzdHJ1Y3QgZXZlcmdyZWVuX3dt X3BhcmFtcyAqd20pCiAJYi5mdWxsID0gZGZpeGVkX2NvbnN0KHdtLT5udW1faGVhZHMpOwogCWEu ZnVsbCA9IGRmaXhlZF9kaXYoYSwgYik7CiAKLQliLmZ1bGwgPSBkZml4ZWRfY29uc3QoMTAwMCk7 Ci0JYy5mdWxsID0gZGZpeGVkX2NvbnN0KHdtLT5kaXNwX2Nsayk7Ci0JYi5mdWxsID0gZGZpeGVk X2RpdihjLCBiKTsKLQljLmZ1bGwgPSBkZml4ZWRfY29uc3Qod20tPmJ5dGVzX3Blcl9waXhlbCk7 Ci0JYi5mdWxsID0gZGZpeGVkX211bChiLCBjKTsKLQotCWxiX2ZpbGxfYncgPSBtaW4oZGZpeGVk X3RydW5jKGEpLCBkZml4ZWRfdHJ1bmMoYikpOworCWxiX2ZpbGxfYncgPSBtaW4oZGZpeGVkX3Ry dW5jKGEpLCB3bS0+ZGlzcF9jbGsgKiB3bS0+Ynl0ZXNfcGVyX3BpeGVsIC8gMTAwMCk7CiAKIAlh LmZ1bGwgPSBkZml4ZWRfY29uc3QobWF4X3NyY19saW5lc19wZXJfZHN0X2xpbmUgKiB3bS0+c3Jj X3dpZHRoICogd20tPmJ5dGVzX3Blcl9waXhlbCk7CiAJYi5mdWxsID0gZGZpeGVkX2NvbnN0KDEw MDApOwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9zaS5jIGIvZHJpdmVycy9n cHUvZHJtL3JhZGVvbi9zaS5jCmluZGV4IDUyOGU1YTQuLjNlZmRmZDAgMTAwNjQ0Ci0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9yYWRlb24vc2kuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Np LmMKQEAgLTIyMDQsMjMgKzIyMDQsMTAgQEAgc3RhdGljIHUzMiBkY2U2X2xhdGVuY3lfd2F0ZXJt YXJrKHN0cnVjdCBkY2U2X3dtX3BhcmFtcyAqd20pCiAJYS5mdWxsID0gZGZpeGVkX2NvbnN0KGF2 YWlsYWJsZV9iYW5kd2lkdGgpOwogCWIuZnVsbCA9IGRmaXhlZF9jb25zdCh3bS0+bnVtX2hlYWRz KTsKIAlhLmZ1bGwgPSBkZml4ZWRfZGl2KGEsIGIpOworCXRtcCA9IGRpdl91NjQoKHU2NCkgZG1p Zl9zaXplICogKHU2NCkgd20tPmRpc3BfY2xrLCBtY19sYXRlbmN5ICsgNTEyKTsKKwl0bXAgPSBt aW4oZGZpeGVkX3RydW5jKGEpLCB0bXApOwogCi0JYi5mdWxsID0gZGZpeGVkX2NvbnN0KG1jX2xh dGVuY3kgKyA1MTIpOwotCWMuZnVsbCA9IGRmaXhlZF9jb25zdCh3bS0+ZGlzcF9jbGspOwotCWIu ZnVsbCA9IGRmaXhlZF9kaXYoYiwgYyk7Ci0KLQljLmZ1bGwgPSBkZml4ZWRfY29uc3QoZG1pZl9z aXplKTsKLQliLmZ1bGwgPSBkZml4ZWRfZGl2KGMsIGIpOwotCi0JdG1wID0gbWluKGRmaXhlZF90 cnVuYyhhKSwgZGZpeGVkX3RydW5jKGIpKTsKLQotCWIuZnVsbCA9IGRmaXhlZF9jb25zdCgxMDAw KTsKLQljLmZ1bGwgPSBkZml4ZWRfY29uc3Qod20tPmRpc3BfY2xrKTsKLQliLmZ1bGwgPSBkZml4 ZWRfZGl2KGMsIGIpOwotCWMuZnVsbCA9IGRmaXhlZF9jb25zdCh3bS0+Ynl0ZXNfcGVyX3BpeGVs KTsKLQliLmZ1bGwgPSBkZml4ZWRfbXVsKGIsIGMpOwotCi0JbGJfZmlsbF9idyA9IG1pbih0bXAs IGRmaXhlZF90cnVuYyhiKSk7CisJbGJfZmlsbF9idyA9IG1pbih0bXAsIHdtLT5kaXNwX2NsayAq IHdtLT5ieXRlc19wZXJfcGl4ZWwgLyAxMDAwKTsKIAogCWEuZnVsbCA9IGRmaXhlZF9jb25zdCht YXhfc3JjX2xpbmVzX3Blcl9kc3RfbGluZSAqIHdtLT5zcmNfd2lkdGggKiB3bS0+Ynl0ZXNfcGVy X3BpeGVsKTsKIAliLmZ1bGwgPSBkZml4ZWRfY29uc3QoMTAwMCk7Ci0tIAoyLjcuNAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5n IGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==