From: Alex Xie Subject: [PATCH 2/4] drm/amdgpu: Fix use of interruptible waiting 1. The signal interrupt can affect the expected behaviour. 2. There is no mechanism to handle the corresponding error. Date: Mon, 24 Apr 2017 14:29:03 -0400 Message-ID: <1493058545-9733-2-git-send-email-AlexBin.Xie@amd.com> References: <1493058545-9733-1-git-send-email-AlexBin.Xie@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1493058545-9733-1-git-send-email-AlexBin.Xie-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alex Xie Q2hhbmdlLUlkOiBJNDNmM2IwYjQyMDgzM2EwMmFkNWVjZTNkZGVlZjA0YzY1MTI2NjdlOQpTaWdu ZWQtb2ZmLWJ5OiBBbGV4IFhpZSA8QWxleEJpbi5YaWVAYW1kLmNvbT4KLS0tCiBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfZGV2aWNlLmMKaW5kZXggMDUxNjk2ZC4uNGQwNGFmOSAxMDA2NDQKLS0t IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCisrKyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwpAQCAtMjE4MSw3ICsyMTgxLDcg QEAgaW50IGFtZGdwdV9kZXZpY2Vfc3VzcGVuZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBib29s IHN1c3BlbmQsIGJvb2wgZmJjb24pCiAKIAkJaWYgKGFtZGdwdV9jcnRjLT5jdXJzb3JfYm8pIHsK IAkJCXN0cnVjdCBhbWRncHVfYm8gKmFvYmogPSBnZW1fdG9fYW1kZ3B1X2JvKGFtZGdwdV9jcnRj LT5jdXJzb3JfYm8pOwotCQkJciA9IGFtZGdwdV9ib19yZXNlcnZlKGFvYmosIGZhbHNlKTsKKwkJ CXIgPSBhbWRncHVfYm9fcmVzZXJ2ZShhb2JqLCB0cnVlKTsKIAkJCWlmIChyID09IDApIHsKIAkJ CQlhbWRncHVfYm9fdW5waW4oYW9iaik7CiAJCQkJYW1kZ3B1X2JvX3VucmVzZXJ2ZShhb2JqKTsK QEAgLTIxOTQsNyArMjE5NCw3IEBAIGludCBhbWRncHVfZGV2aWNlX3N1c3BlbmQoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwgYm9vbCBzdXNwZW5kLCBib29sIGZiY29uKQogCQlyb2JqID0gZ2VtX3Rv X2FtZGdwdV9ibyhyZmItPm9iaik7CiAJCS8qIGRvbid0IHVucGluIGtlcm5lbCBmYiBvYmplY3Rz ICovCiAJCWlmICghYW1kZ3B1X2ZiZGV2X3JvYmpfaXNfZmIoYWRldiwgcm9iaikpIHsKLQkJCXIg PSBhbWRncHVfYm9fcmVzZXJ2ZShyb2JqLCBmYWxzZSk7CisJCQlyID0gYW1kZ3B1X2JvX3Jlc2Vy dmUocm9iaiwgdHJ1ZSk7CiAJCQlpZiAociA9PSAwKSB7CiAJCQkJYW1kZ3B1X2JvX3VucGluKHJv YmopOwogCQkJCWFtZGdwdV9ib191bnJlc2VydmUocm9iaik7CkBAIC0yMzAxLDcgKzIzMDEsNyBA QCBpbnQgYW1kZ3B1X2RldmljZV9yZXN1bWUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgYm9vbCBy ZXN1bWUsIGJvb2wgZmJjb24pCiAKIAkJaWYgKGFtZGdwdV9jcnRjLT5jdXJzb3JfYm8pIHsKIAkJ CXN0cnVjdCBhbWRncHVfYm8gKmFvYmogPSBnZW1fdG9fYW1kZ3B1X2JvKGFtZGdwdV9jcnRjLT5j dXJzb3JfYm8pOwotCQkJciA9IGFtZGdwdV9ib19yZXNlcnZlKGFvYmosIGZhbHNlKTsKKwkJCXIg PSBhbWRncHVfYm9fcmVzZXJ2ZShhb2JqLCB0cnVlKTsKIAkJCWlmIChyID09IDApIHsKIAkJCQly ID0gYW1kZ3B1X2JvX3Bpbihhb2JqLAogCQkJCQkJICBBTURHUFVfR0VNX0RPTUFJTl9WUkFNLAot LSAKMS45LjEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=