From: "Pandiyan, Dhinakaran" Subject: Re: [PATCH RESEND v4 1/6] drm/i915: Add DPCD preferred mode for backlight control Date: Wed, 3 May 2017 01:19:34 +0000 Message-ID: <1493775555.26491.152.camel@dk-H97M-D3H> References: <20170418234824.157355-1-puthik@chromium.org> <20170418234824.157355-2-puthik@chromium.org> <1493774051.26491.142.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E40696E18D for ; Wed, 3 May 2017 01:19:37 +0000 (UTC) In-Reply-To: <1493774051.26491.142.camel@dk-H97M-D3H> Content-Language: en-US Content-ID: <4A57106836B6A14ABBFFB782DBA3C32F@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "puthik@chromium.org" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE3LTA1LTAzIGF0IDAwOjU0ICswMDAwLCBQYW5kaXlhbiwgRGhpbmFrYXJhbiB3 cm90ZToNCj4gU29ycnkgZm9yIHRoZSB3YWl0LiBUaGlzIGlzIG5vdCBhIGNvbXBsZXRlIHJldmll dywganVzdCBzb21lIHF1aWNrDQo+IGNvbW1lbnRzIGZvciBub3cuDQo+IA0KPiANCj4gT24gVHVl LCAyMDE3LTA0LTE4IGF0IDE2OjQ4IC0wNzAwLCBQdXRoaWtvcm4gVm9yYXZvb3RpdmF0IHdyb3Rl Og0KPiA+IEN1cnJlbnRseSB0aGUgaW50ZWxfZHBfYXV4X2JhY2tsaWdodCBkcml2ZXIgcmVxdWly ZXMgZURQIHBhbmVsDQo+ID4gdG8gbm90IGFsc28gc3VwcG9ydCBiYWNrbGlnaHQgYWRqdXN0bWVu dCB2aWEgUFdNIHBpbiB0byB1c2UNCj4gPiB0aGlzIGRyaXZlci4NCj4gPiANCj4gPiBUaGlzIGZv cmNlIHRoZSBlRFAgcGFuZWwgdGhhdCBzdXBwb3J0IGJvdGggd2F5cyBvZiBiYWNrbGlnaHQNCj4g PiBhZGp1c3RtZW50IHRvIGRvIGl0IHZpYSBQV00gcGluLg0KPiA+IA0KPiA+IFRoaXMgcGF0Y2gg YWRkcyB0aGUgbmV3IHByZWZlciBEUENEIG1vZGUgaW4gdGhlIGk5MTVfcGFyYW0NCj4gPiB0byBt YWtlIGl0IGVuYWJsZSB0byBwcmVmZXIgRFBDRCBvdmVyIHRoZSBQV00gdmlhIGtlcm5lbCBwYXJh bS4NCj4gPiANCj4gPiBUaGlzIHBhdGNoIGFsc28gYWRkIGEgY2hlY2sgdG8gRFBfRURQX0JBQ0tM SUdIVF9BVVhfRU5BQkxFX0NBUA0KPiA+IGluIHNldF9hdXhfYmFja2xpZ2h0X2VuYWJsZSgpIHNp bmNlIHRoZSBiYWNrbGlnaHQgZW5hYmxlbWVudA0KPiA+IGNhbiBiZSBkb25lIHZpYSBCTF9FTkFC TEUgZURQIGNvbm5lY3RvciBwaW4gaW4gdGhlIGNhc2UgdGhhdA0KPiA+IGl0IGRvZXMgbm90IHN1 cHBvcnQgZG9pbmcgdGhhdCB2aWEgQVVYLg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IFB1dGhp a29ybiBWb3Jhdm9vdGl2YXQgPHB1dGhpa0BjaHJvbWl1bS5vcmc+DQo+ID4gLS0tDQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFyYW1zLmMgICAgICAgICAgICB8ICA2ICsrLS0tDQo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFyYW1zLmggICAgICAgICAgICB8ICAyICst DQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYyB8IDMz ICsrKysrKysrKysrKysrKysrKystLS0tLS0tLQ0KPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDI3IGlu c2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9wYXJhbXMuYw0KPiA+IGluZGV4IGI2YTdlMzYzZDA3Ni4uOTYwMzkzZGQ1ZWRmIDEwMDY0NA0K PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFyYW1zLmMNCj4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5jDQo+ID4gQEAgLTYzLDcgKzYzLDcgQEAg c3RydWN0IGk5MTVfcGFyYW1zIGk5MTUgX19yZWFkX21vc3RseSA9IHsNCj4gPiAgCS5odWNfZmly bXdhcmVfcGF0aCA9IE5VTEwsDQo+ID4gIAkuZW5hYmxlX2RwX21zdCA9IHRydWUsDQo+ID4gIAku aW5qZWN0X2xvYWRfZmFpbHVyZSA9IDAsDQo+ID4gLQkuZW5hYmxlX2RwY2RfYmFja2xpZ2h0ID0g ZmFsc2UsDQo+ID4gKwkuZW5hYmxlX2RwY2RfYmFja2xpZ2h0ID0gMCwNCj4gPiAgCS5lbmFibGVf Z3Z0ID0gZmFsc2UsDQo+ID4gIH07DQo+ID4gIA0KPiA+IEBAIC0yNDYsOSArMjQ2LDkgQEAgTU9E VUxFX1BBUk1fREVTQyhlbmFibGVfZHBfbXN0LA0KPiA+ICBtb2R1bGVfcGFyYW1fbmFtZWRfdW5z YWZlKGluamVjdF9sb2FkX2ZhaWx1cmUsIGk5MTUuaW5qZWN0X2xvYWRfZmFpbHVyZSwgdWludCwg MDQwMCk7DQo+ID4gIE1PRFVMRV9QQVJNX0RFU0MoaW5qZWN0X2xvYWRfZmFpbHVyZSwNCj4gPiAg CSJGb3JjZSBhbiBlcnJvciBhZnRlciBhIG51bWJlciBvZiBmYWlsdXJlIGNoZWNrIHBvaW50cyAo MDpkaXNhYmxlZCAoZGVmYXVsdCksIE46Zm9yY2UgZmFpbHVyZSBhdCB0aGUgTnRoIGZhaWx1cmUg Y2hlY2sgcG9pbnQpIik7DQo+ID4gLW1vZHVsZV9wYXJhbV9uYW1lZChlbmFibGVfZHBjZF9iYWNr bGlnaHQsIGk5MTUuZW5hYmxlX2RwY2RfYmFja2xpZ2h0LCBib29sLCAwNjAwKTsNCj4gPiArbW9k dWxlX3BhcmFtX25hbWVkKGVuYWJsZV9kcGNkX2JhY2tsaWdodCwgaTkxNS5lbmFibGVfZHBjZF9i YWNrbGlnaHQsIGludCwgMDYwMCk7DQo+ID4gIE1PRFVMRV9QQVJNX0RFU0MoZW5hYmxlX2RwY2Rf YmFja2xpZ2h0LA0KPiA+IC0JIkVuYWJsZSBzdXBwb3J0IGZvciBEUENEIGJhY2tsaWdodCBjb250 cm9sIChkZWZhdWx0OmZhbHNlKSIpOw0KPiA+ICsJIkVuYWJsZSBzdXBwb3J0IGZvciBEUENEIGJh Y2tsaWdodCBjb250cm9sICgwOmRpc2FibGUgKGRlZmF1bHQpLCAxOnByZWZlciBQV00gcGluLCAy OiBwcmVmZXIgRFBDRCkiKTsNCj4gDQo+IEkgbG9va2VkIGF0IG90aGVyIGludCBwYXJhbWV0ZXJz LCAtMT1kZWZhdWx0LCAwPWRpc2FibGUocHJlZmVyIFBXTSBpbg0KPiB5b3VyIGNhc2UpLCAxPWVu YWJsZShwcmVmZXIgRFBDRCkgc2VlbXMgbGlrZSB0aGUgbW9yZSBjb21tb24gd2F5IHRvIGRvDQo+ IHRoaXMuDQo+IA0KPiANCj4gPiAgDQo+ID4gIG1vZHVsZV9wYXJhbV9uYW1lZChlbmFibGVfZ3Z0 LCBpOTE1LmVuYWJsZV9ndnQsIGJvb2wsIDA0MDApOw0KPiA+ICBNT0RVTEVfUEFSTV9ERVNDKGVu YWJsZV9ndnQsDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFy YW1zLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5oDQo+ID4gaW5kZXggMzQx NDhjYzg2MzdjLi5iZjZlMmM2MGY2OTcgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9wYXJhbXMuaA0KPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cGFyYW1zLmgNCj4gPiBAQCAtNTEsNiArNTEsNyBAQA0KPiA+ICAJZnVuYyhpbnQsIHVzZV9tbWlv X2ZsaXApOyBcDQo+ID4gIAlmdW5jKGludCwgbW1pb19kZWJ1Zyk7IFwNCj4gPiAgCWZ1bmMoaW50 LCBlZHBfdnN3aW5nKTsgXA0KPiA+ICsJZnVuYyhpbnQsIGVuYWJsZV9kcGNkX2JhY2tsaWdodCk7 IFwNCj4gPiAgCWZ1bmModW5zaWduZWQgaW50LCBpbmplY3RfbG9hZF9mYWlsdXJlKTsgXA0KPiA+ ICAJLyogbGVhdmUgYm9vbHMgYXQgdGhlIGVuZCB0byBub3QgY3JlYXRlIGhvbGVzICovIFwNCj4g PiAgCWZ1bmMoYm9vbCwgYWxwaGFfc3VwcG9ydCk7IFwNCj4gPiBAQCAtNjYsNyArNjcsNiBAQA0K PiA+ICAJZnVuYyhib29sLCB2ZXJib3NlX3N0YXRlX2NoZWNrcyk7IFwNCj4gPiAgCWZ1bmMoYm9v bCwgbnVjbGVhcl9wYWdlZmxpcCk7IFwNCj4gPiAgCWZ1bmMoYm9vbCwgZW5hYmxlX2RwX21zdCk7 IFwNCj4gPiAtCWZ1bmMoYm9vbCwgZW5hYmxlX2RwY2RfYmFja2xpZ2h0KTsgXA0KPiA+ICAJZnVu Yyhib29sLCBlbmFibGVfZ3Z0KQ0KPiA+ICANCj4gPiAgI2RlZmluZSBNRU1CRVIoVCwgbWVtYmVy KSBUIG1lbWJlcg0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cF9hdXhfYmFja2xpZ2h0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9hdXhfYmFj a2xpZ2h0LmMNCj4gPiBpbmRleCA2NTMyZTIyNmRiMjkuLjQyZjczZDlhM2NjZiAxMDA2NDQNCj4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMNCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMNCj4g PiBAQCAtMjgsNiArMjgsMTAgQEAgc3RhdGljIHZvaWQgc2V0X2F1eF9iYWNrbGlnaHRfZW5hYmxl KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGJvb2wgZW5hYmxlKQ0KPiA+ICB7DQo+ID4gIAl1 aW50OF90IHJlZ192YWwgPSAwOw0KPiA+ICANCj4gPiArCS8qIEVhcmx5IHJldHVybiB3aGVuIGRp c3BsYXkgdXNlIG90aGVyIG1lY2hhbmlzbSB0byBlbmFibGUgYmFja2xpZ2h0LiAqLw0KPiA+ICsJ aWYgKCEoaW50ZWxfZHAtPmVkcF9kcGNkWzFdICYgRFBfRURQX0JBQ0tMSUdIVF9BVVhfRU5BQkxF X0NBUCkpDQo+ID4gKwkJcmV0dXJuOw0KPiA+ICsNCj4gPiAgCWlmIChkcm1fZHBfZHBjZF9yZWFk YigmaW50ZWxfZHAtPmF1eCwgRFBfRURQX0RJU1BMQVlfQ09OVFJPTF9SRUdJU1RFUiwNCj4gPiAg CQkJICAgICAgJnJlZ192YWwpIDwgMCkgew0KPiA+ICAJCURSTV9ERUJVR19LTVMoIkZhaWxlZCB0 byByZWFkIERQQ0QgcmVnaXN0ZXIgMHgleFxuIiwNCj4gPiBAQCAtMTM4LDI3ICsxNDIsMzYgQEAg c3RhdGljIGJvb2wNCj4gPiAgaW50ZWxfZHBfYXV4X2Rpc3BsYXlfY29udHJvbF9jYXBhYmxlKHN0 cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikNCj4gPiAgew0KPiA+ICAJc3RydWN0IGlu dGVsX2RwICppbnRlbF9kcCA9IGVuY190b19pbnRlbF9kcCgmY29ubmVjdG9yLT5lbmNvZGVyLT5i YXNlKTsNCj4gPiArCWJvb2wgc3VwcG9ydGVkOw0KPiA+ICANCj4gPiAgCS8qIENoZWNrIHRoZSAg ZURQIERpc3BsYXkgY29udHJvbCBjYXBhYmlsaXRpZXMgcmVnaXN0ZXJzIHRvIGRldGVybWluZSBp Zg0KPiA+ICAJICogdGhlIHBhbmVsIGNhbiBzdXBwb3J0IGJhY2tsaWdodCBjb250cm9sIG92ZXIg dGhlIGF1eCBjaGFubmVsDQo+ID4gIAkgKi8NCj4gPiAtCWlmIChpbnRlbF9kcC0+ZWRwX2RwY2Rb MV0gJiBEUF9FRFBfVENPTl9CQUNLTElHSFRfQURKVVNUTUVOVF9DQVAgJiYNCj4gPiAtCSAgICAo aW50ZWxfZHAtPmVkcF9kcGNkWzFdICYgRFBfRURQX0JBQ0tMSUdIVF9BVVhfRU5BQkxFX0NBUCkg JiYNCj4gPiAtCSAgICAhKChpbnRlbF9kcC0+ZWRwX2RwY2RbMV0gJiBEUF9FRFBfQkFDS0xJR0hU X1BJTl9FTkFCTEVfQ0FQKSB8fA0KPiA+IC0JICAgICAgKGludGVsX2RwLT5lZHBfZHBjZFsyXSAm IERQX0VEUF9CQUNLTElHSFRfQlJJR0hUTkVTU19QV01fUElOX0NBUCkpKSB7DQo+ID4gLQkJRFJN X0RFQlVHX0tNUygiQVVYIEJhY2tsaWdodCBDb250cm9sIFN1cHBvcnRlZCFcbiIpOw0KPiA+IC0J CXJldHVybiB0cnVlOw0KPiA+ICsJc3dpdGNoIChpOTE1LmVuYWJsZV9kcGNkX2JhY2tsaWdodCkg ew0KPiA+ICsJY2FzZSAxOiAvKiBwcmVmZXIgUFdNIHBpbiAqLw0KPiA+ICsJCXN1cHBvcnRlZCA9 IChpbnRlbF9kcC0+ZWRwX2RwY2RbMV0gJiBEUF9FRFBfVENPTl9CQUNLTElHSFRfQURKVVNUTUVO VF9DQVApICYmDQo+ID4gKwkJCSAgICAoaW50ZWxfZHAtPmVkcF9kcGNkWzFdICYgRFBfRURQX0JB Q0tMSUdIVF9BVVhfRU5BQkxFX0NBUCkgJiYNCj4gPiArCQkJICAgICEoaW50ZWxfZHAtPmVkcF9k cGNkWzFdICYgRFBfRURQX0JBQ0tMSUdIVF9QSU5fRU5BQkxFX0NBUCkgJiYNCj4gPiArCQkJICAg ICEoaW50ZWxfZHAtPmVkcF9kcGNkWzJdICYgRFBfRURQX0JBQ0tMSUdIVF9CUklHSFRORVNTX1BX TV9QSU5fQ0FQKTsNCj4gPiArCQlicmVhazsNCj4gPiArCWNhc2UgMjogLyogcHJlZmVyIERQQ0Qg Ki8NCj4gPiArCQlzdXBwb3J0ZWQgPSAoaW50ZWxfZHAtPmVkcF9kcGNkWzFdICYgRFBfRURQX1RD T05fQkFDS0xJR0hUX0FESlVTVE1FTlRfQ0FQKSAmJg0KPiA+ICsJCQkgICAgKGludGVsX2RwLT5l ZHBfZHBjZFsyXSAmIERQX0VEUF9CQUNLTElHSFRfQlJJR0hUTkVTU19BVVhfU0VUX0NBUCk7DQo+ ID4gKwkJYnJlYWs7DQo+ID4gKwlkZWZhdWx0Og0KPiA+ICsJCXN1cHBvcnRlZCA9IGZhbHNlOw0K PiA+ICAJfQ0KPiA+IC0JcmV0dXJuIGZhbHNlOw0KPiA+ICsNCj4gPiArCWlmIChzdXBwb3J0ZWQp DQo+ID4gKwkJRFJNX0RFQlVHX0tNUygiQVVYIEJhY2tsaWdodCBDb250cm9sIFN1cHBvcnRlZCFc biIpOw0KPiA+ICsNCj4gPiArCXJldHVybiBzdXBwb3J0ZWQ7DQo+IA0KPiANCj4gSWYgaTkxNS5l bmFibGVfZHBjZF9iYWNrbGlnaHQgPSAwLCBhcmVuJ3QgeW91IHJldHVybmluZyBhbiB1bmluaXRp YWxpemVkDQo+IHZhcmlhYmxlIGhlcmU/DQo+IA0KPiAtREsNCj4gDQoNCklnbm9yZSB0aGF0LCB0 aW1lIGZvciBjb2ZmZWUuIA0KDQogDQo+IA0KPiA+ICB9DQo+ID4gIA0KPiA+ICBpbnQgaW50ZWxf ZHBfYXV4X2luaXRfYmFja2xpZ2h0X2Z1bmNzKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmludGVs X2Nvbm5lY3RvcikNCj4gPiAgew0KPiA+ICAJc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9ICZp bnRlbF9jb25uZWN0b3ItPnBhbmVsOw0KPiA+ICANCj4gPiAtCWlmICghaTkxNS5lbmFibGVfZHBj ZF9iYWNrbGlnaHQpDQo+ID4gLQkJcmV0dXJuIC1FTk9ERVY7DQo+ID4gLQ0KPiA+ICAJaWYgKCFp bnRlbF9kcF9hdXhfZGlzcGxheV9jb250cm9sX2NhcGFibGUoaW50ZWxfY29ubmVjdG9yKSkNCj4g PiAgCQlyZXR1cm4gLUVOT0RFVjsNCj4gPiAgDQo+IA0KPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXw0KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0DQo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngNCg0KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==