Return-Path: Message-ID: <1494478535.2028.9.camel@perches.com> Subject: Re: [PATCH] FS: Fixing return type of unsigned_offsets From: Joe Perches To: Pushkar Jambhlekar Cc: Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel Date: Wed, 10 May 2017 21:55:35 -0700 In-Reply-To: References: <1494476871-26474-1-git-send-email-pushkar.iit@gmail.com> <1494477592.2028.7.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On Thu, 2017-05-11 at 10:13 +0530, Pushkar Jambhlekar wrote: > Should I change my implementation, i.e. remove '!!'? That'd be up to Al. At least one implementation using similar bit comparisons in fs/*.c does not use !! fs/locks.c:static bool lease_breaking(struct file_lock *fl) fs/locks.c-{ fs/locks.c-�����return fl->fl_flags & (FL_UNLOCK_PENDING | FL_DOWNGRADE_PENDING) fs/locks.c-} I didn't look very hard.