From: Alex Xie Subject: [PATCH 3/3] drm/amdgpu: optimize out a spin lock Use atomic instead of spin lock. Date: Wed, 21 Jun 2017 22:42:36 -0400 Message-ID: <1498099356-31332-3-git-send-email-AlexBin.Xie@amd.com> References: <1498099356-31332-1-git-send-email-AlexBin.Xie@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1498099356-31332-1-git-send-email-AlexBin.Xie-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alex Xie U2lnbmVkLW9mZi1ieTogQWxleCBYaWUgPEFsZXhCaW4uWGllQGFtZC5jb20+Ci0tLQogZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmggICAgICAgIHwgICA1ICstCiBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3MuYyAgICAgfCAxMTAgKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyB8 ICAgMSAtCiAzIGZpbGVzIGNoYW5nZWQsIDc2IGluc2VydGlvbnMoKyksIDQwIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKaW5kZXggN2NhZjUxNC4uMjFkMzE4YiAx MDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKKysrIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKQEAgLTE1ODgsOSArMTU4OCw4IEBAIHN0 cnVjdCBhbWRncHVfZGV2aWNlIHsKIAogCS8qIGRhdGEgZm9yIGJ1ZmZlciBtaWdyYXRpb24gdGhy b3R0bGluZyAqLwogCXN0cnVjdCB7Ci0JCXNwaW5sb2NrX3QJCWxvY2s7Ci0JCXM2NAkJCWxhc3Rf dXBkYXRlX3VzOwotCQlzNjQJCQlhY2N1bV91czsgLyogYWNjdW11bGF0ZWQgbWljcm9zZWNvbmRz ICovCisJCWF0b21pYzY0X3QJCWxhc3RfdXBkYXRlX3VzOworCQlhdG9taWM2NF90CQlhY2N1bV91 czsgLyogYWNjdW11bGF0ZWQgbWljcm9zZWNvbmRzICovCiAJCXUzMgkJCWxvZzJfbWF4X01CcHM7 CiAJfSBtbV9zdGF0czsKIApkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3MuYwppbmRl eCA4MjEzMWQ3Li43YjZmNDJlIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfY3MuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3Mu YwpAQCAtMjI1LDYgKzIyNSw5IEBAIHN0YXRpYyB1NjQgYW1kZ3B1X2NzX2dldF90aHJlc2hvbGRf Zm9yX21vdmVzKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQogCXM2NCB0aW1lX3VzLCBpbmNy ZW1lbnRfdXM7CiAJdTY0IG1heF9ieXRlczsKIAl1NjQgZnJlZV92cmFtLCB0b3RhbF92cmFtLCB1 c2VkX3ZyYW07CisJczY0IG9sZF91cGRhdGVfdXMsIGhlYWRfdGltZV91czsKKwlzNjQgYWNjdW1f dXM7CisJczY0IG9sZF9hY2N1bV91cywgaGVhZF9hY2N1bV91czsKIAogCS8qIEFsbG93IGEgbWF4 aW11bSBvZiAyMDAgYWNjdW11bGF0ZWQgbXMuIFRoaXMgaXMgYmFzaWNhbGx5IHBlci1JQgogCSAq IHRocm90dGxpbmcuCkBAIC0yNDIsNDcgKzI0NSw4MyBAQCBzdGF0aWMgdTY0IGFtZGdwdV9jc19n ZXRfdGhyZXNob2xkX2Zvcl9tb3ZlcyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKIAl1c2Vk X3ZyYW0gPSBhdG9taWM2NF9yZWFkKCZhZGV2LT52cmFtX3VzYWdlKTsKIAlmcmVlX3ZyYW0gPSB1 c2VkX3ZyYW0gPj0gdG90YWxfdnJhbSA/IDAgOiB0b3RhbF92cmFtIC0gdXNlZF92cmFtOwogCi0J c3Bpbl9sb2NrKCZhZGV2LT5tbV9zdGF0cy5sb2NrKTsKLQogCS8qIEluY3JlYXNlIHRoZSBhbW91 bnQgb2YgYWNjdW11bGF0ZWQgdXMuICovCi0JdGltZV91cyA9IGt0aW1lX3RvX3VzKGt0aW1lX2dl dCgpKTsKLQlpbmNyZW1lbnRfdXMgPSB0aW1lX3VzIC0gYWRldi0+bW1fc3RhdHMubGFzdF91cGRh dGVfdXM7Ci0JYWRldi0+bW1fc3RhdHMubGFzdF91cGRhdGVfdXMgPSB0aW1lX3VzOwotCWFkZXYt Pm1tX3N0YXRzLmFjY3VtX3VzID0gbWluKGFkZXYtPm1tX3N0YXRzLmFjY3VtX3VzICsgaW5jcmVt ZW50X3VzLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1c191cHBlcl9i b3VuZCk7Ci0KLQkvKiBUaGlzIHByZXZlbnRzIHRoZSBzaG9ydCBwZXJpb2Qgb2YgbG93IHBlcmZv cm1hbmNlIHdoZW4gdGhlIFZSQU0KLQkgKiB1c2FnZSBpcyBsb3cgYW5kIHRoZSBkcml2ZXIgaXMg aW4gZGVidCBvciBkb2Vzbid0IGhhdmUgZW5vdWdoCi0JICogYWNjdW11bGF0ZWQgdXMgdG8gZmls bCBWUkFNIHF1aWNrbHkuCi0JICoKLQkgKiBUaGUgc2l0dWF0aW9uIGNhbiBvY2N1ciBpbiB0aGVz ZSBjYXNlczoKLQkgKiAtIGEgbG90IG9mIFZSQU0gaXMgZnJlZWQgYnkgdXNlcnNwYWNlCi0JICog LSB0aGUgcHJlc2VuY2Ugb2YgYSBiaWcgYnVmZmVyIGNhdXNlcyBhIGxvdCBvZiBldmljdGlvbnMK LQkgKiAgIChzb2x1dGlvbjogc3BsaXQgYnVmZmVycyBpbnRvIHNtYWxsZXIgb25lcykKLQkgKgot CSAqIElmIDEyOCBNQiBvciAxLzh0aCBvZiBWUkFNIGlzIGZyZWUsIHN0YXJ0IGZpbGxpbmcgaXQg bm93IGJ5IHNldHRpbmcKLQkgKiBhY2N1bV91cyB0byBhIHBvc2l0aXZlIG51bWJlci4KLQkgKi8K LQlpZiAoZnJlZV92cmFtID49IDEyOCAqIDEwMjQgKiAxMDI0IHx8IGZyZWVfdnJhbSA+PSB0b3Rh bF92cmFtIC8gOCkgewotCQlzNjQgbWluX3VzOwotCi0JCS8qIEJlIG1vcmUgYWdncmVzaXZlIG9u IGRHUFVzLiBUcnkgdG8gZmlsbCBhIHBvcnRpb24gb2YgZnJlZQotCQkgKiBWUkFNIG5vdy4KLQkJ ICovCi0JCWlmICghKGFkZXYtPmZsYWdzICYgQU1EX0lTX0FQVSkpCi0JCQltaW5fdXMgPSBieXRl c190b191cyhhZGV2LCBmcmVlX3ZyYW0gLyA0KTsKKwlvbGRfdXBkYXRlX3VzID0gYXRvbWljNjRf cmVhZCgmYWRldi0+bW1fc3RhdHMubGFzdF91cGRhdGVfdXMpOworCWZvciAoOzspIHsKKwkJdGlt ZV91cyA9IGt0aW1lX3RvX3VzKGt0aW1lX2dldCgpKTsKKwkJaGVhZF90aW1lX3VzID0gYXRvbWlj NjRfY21weGNoZygmYWRldi0+bW1fc3RhdHMubGFzdF91cGRhdGVfdXMsCisJCQkJCQlvbGRfdXBk YXRlX3VzLCB0aW1lX3VzKTsKKworCQlpZiAobGlrZWx5KGhlYWRfdGltZV91cyA9PSBvbGRfdXBk YXRlX3VzKSkKKwkJCS8qCisJCQkgKiBObyBvdGhlciB0YXNrIG1vZGlmaWVkIGFkZXYtPm1tX3N0 YXRzLmxhc3RfdXBkYXRlX3VzLgorCQkJICogVXBkYXRlIHdhcyBzdWNjZXNzZnVsLgorCQkJICov CisJCQlicmVhazsKIAkJZWxzZQotCQkJbWluX3VzID0gMDsgLyogUmVzZXQgYWNjdW1fdXMgb24g QVBVcy4gKi8KKwkJCS8qIEFub3RoZXIgdGFzayBtb2RpZmllZCB0aGUgdmFsdWUgYWZ0ZXIgd2Ug cmVhZCBpdC4KKwkJCSAqIEEgcmFyZSBjb250ZW50aW9uIGhhcHBlbnMsIGxldCB1cyByZXRyeS4K KwkJCSAqIEluIG1vc3QgY2FzZSwgb25lIHJldHJ5IGNhbiBkbyB0aGUgam9iLgorCQkJICogU2Vl IGZ1bmN0aW9uIGF0b21pYzY0X2FkZF91bmxlc3MgYXMgYSBzaW1pbGFyIGlkZWEuCisJCQkgKi8K KwkJCW9sZF91cGRhdGVfdXMgPSBoZWFkX3RpbWVfdXM7CisJfQorCWluY3JlbWVudF91cyA9IHRp bWVfdXMgLSBvbGRfdXBkYXRlX3VzOworCisJb2xkX2FjY3VtX3VzID0gYXRvbWljNjRfcmVhZCgm YWRldi0+bW1fc3RhdHMuYWNjdW1fdXMpOworCisJZm9yICg7OykgeworCQlhY2N1bV91cyA9IG1p bihvbGRfYWNjdW1fdXMgKyBpbmNyZW1lbnRfdXMsIHVzX3VwcGVyX2JvdW5kKTsKKworCQkvKiBU aGlzIHByZXZlbnRzIHRoZSBzaG9ydCBwZXJpb2Qgb2YgbG93IHBlcmZvcm1hbmNlIHdoZW4gdGhl CisJCSAqIFZSQU0gdXNhZ2UgaXMgbG93IGFuZCB0aGUgZHJpdmVyIGlzIGluIGRlYnQgb3IgZG9l c24ndCBoYXZlCisJCSAqIGVub3VnaCBhY2N1bXVsYXRlZCB1cyB0byBmaWxsIFZSQU0gcXVpY2ts eS4KKwkJICoKKwkJICogVGhlIHNpdHVhdGlvbiBjYW4gb2NjdXIgaW4gdGhlc2UgY2FzZXM6CisJ CSAqIC0gYSBsb3Qgb2YgVlJBTSBpcyBmcmVlZCBieSB1c2Vyc3BhY2UKKwkJICogLSB0aGUgcHJl c2VuY2Ugb2YgYSBiaWcgYnVmZmVyIGNhdXNlcyBhIGxvdCBvZiBldmljdGlvbnMKKwkJICogICAo c29sdXRpb246IHNwbGl0IGJ1ZmZlcnMgaW50byBzbWFsbGVyIG9uZXMpCisJCSAqCisJCSAqIElm IDEyOCBNQiBvciAxLzh0aCBvZiBWUkFNIGlzIGZyZWUsIHN0YXJ0IGZpbGxpbmcgaXQgbm93IGJ5 CisJCSAqIHNldHRpbmcgYWNjdW1fdXMgdG8gYSBwb3NpdGl2ZSBudW1iZXIuCisJCSAqLworCQlp ZiAoZnJlZV92cmFtID49IDEyOCAqIDEwMjQgKiAxMDI0IHx8CisJCQlmcmVlX3ZyYW0gPj0gdG90 YWxfdnJhbSAvIDgpIHsKKwkJCXM2NCBtaW5fdXM7CisKKwkJCS8qIEJlIG1vcmUgYWdncmVzaXZl IG9uIGRHUFVzLiBUcnkgdG8gZmlsbCBhIHBvcnRpb24gb2YKKwkJCSAqIGZyZWUgVlJBTSBub3cu CisJCQkgKi8KKwkJCWlmICghKGFkZXYtPmZsYWdzICYgQU1EX0lTX0FQVSkpCisJCQkJbWluX3Vz ID0gYnl0ZXNfdG9fdXMoYWRldiwgZnJlZV92cmFtIC8gNCk7CisJCQllbHNlCisJCQkJbWluX3Vz ID0gMDsgLyogUmVzZXQgYWNjdW1fdXMgb24gQVBVcy4gKi8KKworCQkJYWNjdW1fdXMgPSBtYXgo bWluX3VzLCBhY2N1bV91cyk7CisJCX0KKworCQloZWFkX2FjY3VtX3VzID0gYXRvbWljNjRfY21w eGNoZygmYWRldi0+bW1fc3RhdHMuYWNjdW1fdXMsCisJCQkJCQkJb2xkX2FjY3VtX3VzLCBhY2N1 bV91cyk7CiAKLQkJYWRldi0+bW1fc3RhdHMuYWNjdW1fdXMgPSBtYXgobWluX3VzLCBhZGV2LT5t bV9zdGF0cy5hY2N1bV91cyk7CisJCWlmIChsaWtlbHkoaGVhZF9hY2N1bV91cyA9PSBvbGRfYWNj dW1fdXMpKQorCQkJLyoKKwkJCSAqIE5vIG90aGVyIHRhc2sgbW9kaWZpZWQgYWRldi0+bW1fc3Rh dHMuYWNjdW1fdXMuCisJCQkgKiBVcGRhdGUgd2FzIHN1Y2Nlc3NmdWwuCisJCQkgKi8KKwkJCWJy ZWFrOworCQllbHNlCisJCQkvKiBBbm90aGVyIHRhc2sgbW9kaWZpZWQgdGhlIHZhbHVlIGFmdGVy IHdlIHJlYWQgaXQuCisJCQkgKiBBIHJhcmUgY29udGVudGlvbiBoYXBwZW5zLCBsZXQgdXMgcmV0 cnkuCisJCQkgKiBJbiBtb3N0IGNhc2UsIG9uZSByZXRyeSBjYW4gZG8gdGhlIGpvYi4KKwkJCSAq IFNlZSBmdW5jdGlvbiBhdG9taWM2NF9hZGRfdW5sZXNzIGFzIGEgc2ltaWxhciBpZGVhLgorCQkJ ICovCisJCQlvbGRfYWNjdW1fdXMgPSBoZWFkX2FjY3VtX3VzOwogCX0KIAogCS8qIFRoaXMgcmV0 dXJucyAwIGlmIHRoZSBkcml2ZXIgaXMgaW4gZGVidCB0byBkaXNhbGxvdyAob3B0aW9uYWwpCiAJ ICogYnVmZmVyIG1vdmVzLgogCSAqLwotCW1heF9ieXRlcyA9IHVzX3RvX2J5dGVzKGFkZXYsIGFk ZXYtPm1tX3N0YXRzLmFjY3VtX3VzKTsKLQotCXNwaW5fdW5sb2NrKCZhZGV2LT5tbV9zdGF0cy5s b2NrKTsKKwltYXhfYnl0ZXMgPSB1c190b19ieXRlcyhhZGV2LCBhY2N1bV91cyk7CiAJcmV0dXJu IG1heF9ieXRlczsKIH0KIApAQCAtMjkyLDkgKzMzMSw4IEBAIHN0YXRpYyB1NjQgYW1kZ3B1X2Nz X2dldF90aHJlc2hvbGRfZm9yX21vdmVzKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQogICov CiB2b2lkIGFtZGdwdV9jc19yZXBvcnRfbW92ZWRfYnl0ZXMoc3RydWN0IGFtZGdwdV9kZXZpY2Ug KmFkZXYsIHU2NCBudW1fYnl0ZXMpCiB7Ci0Jc3Bpbl9sb2NrKCZhZGV2LT5tbV9zdGF0cy5sb2Nr KTsKLQlhZGV2LT5tbV9zdGF0cy5hY2N1bV91cyAtPSBieXRlc190b191cyhhZGV2LCBudW1fYnl0 ZXMpOwotCXNwaW5fdW5sb2NrKCZhZGV2LT5tbV9zdGF0cy5sb2NrKTsKKwlzNjQgaSA9IGJ5dGVz X3RvX3VzKGFkZXYsIG51bV9ieXRlcyk7CisJYXRvbWljNjRfc3ViKGksICZhZGV2LT5tbV9zdGF0 cy5hY2N1bV91cyk7CiB9CiAKIHN0YXRpYyBpbnQgYW1kZ3B1X2NzX2JvX3ZhbGlkYXRlKHN0cnVj dCBhbWRncHVfY3NfcGFyc2VyICpwLApkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2RldmljZS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2RldmljZS5jCmluZGV4IGZmOTBmNzguLjllOWQ1OTIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfZGV2aWNlLmMKQEAgLTIxMTcsNyArMjExNyw2IEBAIGludCBhbWRncHVf ZGV2aWNlX2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCiAJc3Bpbl9sb2NrX2luaXQo JmFkZXYtPmRpZHRfaWR4X2xvY2spOwogCXNwaW5fbG9ja19pbml0KCZhZGV2LT5nY19jYWNfaWR4 X2xvY2spOwogCXNwaW5fbG9ja19pbml0KCZhZGV2LT5hdWRpb19lbmRwdF9pZHhfbG9jayk7Ci0J c3Bpbl9sb2NrX2luaXQoJmFkZXYtPm1tX3N0YXRzLmxvY2spOwogCiAJSU5JVF9MSVNUX0hFQUQo JmFkZXYtPnNoYWRvd19saXN0KTsKIAltdXRleF9pbml0KCZhZGV2LT5zaGFkb3dfbGlzdF9sb2Nr KTsKLS0gCjIuNy40CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK