Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D247C742A2 for ; Thu, 11 Jul 2019 19:08:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 193CA208E4 for ; Thu, 11 Jul 2019 19:08:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IDMMR2Ui" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 193CA208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hleQV-0003ZG-1g for qemu-devel@archiver.kernel.org; Thu, 11 Jul 2019 15:08:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37059) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hleQL-0003A3-EW for qemu-devel@nongnu.org; Thu, 11 Jul 2019 15:08:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hleQJ-0004Km-9C for qemu-devel@nongnu.org; Thu, 11 Jul 2019 15:08:09 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:45046) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hleQH-0004Ed-S1 for qemu-devel@nongnu.org; Thu, 11 Jul 2019 15:08:06 -0400 Received: by mail-wr1-x441.google.com with SMTP id p17so7418125wrf.11 for ; Thu, 11 Jul 2019 12:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cIgv8NonJJLD60VFU0VJmfMgsAeSqJsqXOeW3Ay30pY=; b=IDMMR2UiNKRwI2bnGJHhrJ+79jPyZnhCv5LmWRaHo+Qju2NEGbkGQnM98GErqJ8t06 ozFQDcl2C7aHe7DN6n2RzizDRhvEsoIDwBK8Cz+Ar2RMTx8oHUHDpP1ZUTzgbX4mJKwH G5Z2xzKMxaory5WW6dhAyuKjrdTMLgk9E3XVVA51TKpDRoKFMbvz4Sp/SArbMX+HJ4I/ fdPubN/Z0jIoTbo3htR7/aFslnqeiUoO/FsfCw8Eq9cMaovxqcDIlnH0wtgGcyRQxvmn R0DQrSUnY96vORRqVO0q1CYBqMxSGpbFPLFKXh9ykzmDVpMJDYVasUtilarEycsEKMf/ VvYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cIgv8NonJJLD60VFU0VJmfMgsAeSqJsqXOeW3Ay30pY=; b=btkcig/J1ohYqISSrj1IB8ezKe4QlCBXHBVRhCvJ7tXA7U0RGdBVKJmO0X1FBUBabq 4l1fOtja9NNEGwV5HRN39FnFJBdDx8Fx1BlRc6xmAmWrfHY73YiMwiXbxMRvvjEGqcX1 SJwQ5tSSXgsd9IMkxwclRgGN+lkgkrldDxnUae9ARYbXnbulmABvoHPMproGsKa0gusi luE2Lp+N9w0FdqfAf1hPpCo+1Je70SyFIN54dOTERDZL2g/WG8VIEGxni0UTVCHMVLqK LUFbvrmXYtMi2JDhCKBp9cC+oPSNY7N1wiK6dKbsKEoa5JF2C9m4UBP0Tl/z81gt1o6b fVpA== X-Gm-Message-State: APjAAAXv3rVU2VHPuF00FEv72c5cBLbEVSKATty3e3vQULfgDQt5iDLC jFG/s+vsY9Y6Y/+2L6skbJ5h5/No X-Google-Smtp-Source: APXvYqxvULe/BNUPYUadmJewMp5Vrexcub1xyMcILsZAyCIxoBDNHLPiOu9YzM4o/n2lhsJmen/nJQ== X-Received: by 2002:adf:fdcc:: with SMTP id i12mr6844413wrs.88.1562872079084; Thu, 11 Jul 2019 12:07:59 -0700 (PDT) Received: from ?IPv6:fd00:835b:d940:d4fc:1::ca? (2a01-036c-0113-6e3f-0001-0000-0000-00ca.pool6.digikabel.hu. [2a01:36c:113:6e3f:1::ca]) by smtp.gmail.com with ESMTPSA id 32sm3833360wrh.76.2019.07.11.12.07.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jul 2019 12:07:58 -0700 (PDT) From: "=?UTF-8?B?Wm9sdMOhbiBLxZF2w6Fnw7M=?=" X-Google-Original-From: =?UTF-8?B?Wm9sdMOhbiBLxZF2w6Fnw7M=?= To: Markus Armbruster References: <597ee579c3d14ff6f0892ee9e1905cdb0e0990ad.1562695780.git.DirtY.iCE.hu@gmail.com> <87ef2yy1n4.fsf@dusky.pond.sub.org> <87bly0iqm6.fsf@dusky.pond.sub.org> Message-ID: <14cfeb63-0c6a-baa0-a840-054e686e170d@gmail.com> Date: Thu, 11 Jul 2019 21:07:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87bly0iqm6.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: Re: [Qemu-devel] [PATCH 02/11] audio: basic support for multi backend audio X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2019-07-11 16:37, Markus Armbruster wrote: > "Zoltán Kővágó" writes: > >> On 2019-07-10 06:06, Markus Armbruster wrote: >>> "Kővágó, Zoltán" writes: >>> >>>> Audio functions no longer access glob_audio_state, instead they get an >>>> AudioState as a parameter. This is required in order to support >>>> multiple backends. >>>> >>>> glob_audio_state is also gone, and replaced with a tailq so we can store >>>> more than one states. >>>> >>>> Signed-off-by: Kővágó, Zoltán >>>> --- >>> [...] >>>> diff --git a/hmp-commands.hx b/hmp-commands.hx >>>> index bfa5681dd2..23196da3fe 100644 >>>> --- a/hmp-commands.hx >>>> +++ b/hmp-commands.hx >>>> @@ -819,16 +819,17 @@ ETEXI >>>> >>>> { >>>> .name = "wavcapture", >>>> - .args_type = "path:F,freq:i?,bits:i?,nchannels:i?", >>>> - .params = "path [frequency [bits [channels]]]", >>>> + .args_type = "path:F,freq:i?,bits:i?,nchannels:i?,audiodev:s?", >>>> + .params = "path [frequency [bits [channels [audiodev]]]]", >>>> .help = "capture audio to a wave file (default frequency=44100 bits=16 channels=2)", >>>> .cmd = hmp_wavcapture, >>>> }, >>>> STEXI >>>> -@item wavcapture @var{filename} [@var{frequency} [@var{bits} [@var{channels}]]] >>>> +@item wavcapture @var{filename} [@var{frequency} [@var{bits} [@var{channels} [@var{audiodev}]]]] >>>> @findex wavcapture >>>> -Capture audio into @var{filename}. Using sample rate @var{frequency} >>>> -bits per sample @var{bits} and number of channels @var{channels}. >>>> +Capture audio into @var{filename} from @var{audiodev}. Using sample rate >>>> +@var{frequency} bits per sample @var{bits} and number of channels >>>> +@var{channels}. >>>> >>>> Defaults: >>>> @itemize @minus >>> @item Sample rate = 44100 Hz - CD quality >>> @item Bits = 16 >>> @item Number of channels = 2 - Stereo >>> @end itemize >>> ETEXI >>> >>> Defaults for the other optional arguments are listed here. Why not for >>> @audiodev? >> >> There's no default listed because there's no default when you use the >> -audiodev options, since there's no good default. When you don't use >> -audiodev, it'll use the implicitly created audiodev which doesn't have >> a name, so it can't be specified. > > Double-checking to avoid misunderstandings: there is a default > *behavior*, but no default *value*, i.e. there is no VALUE that makes > audiodev=VALUE give you the same behavior as no audiodev. Correct? Yes. If there is no audiodev=VALUE, and no -audiodev on the command line, use the legacy config. If there is audiodev=VALUE and -audiodev id=VALUE, use that device. Otherwise, it's an error. > >> But I agree that this situation >> should be documented somehow. > > Yes, please. > >>>> diff --git a/qemu-options.hx b/qemu-options.hx >>>> index 9621e934c0..0111055aa4 100644 >>>> --- a/qemu-options.hx >>>> +++ b/qemu-options.hx >>>> @@ -1978,6 +1978,11 @@ can help the device and guest to keep up and not lose events in case >>>> events are arriving in bulk. Possible causes for the latter are flaky >>>> network connections, or scripts for automated testing. >>>> >>>> +@item audiodev=@var{audiodev} >>>> + >>>> +Use the specified @var{audiodev} when the VNC client requests audio >>>> +transmission. >>>> + >>> >>> What's the default? >> >> It's the same story as wav_capture. >> >> Regards, >> Zoltan