Message-ID: <1500342546.500.3.camel@aj.id.au>
Subject: Re: [PATCH linux dev-4.10 1/2] ARM: dts: aspeed: Add
 gpio-keys-polled for fan presence
From: Andrew Jeffery <andrew@aj.id.au>
To: Christopher Bostic <cbostic@linux.vnet.ibm.com>, joel@jms.id.au
Cc: openbmc@lists.ozlabs.org
Date: Tue, 18 Jul 2017 11:19:06 +0930
In-Reply-To: <20170717212732.8629-2-cbostic@linux.vnet.ibm.com>
References: <20170717212732.8629-1-cbostic@linux.vnet.ibm.com>
 <20170717212732.8629-2-cbostic@linux.vnet.ibm.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-Y3CyKn2QoNBSlqGWxekX"
Mime-Version: 1.0
Precedence: list


--=-Y3CyKn2QoNBSlqGWxekX
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2017-07-17 at 16:27 -0500, Christopher Bostic wrote:
> Define gpio-keys-polled.=C2=A0=C2=A0Add pca-955x chip IO as GPIO source.
>=20
> > Signed-off-by: Christopher Bostic <cbostic@linux.vnet.ibm.com>
> ---
> =C2=A0arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 34 +++++++++++++=
+++++++++++
> =C2=A01 file changed, 34 insertions(+)
>=20
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/=
boot/dts/aspeed-bmc-opp-witherspoon.dts
> index 34c5dfc..d60a1db 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -62,6 +62,38 @@
> > =C2=A0		};
> > =C2=A0	};
> =C2=A0
> > +	gpio-keys-polled {
> > +		compatible =3D "gpio-keys-polled";
> > +		#address-cells =3D <1>;
> > +		#size-cells =3D <0>;
> > +		#poll-interval =3D <100>;
> > +		autorepeat;
> +
> > +		fan0-presence {
> > +			label =3D "fan0-presence";
> > +			gpios =3D <&pca0 4 GPIO_ACTIVE_LOW>;
> +			linux,code =3D <232>;

I think I replied about your choice of codes in the previous series.
The thought that I eventually came to (after replying IIRC) was what
has sort-of happened naturally here by way of the PCA card being unable
to provide interrupts, forcing you to define a separate node using
gpio-keys-polled.

Anyway, the thought was to have one gpio-keys{,-polled} node per
gpiochip device. That gives us the namespacing that the gpiochip
phandle provides - i.e. all keys in a node must use the same gpiochip
phandle. This isolates the keys behind separate input devices, and thus
their codes don't need to be globally unique.

So in this case I'm suggesting:

    fan0-presence {
        label =3D "fan0-presence";
        gpios =3D <&pca0 4 GPIO_ACTIVE_LOW>;
        linux,code =3D <4>;
    }

And likewise for the nodes below.

Cheers,

Andrew

> +		};
> +
> > +		fan1-presence {
> > +			label =3D "fan1-presence";
> > +			gpios =3D <&pca0 5 GPIO_ACTIVE_LOW>;
> > +			linux,code =3D <233>;
> > +		};
> +
> > +		fan2-presence {
> > +			label =3D "fan2-presence";
> > +			gpios =3D <&pca0 6 GPIO_ACTIVE_LOW>;
> > +			linux,code =3D <234>;
> > +		};
> +
> > +		fan3-presence {
> > +			label =3D "fan3-presence";
> > +			gpios =3D <&pca0 7 GPIO_ACTIVE_LOW>;
> > +			linux,code =3D <235>;
> > +		};
> > +	};
> +
> > =C2=A0	leds {
> > =C2=A0		compatible =3D "gpio-leds";
> =C2=A0
> @@ -224,6 +256,8 @@
> > =C2=A0		reg =3D <0x60>;
> > =C2=A0		#address-cells =3D <1>;
> > =C2=A0		#size-cells =3D <0>;
> > +		gpio-controller;
> > +		#gpio-cells =3D <2>;
> =C2=A0
> > > =C2=A0		fan0: led@0 {
> > =C2=A0			label =3D "fan0";
--=-Y3CyKn2QoNBSlqGWxekX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIcBAABCgAGBQJZbWkSAAoJEJ0dnzgO5LT5pVoP/0BIFhx6ahunGzAPz/MNg7fF
QsTc6AeOexs1SL2fowvl9FdZ84Pm4UZM4aUQR19+CINAscdTD1r9XUUBasBokbnH
3GAPtPEwRacDUJ2d5KX97yjTEE0EOBAVz89iNRgVfSIbvYgx5BjdMHJhx+K6li4F
8XYvWF2nRcNPZKZSpjK8KeJ6Ygp0/TIdTzmXhs73ZIn3aNsx05MO+YHbYBfmzaqE
jnoBf0U4PGL2PKSt0zCRSF+Ys1KViFaEGJORnmjyHv6f7vl4lGdpSl/F91klmvJn
4rHqL1rBlP3UVarfOaMZ9EYP7zHUGoytlIv8+/CgcA3GnuXWCi3cyUXsPqc6XJrN
Hq4mmpKL1KRizakF0o6Nb/LqQXxNKr+0RA6iuXBtpfROE3R/0Zesb4vI3pbGBl7E
nnHu6Uutq+NLizg/8fDJ5zYy0PlJqMAF0Bj7KwLPY8bc+M87Er8XyufdPo8TDm/p
Z+G7WG8iov6D6HtdRcm8zTJhJNy4K/iPCdRkkp4300JMj6Lwz0LEGQQTaKyEEw9t
/L6ipEEZVaCUIw+7Kmwztx/Dep+w5tjOfQ89PLUcOp6ebQQrS3zvaXzaIQu3Eyux
/BXUiHPZvrn1wymnMEl3cqsz91TqcsaX9FbVO2aGwWzVqI05fU56ZJVE1sQ8E2uS
pizjslqY2OFyT2sHa00a
=LxPX
-----END PGP SIGNATURE-----

--=-Y3CyKn2QoNBSlqGWxekX--