Message-ID: <1503473004.7266.37.camel@aj.id.au>
Subject: Re: [PATCH linux dev-4.10] drivers: occ: Fix bad list access
From: Andrew Jeffery <andrew@aj.id.au>
To: Eddie James <eajames@linux.vnet.ibm.com>, openbmc@lists.ozlabs.org
Cc: "Edward A. James" <eajames@us.ibm.com>
Date: Wed, 23 Aug 2017 16:53:24 +0930
In-Reply-To: <1503439230-14034-1-git-send-email-eajames@linux.vnet.ibm.com>
References: <1503439230-14034-1-git-send-email-eajames@linux.vnet.ibm.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-6vx0QKGjjpar523BmQuA"
Mime-Version: 1.0
Precedence: list


--=-6vx0QKGjjpar523BmQuA
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2017-08-22 at 17:00 -0500, Eddie James wrote:
> > From: "Edward A. James" <eajames@us.ibm.com>
>=20
> list_first_entry() doesn't return NULL if the list is empty...
>=20
> Signed-off-by: Edward A. James <eajames@us.ibm.com>

Thanks, applied to dev-4.10.

Andrew

> ---
> =C2=A0drivers/fsi/occ.c | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/fsi/occ.c b/drivers/fsi/occ.c
> index d984e51..621fbf0 100644
> --- a/drivers/fsi/occ.c
> +++ b/drivers/fsi/occ.c
> @@ -572,7 +572,7 @@ static void occ_worker(struct work_struct *work)
> =C2=A0again:
> > =C2=A0	spin_lock_irq(&occ->list_lock);
> =C2=A0
> > -	xfr =3D list_first_entry(&occ->xfrs, struct occ_xfr, link);
> > +	xfr =3D list_first_entry_or_null(&occ->xfrs, struct occ_xfr, link);
> > =C2=A0	if (!xfr) {
> > =C2=A0		spin_unlock_irq(&occ->list_lock);
> > =C2=A0		return;
--=-6vx0QKGjjpar523BmQuA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIcBAABCgAGBQJZnS1sAAoJEJ0dnzgO5LT5DcsP/19pHwxbsMTZbdkkg52yGttj
Y/2g7hKt0qrCK9E9WLTWs5YOoXBD4geBE5RiZztYcCpgONNdKlSzwvv5FuXJQ8l8
j7xBFHlsnXhZPk/zpfIiFu1qSbvJLT41RV9C1sNUd+NFnpS14Q3LLJamOQ3JmKRA
UxSd5hy4kQ/QMlRcqMblisokAaY8wDdRW+Xw7BGLGb+vc+59rUr7InWyeh+n9+tm
JyaVJCVDAWygUO5GAaHYWZ3k5ZoZZS8svgZ1nVQ1gyquF/7sSOju+jd6kd1KIriD
B54PuyRtR6wnBPPkqkG26bb247suKt4c+TweqHD6ZRPsode4mNtty509PwvxxVxs
V+tkzNAeGuhf+EZ5hzM0wNmbpiAY6Icj97EGIbsUKMREHadcw7aRzOQUnRETeNv/
SFW3Y1nAHDUoYzymSA7jQTY/w3lOJgjQY6q/oSfhxHU3QGqgaJIX2+SexNJ/qmgT
D2PjPNvQ0QdFQVwy0E0JvPbHIZQXFcb6E2552/LiR+DK/8RCynMDo3fy496J+6AX
1LnPPgcF4EcnynfU8Vq4MYE+Qd27gXvQIMIWB4MwrDmNZBN5kdmM5wXdTWuoagSO
QpqFT60Nn3CPazQSgBIheEkpwEbpPqPaUmMfoaZjvEkLard7L9KWsrCq5F7vg6Yw
waZCBCtCCjJkMPq/oe4G
=ersc
-----END PGP SIGNATURE-----

--=-6vx0QKGjjpar523BmQuA--