From: "Pandiyan, Dhinakaran" Subject: Re: [PATCH 2/2] drm/i915/mst: Use MST sideband message transaction for dpms Date: Tue, 12 Sep 2017 19:08:37 +0000 Message-ID: <1505244612.30475.1.camel@dk-H97M-D3H> References: <20170906012634.3975-1-dhinakaran.pandiyan@intel.com> <20170906012634.3975-2-dhinakaran.pandiyan@intel.com> <20170912161132.GY4914@intel.com> <20170912161737.GZ4914@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170912161737.GZ4914@intel.com> Content-Language: en-US Content-ID: <4F7D2CEBDA54FF439140886F02FECE6F@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "ville.syrjala@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMDE3LTA5LTEyIGF0IDE5OjE3ICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 DQo+IE9uIFR1ZSwgU2VwIDEyLCAyMDE3IGF0IDA3OjExOjMyUE0gKzAzMDAsIFZpbGxlIFN5cmrD pGzDpCB3cm90ZToNCj4gPiBPbiBUdWUsIFNlcCAwNSwgMjAxNyBhdCAwNjoyNjozNFBNIC0wNzAw LCBEaGluYWthcmFuIFBhbmRpeWFuIHdyb3RlOg0KPiA+ID4gVXNlIHRoZSBQT1dFUl9ET1dOX1BI WSBhbmQgUE9XRVJfVVBfUEhZIHNpZGViYW5kIG1lc3NhZ2UgdHJhc2FjdGlvbnMgdG8NCj4gPiA+ IHNldCBwb3dlciBzdGF0ZXMgZm9yIGRvd25zdHJlYW0gc2lua3MuIEFwYXJ0IGZyb20gZ2l2aW5n IHVzIHRoZSBhYmlsaXR5DQo+ID4gPiB0byBzZXQgcG93ZXIgc3RhdGUgZm9yIGluZGl2aWR1YWwg c2lua3MsIHRoaXMgZml4ZXMgdGhlIGJlbG93IHRlc3QgZm9yDQo+ID4gPiBtZQ0KPiA+ID4gDQo+ ID4gPiAkIHhyYW5kciAtLWRpc3BsYXkgOjAgLS1vdXRwdXQgRFAtMi0yLTggLS1vZmYNCj4gPiA+ ICQgeHJhbmRyIC0tZGlzcGxheSA6MCAtLW91dHB1dCBEUC0yLTItMSAtLW9mZg0KPiA+ID4gJCB4 cmFuZHIgLS1kaXNwbGF5IDowIC0tb3V0cHV0IERQLTItMi04IC0tYXV0byAjQmxhY2sgc2NyZWVu DQo+ID4gPiAkIHhyYW5kciAtLWRpc3BsYXkgOjAgLS1vdXRwdXQgRFAtMi0yLTEgLS1hdXRvDQo+ ID4gPiANCj4gPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPg0KPiA+ID4gQ2M6IEx5dWRlIDxseXVkZUByZWRoYXQuY29tPg0KPiA+ID4gU2lnbmVk LW9mZi1ieTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5j b20+DQo+ID4gPiAtLS0NCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyAg ICB8IDYgKysrKy0tDQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMg fCA4ICsrKystLS0tDQo+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDYg ZGVsZXRpb25zKC0pDQo+ID4gPiANCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jDQo+ID4g PiBpbmRleCAxZGEzYmIyY2M0YjQuLjhhZWJhY2MwYWEzMSAxMDA2NDQNCj4gPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jDQo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kZGkuYw0KPiA+ID4gQEAgLTIxNjEsNyArMjE2MSw4IEBAIHN0YXRpYyB2 b2lkIGludGVsX2RkaV9wcmVfZW5hYmxlX2RwKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVy LA0KPiA+ID4gIAkJaW50ZWxfcHJlcGFyZV9kcF9kZGlfYnVmZmVycyhlbmNvZGVyKTsNCj4gPiA+ ICANCj4gPiA+ICAJaW50ZWxfZGRpX2luaXRfZHBfYnVmX3JlZyhlbmNvZGVyKTsNCj4gPiA+IC0J aW50ZWxfZHBfc2lua19kcG1zKGludGVsX2RwLCBEUk1fTU9ERV9EUE1TX09OKTsNCj4gPiA+ICsJ aWYgKCFsaW5rX21zdCkNCj4gPiA+ICsJCWludGVsX2RwX3NpbmtfZHBtcyhpbnRlbF9kcCwgRFJN X01PREVfRFBNU19PTik7DQo+ID4gPiAgCWludGVsX2RwX3N0YXJ0X2xpbmtfdHJhaW4oaW50ZWxf ZHApOw0KPiA+ID4gIAlpZiAocG9ydCAhPSBQT1JUX0EgfHwgSU5URUxfR0VOKGRldl9wcml2KSA+ PSA5KQ0KPiA+ID4gIAkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsNCj4gPiA+ IEBAIC0yMjQwLDcgKzIyNDEsOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9kZGlfcG9zdF9kaXNhYmxl KHN0cnVjdCBpbnRlbF9lbmNvZGVyICppbnRlbF9lbmNvZGVyLA0KPiA+ID4gIAlpZiAodHlwZSA9 PSBJTlRFTF9PVVRQVVRfRFAgfHwgdHlwZSA9PSBJTlRFTF9PVVRQVVRfRURQKSB7DQo+ID4gPiAg CQlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwID0gZW5jX3RvX2ludGVsX2RwKGVuY29kZXIpOw0K PiA+ID4gIA0KPiA+ID4gLQkJaW50ZWxfZHBfc2lua19kcG1zKGludGVsX2RwLCBEUk1fTU9ERV9E UE1TX09GRik7DQo+ID4gPiArCQlpZiAob2xkX2NydGNfc3RhdGUgJiYgb2xkX2Nvbm5fc3RhdGUp DQo+ID4gPiArCQkJaW50ZWxfZHBfc2lua19kcG1zKGludGVsX2RwLCBEUk1fTU9ERV9EUE1TX09G Rik7DQo+ID4gDQo+ID4gSSB3b3VsZCBtYWtlIHRoYXQNCj4gPiAhaW50ZWxfY3J0Y19oYXNfdHlw ZShEUF9NU1QpDQo+ID4gDQo+ID4gPiAgCX0NCj4gPiA+ICANCj4gPiA+ICAJdmFsID0gSTkxNV9S RUFEKERESV9CVUZfQ1RMKHBvcnQpKTsNCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcF9tc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21z dC5jDQo+ID4gPiBpbmRleCA4ZTNhYWQwZWE2MGIuLjgxZTYzNzI0ZTI0YiAxMDA2NDQNCj4gPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jDQo+ID4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYw0KPiA+ID4gQEAgLTE2NywxMiArMTY3 LDExIEBAIHN0YXRpYyB2b2lkIGludGVsX21zdF9wb3N0X2Rpc2FibGVfZHAoc3RydWN0IGludGVs X2VuY29kZXIgKmVuY29kZXIsDQo+ID4gPiAgCWludGVsX2RwLT5hY3RpdmVfbXN0X2xpbmtzLS07 DQo+ID4gPiAgDQo+ID4gPiAgCWludGVsX21zdC0+Y29ubmVjdG9yID0gTlVMTDsNCj4gPiA+IC0J aWYgKGludGVsX2RwLT5hY3RpdmVfbXN0X2xpbmtzID09IDApIHsNCj4gPiA+ICsJaWYgKGludGVs X2RwLT5hY3RpdmVfbXN0X2xpbmtzID09IDApDQo+ID4gPiAgCQlpbnRlbF9kaWdfcG9ydC0+YmFz ZS5wb3N0X2Rpc2FibGUoJmludGVsX2RpZ19wb3J0LT5iYXNlLA0KPiA+ID4gIAkJCQkJCSAgTlVM TCwgTlVMTCk7DQo+ID4gPiAtDQo+ID4gPiAtCQlpbnRlbF9kcF9zaW5rX2RwbXMoaW50ZWxfZHAs IERSTV9NT0RFX0RQTVNfT0ZGKTsNCj4gPiA+IC0JfQ0KPiA+ID4gKwlkcm1fZHBfc2VuZF9wb3dl cl91cGRvd25fcGh5KCZpbnRlbF9kcC0+bXN0X21nciwgY29ubmVjdG9yLT5wb3J0LA0KPiA+ID4g KwkJCQkgICAgIGZhbHNlKTsNCj4gPiANCj4gPiBPbmUgdGhpbmcgdGhhdCBib3RoZXJzIG1lIGhl cmUgaXMgd2hldGhlciB3ZSdsbCBzdGFydCBnZXR0aW5nIGJvZ3VzIGxpbmsNCj4gPiB0cmFpbmlu ZyByZXF1ZXN0cyBkdXJpbmcgc2h1dGRvd24gc2luY2Ugd2UnbGwgZG8gdGhlIEQzIG9ubHkgYWZ0 ZXIgdGhlDQo+ID4gc3RyZWFtIGhhcyBiZWVuIHN0b3BwZWQuIElmIHlvdSdsbCBsb29rIGF0IGNv bW1pdCA3NjE4MTM4ZDhiNDANCj4gPiAoImRybS9pOTE1L2RkaTogQXZvaWQgbG9uZyBkZWxheXMg ZHVyaW5nIHN5c3RlbSBzdXNwZW5kIC8gZURQDQo+ID4gZGlzYWJsaW5nIikgSW1yZSBleHBsaWNp dGx5IG1vdmVkIHRoZSBEMyBlYXJsaWVyIGZvciBTU1QgdG8gYXZvaWQgdGhpcy4NCj4gPiANCg0K SW50ZXJlc3RpbmcsIHRoYXQgcGF0Y2ggbWFrZXMgYSBsb3Qgb2Ygc2Vuc2UuDQoNCj4gPiBIbW0u IEFjdHVhbGx5IGJ5IHRoZSB0aW1lIHdlIGNhbGwgbXN0X3Bvc3RfZGlzYWJsZSgpIHdlIHNob3Vs ZCBoYXZlDQo+ID4gZGVhbGxvY2F0ZWQgdGhlIFZDIGV0Yy4gc28gdGhlIGN1cnJlbnQgc3RyZWFt IHNob3VsZCBiZSBhbHJlYWR5DQo+ID4gdGVybWluYXRlZCBhdCB0aGF0IHBvaW50LiBTbyBJIHRo aW5rIHdlIHNob3VsZCBiZSBhYmxlIHRvIGRvIHRoZQ0KPiA+IFBIWV9QT1dFUl9ET1dOIGJlZm9y ZSB3ZSBzaHV0IGRvd24gdGhlIGxpbmssIGp1c3QgbGlrZSB3ZSBkbyBmb3IgU1NULg0KPiANCj4g TWlnaHQgYWxzbyBiZSBuaWNlIHRvIGFkZCBjb21tZW50cyBuZWFyIGFsbCB0aGUgRDMgY2FsbHMg dG8gZG9jdW1lbnQNCj4gdGhhdCB0aGUgb3JkZXIgd2UgdXNlIGlzIHRoZXJlIHRvIHByZXZlbnQg dGhlIHNpbmsgZnJvbSBjb21wbGFpbmluZw0KPiBhYm91dCBsaW5rIGxvc3Mgd2hlbiB3ZSBzaHV0 IGRvd24gdGhlIGxpbmsuIE90aGVyd2lzZSBzb21lb25lIG1pZ2h0DQo+IGdldCB0ZW1wdGVkIHRv IHJlb3JkZXIgdGhpbmdzIGFzIGEgY2xlYW51cCBvciBzb21ldGhpbmcuDQo+IA0KDQpTdXJlLg0K DQo+ID4gDQo+ID4gPiAgfQ0KPiA+ID4gIA0KPiA+ID4gIHN0YXRpYyB2b2lkIGludGVsX21zdF9w cmVfZW5hYmxlX2RwKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLA0KPiA+ID4gQEAgLTE5 Nyw2ICsxOTYsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tc3RfcHJlX2VuYWJsZV9kcChzdHJ1Y3Qg aW50ZWxfZW5jb2RlciAqZW5jb2RlciwNCj4gPiA+ICANCj4gPiA+ICAJRFJNX0RFQlVHX0tNUygi JWRcbiIsIGludGVsX2RwLT5hY3RpdmVfbXN0X2xpbmtzKTsNCj4gPiA+ICANCj4gPiA+ICsJZHJt X2RwX3NlbmRfcG93ZXJfdXBkb3duX3BoeSgmaW50ZWxfZHAtPm1zdF9tZ3IsIGNvbm5lY3Rvci0+ cG9ydCwgdHJ1ZSk7DQo+ID4gPiAgCWlmIChpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcyA9PSAw KQ0KPiA+ID4gIAkJaW50ZWxfZGlnX3BvcnQtPmJhc2UucHJlX2VuYWJsZSgmaW50ZWxfZGlnX3Bv cnQtPmJhc2UsDQo+ID4gPiAgCQkJCQkJcGlwZV9jb25maWcsIE5VTEwpOw0KPiA+ID4gLS0gDQo+ ID4gPiAyLjExLjANCj4gPiANCj4gPiAtLSANCj4gPiBWaWxsZSBTeXJqw6Rsw6QNCj4gPiBJbnRl bCBPVEMNCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xw0KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QNCj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnDQo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngNCj4gDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK