From: "Pandiyan, Dhinakaran" Subject: Re: [PATCH 5/9] drm/i915/dp: Remove intel_dp->is_mst check in intel_dp_check_mst_status Date: Wed, 13 Sep 2017 20:13:16 +0000 Message-ID: <1505334892.18901.2.camel@dk-H97M-D3H> References: <20170912235730.3492-1-dhinakaran.pandiyan@intel.com> <20170912235730.3492-5-dhinakaran.pandiyan@intel.com> <878thjj651.fsf@nikula.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id DCB566E8A8 for ; Wed, 13 Sep 2017 20:13:18 +0000 (UTC) In-Reply-To: <878thjj651.fsf@nikula.org> Content-Language: en-US Content-ID: <8579C698FF9D1D4EA0FFD9727B31E42D@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "jani.nikula@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org DQoNCg0KT24gV2VkLCAyMDE3LTA5LTEzIGF0IDEyOjMyICswMzAwLCBKYW5pIE5pa3VsYSB3cm90 ZToNCj4gT24gVHVlLCAxMiBTZXAgMjAxNywgRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJh bi5wYW5kaXlhbkBpbnRlbC5jb20+IHdyb3RlOg0KPiA+IFRoZXJlIGlzIGp1c3Qgb25seSBvbmUg Y2FsbGVyIG5vdywgd2hpY2ggYWxyZWFkeSBjaGVja3MgZm9yDQo+ID4gaW50ZWxfZHAtPmlzX21z dC4gU28sIHJlbW92ZSB0aGlzIGFuZCBmaXggc29tZSBicmFjZXMgd2hpbGUgYXQgaXQuDQo+ID4N Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRp eWFuQGludGVsLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHAuYyB8IDg1ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+ID4g IDEgZmlsZSBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCA0MyBkZWxldGlvbnMoLSkNCj4gPg0K PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYw0KPiA+IGluZGV4IGIzZDk1Y2I3NTQ2Yi4uM2YyY2Ex MGNjYmNkIDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMN Cj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jDQo+ID4gQEAgLTQxOTIs NTcgKzQxOTIsNTYgQEAgc3RhdGljIGludA0KPiA+ICBpbnRlbF9kcF9jaGVja19tc3Rfc3RhdHVz KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApDQo+ID4gIHsNCj4gPiAgCWJvb2wgYnJldDsNCj4g PiArCXU4IGVzaVtEUF9EUFJYX0VTSV9MRU5dID0geyAwIH07DQo+ID4gKwlpbnQgcmV0ID0gMDsN Cj4gPiArCWludCByZXRyeTsNCj4gPiArCWJvb2wgaGFuZGxlZDsNCj4gPiAgDQo+ID4gLQlpZiAo aW50ZWxfZHAtPmlzX21zdCkgew0KPiA+IC0JCXU4IGVzaVtEUF9EUFJYX0VTSV9MRU5dID0geyAw IH07DQo+ID4gLQkJaW50IHJldCA9IDA7DQo+ID4gLQkJaW50IHJldHJ5Ow0KPiA+IC0JCWJvb2wg aGFuZGxlZDsNCj4gPiAtCQlicmV0ID0gaW50ZWxfZHBfZ2V0X3NpbmtfaXJxX2VzaShpbnRlbF9k cCwgZXNpKTsNCj4gPiArCWJyZXQgPSBpbnRlbF9kcF9nZXRfc2lua19pcnFfZXNpKGludGVsX2Rw LCBlc2kpOw0KPiA+ICBnb19hZ2FpbjoNCj4gPiAtCQlpZiAoYnJldCA9PSB0cnVlKSB7DQo+ID4g LQ0KPiA+IC0JCQkvKiBjaGVjayBsaW5rIHN0YXR1cyAtIGVzaVsxMF0gPSAweDIwMGMgKi8NCj4g DQo+IERyaXZlLWJ5IG9ic2VydmF0aW9uIHVucmVsYXRlZCB0byB0aGlzIHBhdGNoOiAweDIwMGMg aXNuJ3QgZXZlbiBkZWZpbmVkDQo+IGluIGRybV9kcF9oZWxwZXIuaC4uLiBjYXJlIHRvIGFkZCB0 aGF0LCBwbGVhc2U/DQoNClN1cmUuDQoNCg0KPiANCj4gQlIsDQo+IEphbmkuDQo+IA0KPiA+IC0J CQlpZiAoaW50ZWxfZHAtPmFjdGl2ZV9tc3RfbGlua3MgJiYNCj4gPiAtCQkJICAgICFkcm1fZHBf Y2hhbm5lbF9lcV9vaygmZXNpWzEwXSwgaW50ZWxfZHAtPmxhbmVfY291bnQpKSB7DQo+ID4gLQkJ CQlEUk1fREVCVUdfS01TKCJjaGFubmVsIEVRIG5vdCBvaywgcmV0cmFpbmluZ1xuIik7DQo+ID4g LQkJCQlpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKGludGVsX2RwKTsNCj4gPiAtCQkJCWludGVs X2RwX3N0b3BfbGlua190cmFpbihpbnRlbF9kcCk7DQo+ID4gLQkJCX0NCj4gPiArCWlmIChicmV0 ID09IHRydWUpIHsNCj4gPiArDQo+ID4gKwkJLyogY2hlY2sgbGluayBzdGF0dXMgLSBlc2lbMTBd ID0gMHgyMDBjICovDQo+ID4gKwkJaWYgKGludGVsX2RwLT5hY3RpdmVfbXN0X2xpbmtzICYmDQo+ ID4gKwkJICAgICFkcm1fZHBfY2hhbm5lbF9lcV9vaygmZXNpWzEwXSwgaW50ZWxfZHAtPmxhbmVf Y291bnQpKSB7DQo+ID4gKwkJCURSTV9ERUJVR19LTVMoImNoYW5uZWwgRVEgbm90IG9rLCByZXRy YWluaW5nXG4iKTsNCj4gPiArCQkJaW50ZWxfZHBfc3RhcnRfbGlua190cmFpbihpbnRlbF9kcCk7 DQo+ID4gKwkJCWludGVsX2RwX3N0b3BfbGlua190cmFpbihpbnRlbF9kcCk7DQo+ID4gKwkJfQ0K PiA+ICANCj4gPiAtCQkJRFJNX0RFQlVHX0tNUygiZ290IGVzaSAlM3BoXG4iLCBlc2kpOw0KPiA+ IC0JCQlyZXQgPSBkcm1fZHBfbXN0X2hwZF9pcnEoJmludGVsX2RwLT5tc3RfbWdyLCBlc2ksICZo YW5kbGVkKTsNCj4gPiAtDQo+ID4gLQkJCWlmIChoYW5kbGVkKSB7DQo+ID4gLQkJCQlmb3IgKHJl dHJ5ID0gMDsgcmV0cnkgPCAzOyByZXRyeSsrKSB7DQo+ID4gLQkJCQkJaW50IHdyZXQ7DQo+ID4g LQkJCQkJd3JldCA9IGRybV9kcF9kcGNkX3dyaXRlKCZpbnRlbF9kcC0+YXV4LA0KPiA+IC0JCQkJ CQkJCSBEUF9TSU5LX0NPVU5UX0VTSSsxLA0KPiA+IC0JCQkJCQkJCSAmZXNpWzFdLCAzKTsNCj4g PiAtCQkJCQlpZiAod3JldCA9PSAzKSB7DQo+ID4gLQkJCQkJCWJyZWFrOw0KPiA+IC0JCQkJCX0N Cj4gPiAtCQkJCX0NCj4gPiArCQlEUk1fREVCVUdfS01TKCJnb3QgZXNpICUzcGhcbiIsIGVzaSk7 DQo+ID4gKwkJcmV0ID0gZHJtX2RwX21zdF9ocGRfaXJxKCZpbnRlbF9kcC0+bXN0X21nciwgZXNp LCAmaGFuZGxlZCk7DQo+ID4gIA0KPiA+IC0JCQkJYnJldCA9IGludGVsX2RwX2dldF9zaW5rX2ly cV9lc2koaW50ZWxfZHAsIGVzaSk7DQo+ID4gLQkJCQlpZiAoYnJldCA9PSB0cnVlKSB7DQo+ID4g LQkJCQkJRFJNX0RFQlVHX0tNUygiZ290IGVzaTIgJTNwaFxuIiwgZXNpKTsNCj4gPiAtCQkJCQln b3RvIGdvX2FnYWluOw0KPiA+IC0JCQkJfQ0KPiA+IC0JCQl9IGVsc2UNCj4gPiAtCQkJCXJldCA9 IDA7DQo+ID4gKwkJaWYgKGhhbmRsZWQpIHsNCj4gPiArCQkJZm9yIChyZXRyeSA9IDA7IHJldHJ5 IDwgMzsgcmV0cnkrKykgew0KPiA+ICsJCQkJaW50IHdyZXQ7DQo+ID4gIA0KPiA+IC0JCQlyZXR1 cm4gcmV0Ow0KPiA+ICsJCQkJd3JldCA9IGRybV9kcF9kcGNkX3dyaXRlKCZpbnRlbF9kcC0+YXV4 LA0KPiA+ICsJCQkJCQkJIERQX1NJTktfQ09VTlRfRVNJKzEsDQo+ID4gKwkJCQkJCQkgJmVzaVsx XSwgMyk7DQo+ID4gKwkJCQlpZiAod3JldCA9PSAzKQ0KPiA+ICsJCQkJCWJyZWFrOw0KPiA+ICsJ CQl9DQo+ID4gKw0KPiA+ICsJCQlicmV0ID0gaW50ZWxfZHBfZ2V0X3NpbmtfaXJxX2VzaShpbnRl bF9kcCwgZXNpKTsNCj4gPiArCQkJaWYgKGJyZXQgPT0gdHJ1ZSkgew0KPiA+ICsJCQkJRFJNX0RF QlVHX0tNUygiZ290IGVzaTIgJTNwaFxuIiwgZXNpKTsNCj4gPiArCQkJCWdvdG8gZ29fYWdhaW47 DQo+ID4gKwkJCX0NCj4gPiAgCQl9IGVsc2Ugew0KPiA+IC0JCQlzdHJ1Y3QgaW50ZWxfZGlnaXRh bF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsNCj4gPiAt CQkJRFJNX0RFQlVHX0tNUygiZmFpbGVkIHRvIGdldCBFU0kgLSBkZXZpY2UgbWF5IGhhdmUgZmFp bGVkXG4iKTsNCj4gPiAtCQkJaW50ZWxfZHAtPmlzX21zdCA9IGZhbHNlOw0KPiA+IC0JCQlkcm1f ZHBfbXN0X3RvcG9sb2d5X21ncl9zZXRfbXN0KCZpbnRlbF9kcC0+bXN0X21nciwgaW50ZWxfZHAt PmlzX21zdCk7DQo+ID4gLQkJCS8qIHNlbmQgYSBob3RwbHVnIGV2ZW50ICovDQo+ID4gLQkJCWRy bV9rbXNfaGVscGVyX2hvdHBsdWdfZXZlbnQoaW50ZWxfZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYp Ow0KPiA+ICsJCQlyZXQgPSAwOw0KPiA+ICAJCX0NCj4gPiArCX0gZWxzZSB7DQo+ID4gKwkJc3Ry dWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPSBkcF90b19kaWdfcG9ydChp bnRlbF9kcCk7DQo+ID4gKw0KPiA+ICsJCURSTV9ERUJVR19LTVMoImZhaWxlZCB0byBnZXQgRVNJ IC0gZGV2aWNlIG1heSBoYXZlIGZhaWxlZFxuIik7DQo+ID4gKwkJaW50ZWxfZHAtPmlzX21zdCA9 IGZhbHNlOw0KPiA+ICsJCWRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyX3NldF9tc3QoJmludGVsX2Rw LT5tc3RfbWdyLA0KPiA+ICsJCQkJCQlpbnRlbF9kcC0+aXNfbXN0KTsNCj4gPiArCQlkcm1fa21z X2hlbHBlcl9ob3RwbHVnX2V2ZW50KGludGVsX2RpZ19wb3J0LT5iYXNlLmJhc2UuZGV2KTsNCj4g PiArCQlyZXQgPSAtRUlOVkFMOw0KPiA+ICAJfQ0KPiA+IC0JcmV0dXJuIC1FSU5WQUw7DQo+ID4g KwlyZXR1cm4gcmV0Ow0KPiA+ICB9DQo+ID4gIA0KPiA+ICBzdGF0aWMgdm9pZA0KPiANCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=