From: "Pandiyan, Dhinakaran" Subject: Re: [PATCH 5/9] drm/i915/dp: Remove intel_dp->is_mst check in intel_dp_check_mst_status Date: Wed, 13 Sep 2017 20:33:14 +0000 Message-ID: <1505336090.18901.12.camel@dk-H97M-D3H> References: <20170912235730.3492-1-dhinakaran.pandiyan@intel.com> <20170912235730.3492-5-dhinakaran.pandiyan@intel.com> <20170913133157.GL4914@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38AB76E8BE for ; Wed, 13 Sep 2017 20:33:16 +0000 (UTC) In-Reply-To: <20170913133157.GL4914@intel.com> Content-Language: en-US Content-ID: <3D53DE1706409740A6DF9D3A3EBD002E@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "ville.syrjala@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE3LTA5LTEzIGF0IDE2OjMxICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 DQo+IE9uIFR1ZSwgU2VwIDEyLCAyMDE3IGF0IDA0OjU3OjI2UE0gLTA3MDAsIERoaW5ha2FyYW4g UGFuZGl5YW4gd3JvdGU6DQo+ID4gVGhlcmUgaXMganVzdCBvbmx5IG9uZSBjYWxsZXIgbm93LCB3 aGljaCBhbHJlYWR5IGNoZWNrcyBmb3INCj4gPiBpbnRlbF9kcC0+aXNfbXN0LiBTbywgcmVtb3Zl IHRoaXMgYW5kIGZpeCBzb21lIGJyYWNlcyB3aGlsZSBhdCBpdC4NCj4gDQo+IEhtbS4gU28gdGhp cyBkZXBlbmRzIG9uIHRoZSBzdWJ0bGUgZGV0YWlsIHRoYXQNCj4gZHJtX2RwX21zdF90b3BvbG9n eV9tZ3JfcmVzdW1lKCkgd2lsbCAiZmFpbCIgaWYgZGlkbid0IGVuYWJsZSBtc3QNCj4gcHJpb3Ig dG8gY2FsbGluZyBpdC4gVGhhdCBmYWN0IGlzbid0IG9idmlvdXMgYXQgYWxsLCBzbyBJIHdvdWxk DQo+IHN1Z2dlc3Qgbm90aW5nIHRoYXQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlIGF0IGxlYXN0ICht YXliZSB3ZSBzaG91bGQNCj4gZXZlbiBoYXZlIGEgY29tbWVudCBpbiB0aGUgY29kZT8pDQo+IA0K PiBJJ20gYXNzdW1pbmcgdGhlcmUgYXJlIG5vdCBvdGhlciBjaGFuZ2VzIGJleW9uZCBqdXN0IGRy b3BwaW5nIHRoZQ0KPiB0b3AgbGV2ZWwgJ2lmIChtc3QpIHsgfScgdGhpbmc/IFRoaXMgaXMgb25l IHJlYXNvbiBJIHByZWZlciBmbGF0IGNvZGUuDQo+IElmIHRoZSBmdW5jdGlvbiBoYWQgYmVlbiBm bGF0IHRvIGJlZ2luIHdpdGggdGhlIGRpZmYgd291bGQgaGF2ZQ0KPiBhY3R1YWxseSB0dXJuZWQg b3V0IGxlZ2libGUuIElJUkMgSSBldmVuIHBvc3RlZCBhIGZsYXR0ZW5pbmcgcGF0Y2ggYXQNCj4g c29tZSBwb2ludCBidXQgSSBndWVzcyBpdCBkaWRuJ3QgZ28gaW4uIEkgd291bGQgc3VnZ2VzdCB0 aGF0IHlvdSB0YWtlDQo+IHRoZSBvcHBvcnR1bml0eSB0byBmbGF0dGVuIG91dCB0aGUgcmVzdCBv ZiB0aGlzIGZ1bmN0aW9uIHdoaWxlIHlvdQ0KPiBpbiB0aGUgbmVpZ2hib3VyaG9vZC4NCg0KVGhh dCB3YXMgdGhlIGdvYWwgOikgVGhlbiBJIGRlY2lkZWQgdG8gc2ltcGxpZnkgdGhlIGZ1bmN0aW9u IGEgbGl0dGxlDQpiaXQgaW4gcGF0Y2hlcyA0LCA1LCA2IGFuZCA3IGJlZm9yZSB3b3JraW5nIG9u IG1vZGlmeWluZyBpdCdzIHN0cnVjdHVyZS4NCg0KPiANCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5 OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4NCj4g PiAtLS0NCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDg1ICsrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0 MiBpbnNlcnRpb25zKCspLCA0MyBkZWxldGlvbnMoLSkNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMNCj4gPiBpbmRleCBiM2Q5NWNiNzU0NmIuLjNmMmNhMTBjY2JjZCAxMDA2NDQNCj4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jDQo+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYw0KPiA+IEBAIC00MTkyLDU3ICs0MTkyLDU2IEBAIHN0 YXRpYyBpbnQNCj4gPiAgaW50ZWxfZHBfY2hlY2tfbXN0X3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAg KmludGVsX2RwKQ0KPiA+ICB7DQo+ID4gIAlib29sIGJyZXQ7DQo+ID4gKwl1OCBlc2lbRFBfRFBS WF9FU0lfTEVOXSA9IHsgMCB9Ow0KPiA+ICsJaW50IHJldCA9IDA7DQo+ID4gKwlpbnQgcmV0cnk7 DQo+ID4gKwlib29sIGhhbmRsZWQ7DQo+ID4gIA0KPiA+IC0JaWYgKGludGVsX2RwLT5pc19tc3Qp IHsNCj4gPiAtCQl1OCBlc2lbRFBfRFBSWF9FU0lfTEVOXSA9IHsgMCB9Ow0KPiA+IC0JCWludCBy ZXQgPSAwOw0KPiA+IC0JCWludCByZXRyeTsNCj4gPiAtCQlib29sIGhhbmRsZWQ7DQo+ID4gLQkJ YnJldCA9IGludGVsX2RwX2dldF9zaW5rX2lycV9lc2koaW50ZWxfZHAsIGVzaSk7DQo+ID4gKwli cmV0ID0gaW50ZWxfZHBfZ2V0X3NpbmtfaXJxX2VzaShpbnRlbF9kcCwgZXNpKTsNCj4gPiAgZ29f YWdhaW46DQo+ID4gLQkJaWYgKGJyZXQgPT0gdHJ1ZSkgew0KPiA+IC0NCj4gPiAtCQkJLyogY2hl Y2sgbGluayBzdGF0dXMgLSBlc2lbMTBdID0gMHgyMDBjICovDQo+ID4gLQkJCWlmIChpbnRlbF9k cC0+YWN0aXZlX21zdF9saW5rcyAmJg0KPiA+IC0JCQkgICAgIWRybV9kcF9jaGFubmVsX2VxX29r KCZlc2lbMTBdLCBpbnRlbF9kcC0+bGFuZV9jb3VudCkpIHsNCj4gPiAtCQkJCURSTV9ERUJVR19L TVMoImNoYW5uZWwgRVEgbm90IG9rLCByZXRyYWluaW5nXG4iKTsNCj4gPiAtCQkJCWludGVsX2Rw X3N0YXJ0X2xpbmtfdHJhaW4oaW50ZWxfZHApOw0KPiA+IC0JCQkJaW50ZWxfZHBfc3RvcF9saW5r X3RyYWluKGludGVsX2RwKTsNCj4gPiAtCQkJfQ0KPiA+ICsJaWYgKGJyZXQgPT0gdHJ1ZSkgew0K PiA+ICsNCj4gPiArCQkvKiBjaGVjayBsaW5rIHN0YXR1cyAtIGVzaVsxMF0gPSAweDIwMGMgKi8N Cj4gPiArCQlpZiAoaW50ZWxfZHAtPmFjdGl2ZV9tc3RfbGlua3MgJiYNCj4gPiArCQkgICAgIWRy bV9kcF9jaGFubmVsX2VxX29rKCZlc2lbMTBdLCBpbnRlbF9kcC0+bGFuZV9jb3VudCkpIHsNCj4g PiArCQkJRFJNX0RFQlVHX0tNUygiY2hhbm5lbCBFUSBub3Qgb2ssIHJldHJhaW5pbmdcbiIpOw0K PiA+ICsJCQlpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKGludGVsX2RwKTsNCj4gPiArCQkJaW50 ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsNCj4gPiArCQl9DQo+ID4gIA0KPiA+IC0J CQlEUk1fREVCVUdfS01TKCJnb3QgZXNpICUzcGhcbiIsIGVzaSk7DQo+ID4gLQkJCXJldCA9IGRy bV9kcF9tc3RfaHBkX2lycSgmaW50ZWxfZHAtPm1zdF9tZ3IsIGVzaSwgJmhhbmRsZWQpOw0KPiA+ IC0NCj4gPiAtCQkJaWYgKGhhbmRsZWQpIHsNCj4gPiAtCQkJCWZvciAocmV0cnkgPSAwOyByZXRy eSA8IDM7IHJldHJ5KyspIHsNCj4gPiAtCQkJCQlpbnQgd3JldDsNCj4gPiAtCQkJCQl3cmV0ID0g ZHJtX2RwX2RwY2Rfd3JpdGUoJmludGVsX2RwLT5hdXgsDQo+ID4gLQkJCQkJCQkJIERQX1NJTktf Q09VTlRfRVNJKzEsDQo+ID4gLQkJCQkJCQkJICZlc2lbMV0sIDMpOw0KPiA+IC0JCQkJCWlmICh3 cmV0ID09IDMpIHsNCj4gPiAtCQkJCQkJYnJlYWs7DQo+ID4gLQkJCQkJfQ0KPiA+IC0JCQkJfQ0K PiA+ICsJCURSTV9ERUJVR19LTVMoImdvdCBlc2kgJTNwaFxuIiwgZXNpKTsNCj4gPiArCQlyZXQg PSBkcm1fZHBfbXN0X2hwZF9pcnEoJmludGVsX2RwLT5tc3RfbWdyLCBlc2ksICZoYW5kbGVkKTsN Cj4gPiAgDQo+ID4gLQkJCQlicmV0ID0gaW50ZWxfZHBfZ2V0X3NpbmtfaXJxX2VzaShpbnRlbF9k cCwgZXNpKTsNCj4gPiAtCQkJCWlmIChicmV0ID09IHRydWUpIHsNCj4gPiAtCQkJCQlEUk1fREVC VUdfS01TKCJnb3QgZXNpMiAlM3BoXG4iLCBlc2kpOw0KPiA+IC0JCQkJCWdvdG8gZ29fYWdhaW47 DQo+ID4gLQkJCQl9DQo+ID4gLQkJCX0gZWxzZQ0KPiA+IC0JCQkJcmV0ID0gMDsNCj4gPiArCQlp ZiAoaGFuZGxlZCkgew0KPiA+ICsJCQlmb3IgKHJldHJ5ID0gMDsgcmV0cnkgPCAzOyByZXRyeSsr KSB7DQo+ID4gKwkJCQlpbnQgd3JldDsNCj4gPiAgDQo+ID4gLQkJCXJldHVybiByZXQ7DQo+ID4g KwkJCQl3cmV0ID0gZHJtX2RwX2RwY2Rfd3JpdGUoJmludGVsX2RwLT5hdXgsDQo+ID4gKwkJCQkJ CQkgRFBfU0lOS19DT1VOVF9FU0krMSwNCj4gPiArCQkJCQkJCSAmZXNpWzFdLCAzKTsNCj4gPiAr CQkJCWlmICh3cmV0ID09IDMpDQo+ID4gKwkJCQkJYnJlYWs7DQo+ID4gKwkJCX0NCj4gPiArDQo+ ID4gKwkJCWJyZXQgPSBpbnRlbF9kcF9nZXRfc2lua19pcnFfZXNpKGludGVsX2RwLCBlc2kpOw0K PiA+ICsJCQlpZiAoYnJldCA9PSB0cnVlKSB7DQo+ID4gKwkJCQlEUk1fREVCVUdfS01TKCJnb3Qg ZXNpMiAlM3BoXG4iLCBlc2kpOw0KPiA+ICsJCQkJZ290byBnb19hZ2FpbjsNCj4gPiArCQkJfQ0K PiA+ICAJCX0gZWxzZSB7DQo+ID4gLQkJCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVs X2RpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOw0KPiA+IC0JCQlEUk1fREVCVUdf S01TKCJmYWlsZWQgdG8gZ2V0IEVTSSAtIGRldmljZSBtYXkgaGF2ZSBmYWlsZWRcbiIpOw0KPiA+ IC0JCQlpbnRlbF9kcC0+aXNfbXN0ID0gZmFsc2U7DQo+ID4gLQkJCWRybV9kcF9tc3RfdG9wb2xv Z3lfbWdyX3NldF9tc3QoJmludGVsX2RwLT5tc3RfbWdyLCBpbnRlbF9kcC0+aXNfbXN0KTsNCj4g PiAtCQkJLyogc2VuZCBhIGhvdHBsdWcgZXZlbnQgKi8NCj4gPiAtCQkJZHJtX2ttc19oZWxwZXJf aG90cGx1Z19ldmVudChpbnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNlLmRldik7DQo+ID4gKwkJCXJl dCA9IDA7DQo+ID4gIAkJfQ0KPiA+ICsJfSBlbHNlIHsNCj4gPiArCQlzdHJ1Y3QgaW50ZWxfZGln aXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsNCj4g PiArDQo+ID4gKwkJRFJNX0RFQlVHX0tNUygiZmFpbGVkIHRvIGdldCBFU0kgLSBkZXZpY2UgbWF5 IGhhdmUgZmFpbGVkXG4iKTsNCj4gPiArCQlpbnRlbF9kcC0+aXNfbXN0ID0gZmFsc2U7DQo+ID4g KwkJZHJtX2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0X21zdCgmaW50ZWxfZHAtPm1zdF9tZ3IsDQo+ ID4gKwkJCQkJCWludGVsX2RwLT5pc19tc3QpOw0KPiA+ICsJCWRybV9rbXNfaGVscGVyX2hvdHBs dWdfZXZlbnQoaW50ZWxfZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOw0KPiA+ICsJCXJldCA9IC1F SU5WQUw7DQo+ID4gIAl9DQo+ID4gLQlyZXR1cm4gLUVJTlZBTDsNCj4gPiArCXJldHVybiByZXQ7 DQo+ID4gIH0NCj4gPiAgDQo+ID4gIHN0YXRpYyB2b2lkDQo+ID4gLS0gDQo+ID4gMi4xMS4wDQo+ IA0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==