From: Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH net-next v2 2/2] net/sched: act_csum: don't use
 spinlock in the fast path
Date: Mon, 22 Jan 2018 12:16:59 +0100
Message-ID: <1516619819.3495.23.camel@redhat.com>
References: <cover.1516366191.git.dcaratti@redhat.com>
         <88f12956018ca5a21d793428ac0b9dc5b3183319.1516366191.git.dcaratti@redhat.com>
         <CAM_iQpWybQrpEddtdbCgy8u6_b46orzddko2Spy8nxEGtwG4pA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: "David S. Miller" <davem@davemloft.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Jiri Pirko <jiri@resnulli.us>
To: Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:57432 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750933AbeAVLRC (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 22 Jan 2018 06:17:02 -0500
In-Reply-To: <CAM_iQpWybQrpEddtdbCgy8u6_b46orzddko2Spy8nxEGtwG4pA@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

hello Cong,
On Sun, 2018-01-21 at 12:28 -0800, Cong Wang wrote:
> > +       params = rcu_dereference(p->params);
> 
> I think you need rtnl_dereference() here, as we don't have RCU read lock here?

you are right, thank you for spotting this.
I will send v3 series today.

regards,

-- 
davide