Return-Path: Received: from imap1.codethink.co.uk ([176.9.8.82]:52979 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933335AbeCGPan (ORCPT ); Wed, 7 Mar 2018 10:30:43 -0500 Message-ID: <1520436639.23626.31.camel@codethink.co.uk> Subject: Re: [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0 From: Ben Hutchings To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Date: Wed, 07 Mar 2018 15:30:39 +0000 In-Reply-To: <20180302084437.007951262@linuxfoundation.org> References: <20180302084435.842679610@linuxfoundation.org> <20180302084437.007951262@linuxfoundation.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On Fri, 2018-03-02 at 09:51 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > ------------------ > > From: Matthieu CASTET > > > [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] > > With the current code, the following sequence won't work : > echo timer > trigger > > echo 0 >  delay_off > * at this point we call > ** led_delay_off_store > ** led_blink_set [...] The commit message got cut truncated here, but the upstream commit message refers to a LED_BLINK_SW flag which is not used in 4.4. So this fix probably isn't needed, though I can't tell whether it does any harm. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.