From: "Pandiyan, Dhinakaran" Subject: Re: [PATCH v2 1/3] drm/i915/frontbuffer: Pull frontbuffer_flush out of gem_obj_pin_to_display Date: Wed, 7 Mar 2018 22:54:28 +0000 Message-ID: <1520464696.20396.55.camel@dk-H97M-D3H> References: <20180307033420.3086-1-dhinakaran.pandiyan@intel.com> <20180307224628.GL4440@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 687C96E22E for ; Wed, 7 Mar 2018 22:54:30 +0000 (UTC) In-Reply-To: <20180307224628.GL4440@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" Cc: "intel-gfx@lists.freedesktop.org" , "Zanoni, Paulo R" List-Id: intel-gfx@lists.freedesktop.org DQoNCg0KT24gV2VkLCAyMDE4LTAzLTA3IGF0IDE0OjQ2IC0wODAwLCBSb2RyaWdvIFZpdmkgd3Jv dGU6DQo+IE9uIFR1ZSwgTWFyIDA2LCAyMDE4IGF0IDA3OjM0OjE4UE0gLTA4MDAsIERoaW5ha2Fy YW4gUGFuZGl5YW4gd3JvdGU6DQo+ID4gRnJvbTogIlBhbmRpeWFuLCBEaGluYWthcmFuIiA8ZGhp bmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+DQo+ID4gDQo+ID4gaTkxNV9nZW1fb2JqX3Bpbl90 b19kaXNwbGF5KCkgY2FsbHMgZnJvbnRidWZmZXJfZmx1c2ggd2l0aCBvcmlnaW4gc2V0IHRvDQo+ ID4gRElSVFlGQi4gVGhlIGNhbGxlcnMgaG93ZXZlciBhcmUgYXQgYSB2YW50YWdlIHBvaW50IHRv IGRlY2lkZSBpZiBoYXJkd2FyZQ0KPiA+IGZyb250YnVmZmVyIHRyYWNraW5nIGNhbiBkbyB0aGUg Zmx1c2ggZm9yIHVzLiBGb3IgZXhhbXBsZSwgbGVnYWN5IGN1cnNvcg0KPiA+IHVwZGF0ZXMsIGxp a2UgZmxpcHMsIHdyaXRlIHRvIE1NSU8gcmVnaXN0ZXJzLCB3aGljaCB0aGVuIHRyaWdnZXJzIFBT UiBmbHVzaA0KPiA+IGJ5IHRoZSBoYXJkd2FyZS4gTW92aW5nIGZyb250YnVmZmVyX2ZsdXNoIG91 dCB3aWxsIGVuYWJsZSB1cyB0byBza2lwIGENCj4gPiBzb2Z0d2FyZSBpbml0aWF0ZWQgZmx1c2gg Ynkgc2V0dGluZyBvcmlnaW4gdG8gRkxJUC4gVGhhbmtzIHRvIENocmlzIGZvciB0aGUNCj4gPiBp ZGVhLg0KPiA+IA0KPiA+IHYyOg0KPiA+IFJlYmFzZWQgZHVlIHRvIFZpbGxlIGFkZGluZyBpbnRl bF9wbGFuZV9waW5fZmIoKS4NCj4gPiBNaW5vciBjb2RlIHJlb3JkZXJpbmcgYXMgZmJfb2JqX2Zs dXNoIGRvZXNuJ3QgbmVlZCBzdHJ1Y3RfbXV0ZXggKENocmlzKQ0KPiA+IA0KPiA+IENjOiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4NCj4gPiBDYzogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4NCj4gPiBDYzogUGF1bG8gWmFub25p IDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogRGhpbmFrYXJh biBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+DQo+ID4gLS0tDQo+ID4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgICAgICB8IDkgKysrKy0tLS0tDQo+ID4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDkgKysrKysrKy0tDQo+ID4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgICB8IDUgKysrLS0NCj4gPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ZlcmxheS5jIHwgMSArDQo+ID4gIDQgZmlsZXMgY2hh bmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkNCj4gPiANCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtLmMNCj4gPiBpbmRleCBhNWJkMDczMzhiNDYuLmU0YzVhMWEyMmQ4YiAxMDA2 NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jDQo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYw0KPiA+IEBAIC00MDcxLDkgKzQwNzEsMTAg QEAgaW50IGk5MTVfZ2VtX3NldF9jYWNoaW5nX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHZvaWQgKmRhdGEsDQo+ID4gIH0NCj4gPiAgDQo+ID4gIC8qDQo+ID4gLSAqIFByZXBhcmUgYnVm ZmVyIGZvciBkaXNwbGF5IHBsYW5lIChzY2Fub3V0LCBjdXJzb3JzLCBldGMpLg0KPiA+IC0gKiBD YW4gYmUgY2FsbGVkIGZyb20gYW4gdW5pbnRlcnJ1cHRpYmxlIHBoYXNlIChtb2Rlc2V0dGluZykg YW5kIGFsbG93cw0KPiA+IC0gKiBhbnkgZmx1c2hlcyB0byBiZSBwaXBlbGluZWQgKGZvciBwYWdl ZmxpcHMpLg0KPiA+ICsgKiBQcmVwYXJlIGJ1ZmZlciBmb3IgZGlzcGxheSBwbGFuZSAoc2Nhbm91 dCwgY3Vyc29ycywgZXRjKS4gQ2FuIGJlIGNhbGxlZCBmcm9tDQo+ID4gKyAqIGFuIHVuaW50ZXJy dXB0aWJsZSBwaGFzZSAobW9kZXNldHRpbmcpIGFuZCBhbGxvd3MgYW55IGZsdXNoZXMgdG8gYmUg cGlwZWxpbmVkDQo+ID4gKyAqIChmb3IgcGFnZWZsaXBzKS4gV2Ugb25seSBmbHVzaCB0aGUgY2Fj aGVzIHdoaWxlIHByZXBhcmluZyB0aGUgYnVmZmVyIGZvcg0KPiA+ICsgKiBkaXNwbGF5LCB0aGUg Y2FsbGVycyBhcmUgcmVzcG9uc2libGUgZm9yIGZyb250YnVmZmVyIGZsdXNoLg0KPiA+ICAgKi8N Cj4gPiAgc3RydWN0IGk5MTVfdm1hICoNCj4gPiAgaTkxNV9nZW1fb2JqZWN0X3Bpbl90b19kaXNw bGF5X3BsYW5lKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosDQo+ID4gQEAgLTQxMjks OSArNDEzMCw3IEBAIGk5MTVfZ2VtX29iamVjdF9waW5fdG9fZGlzcGxheV9wbGFuZShzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLA0KPiA+ICANCj4gPiAgCXZtYS0+ZGlzcGxheV9hbGln bm1lbnQgPSBtYXhfdCh1NjQsIHZtYS0+ZGlzcGxheV9hbGlnbm1lbnQsIGFsaWdubWVudCk7DQo+ ID4gIA0KPiA+IC0JLyogVHJlYXQgdGhpcyBhcyBhbiBlbmQtb2YtZnJhbWUsIGxpa2UgaW50ZWxf dXNlcl9mcmFtZWJ1ZmZlcl9kaXJ0eSgpICovDQo+IA0KPiBBbHRob3VnaCBmbHVzaCBieSBzb21l IGRlZmluaXRpb24gaGVyZSBpcyBpbnZhbGlkYXRlICsgZmx1c2gNCj4gSSBzZWUgZmx1c2ggb3Bl cmF0aW9ucyBhcyB0aGUgb3BlcmF0aW9uIHRvIGJlIHBlcmZvcm1lZCBhdCB0aGUgImVuZC1vZi1m cmFtZSIuDQo+IEFmdGVyIHRoZSBvcGVyYXRpb24gd2FzIGRvbmUgYW5kIHdoYXRldmVyIGhhZCB0 byBiZSBtb2RpZmllZCB3YXMgbW9kaWZpZWQuDQo+IA0KPiBJIHNlZSB5b3UgcGF0Y2ggY2hhbmdp bmcgdGhlIGZsdXNoIHRvIHRoZSBjcmVhdGlvbiBhbmQgYmVnaW4gb2YgdGhlIGZiIGhhbmRsaW5n DQo+IGxpa2Ugb24gY3JlYXRpbmcgYW5kIGluaXQgZmIgZnVuY3Rpb25zLiBJIGJlbGlldmUgYnkg dGhhdCB0aW1lIHdlIGFyZSBub3QgcmVhZHkNCj4gdG8gZXhpdCBQU1IgeWV0Lg0KPiANCj4gV2hh dCBhbSBJIG1pc3Npbmc/DQoNCg0KVGhlIGZ1bmN0aW9ucyB0aGF0IHlvdSBhcmUgcmVmZXJyaW5n IHRvIGNhbGwNCmk5MTVfZ2VtX29iamVjdF9waW5fdG9fZGlzcGxheV9wbGFuZSgpIHdoaWNoIGlu IHR1cm4gY2FsbHMgZnJvbnRidWZmZXINCmZsdXNoLiBUaGlzIHBhdGNoIGlzIGp1c3QgYSByZWZh Y3RvciwgZG9lc24ndCBjaGFuZ2Ugd2hldGhlciBmbHVzaCgpIGlzDQpjYWxsZWQuIEkgYW0gdHJ5 aW5nIHRvIG1vdmUgaXQgdXAgdGhlIGNhbGwgc3RhY2sgc28gdGhhdCBmbHVzaCgpIGNhbiBiZQ0K c2VsZWN0aXZlbHkgcmVtb3ZlZCBkZXBlbmRpbmcgb24gdGhlIGNhbGwgc2l0ZS4NCg0KDQoNCg0K PiANCj4gPiAgCV9faTkxNV9nZW1fb2JqZWN0X2ZsdXNoX2Zvcl9kaXNwbGF5KG9iaik7DQo+ID4g LQlpbnRlbF9mYl9vYmpfZmx1c2gob2JqLCBPUklHSU5fRElSVFlGQik7DQo+ID4gIA0KPiA+ICAJ LyogSXQgc2hvdWxkIG5vdyBiZSBvdXQgb2YgYW55IG90aGVyIHdyaXRlIGRvbWFpbnMsIGFuZCB3 ZSBjYW4gdXBkYXRlDQo+ID4gIAkgKiB0aGUgZG9tYWluIHZhbHVlcyBmb3Igb3VyIGNoYW5nZXMu DQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYw0KPiA+IGluZGV4IDMzMTA4NDA4 MjU0NS4uOTFjZThhMDUyMmEzIDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYw0KPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYw0KPiA+IEBAIC0yODU4LDYgKzI4NTgsOSBAQCBpbnRlbF9maW5kX2luaXRpYWxfcGxh bmVfb2JqKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLA0KPiA+ICAJCXJldHVybjsNCj4g PiAgCX0NCj4gPiAgDQo+ID4gKwlvYmogPSBpbnRlbF9mYl9vYmooZmIpOw0KPiA+ICsJaW50ZWxf ZmJfb2JqX2ZsdXNoKG9iaiwgT1JJR0lOX0RJUlRZRkIpOw0KPiA+ICsNCj4gPiAgCXBsYW5lX3N0 YXRlLT5zcmNfeCA9IDA7DQo+ID4gIAlwbGFuZV9zdGF0ZS0+c3JjX3kgPSAwOw0KPiA+ICAJcGxh bmVfc3RhdGUtPnNyY193ID0gZmItPndpZHRoIDw8IDE2Ow0KPiA+IEBAIC0yODcxLDcgKzI4NzQs NiBAQCBpbnRlbF9maW5kX2luaXRpYWxfcGxhbmVfb2JqKHN0cnVjdCBpbnRlbF9jcnRjICppbnRl bF9jcnRjLA0KPiA+ICAJaW50ZWxfc3RhdGUtPmJhc2Uuc3JjID0gZHJtX3BsYW5lX3N0YXRlX3Ny YyhwbGFuZV9zdGF0ZSk7DQo+ID4gIAlpbnRlbF9zdGF0ZS0+YmFzZS5kc3QgPSBkcm1fcGxhbmVf c3RhdGVfZGVzdChwbGFuZV9zdGF0ZSk7DQo+ID4gIA0KPiA+IC0Jb2JqID0gaW50ZWxfZmJfb2Jq KGZiKTsNCj4gPiAgCWlmIChpOTE1X2dlbV9vYmplY3RfaXNfdGlsZWQob2JqKSkNCj4gPiAgCQlk ZXZfcHJpdi0+cHJlc2VydmVfYmlvc19zd2l6emxlID0gdHJ1ZTsNCj4gPiAgDQo+ID4gQEAgLTEy Nzg1LDYgKzEyNzg3LDggQEAgaW50ZWxfcHJlcGFyZV9wbGFuZV9mYihzdHJ1Y3QgZHJtX3BsYW5l ICpwbGFuZSwNCj4gPiAgCWlmIChyZXQpDQo+ID4gIAkJcmV0dXJuIHJldDsNCj4gPiAgDQo+ID4g KwlpbnRlbF9mYl9vYmpfZmx1c2gob2JqLCBPUklHSU5fRElSVFlGQik7DQo+ID4gKw0KPiA+ICAJ aWYgKCFuZXdfc3RhdGUtPmZlbmNlKSB7IC8qIGltcGxpY2l0IGZlbmNpbmcgKi8NCj4gPiAgCQlz dHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZTsNCj4gPiAgDQo+ID4gQEAgLTEzMTcyLDggKzEzMTc2LDkg QEAgaW50ZWxfbGVnYWN5X2N1cnNvcl91cGRhdGUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsDQo+ ID4gIAlpZiAocmV0KQ0KPiA+ICAJCWdvdG8gb3V0X3VubG9jazsNCj4gPiAgDQo+ID4gLQlvbGRf ZmIgPSBvbGRfcGxhbmVfc3RhdGUtPmZiOw0KPiA+ICsJaW50ZWxfZmJfb2JqX2ZsdXNoKGludGVs X2ZiX29iaihmYiksIE9SSUdJTl9ESVJUWUZCKTsNCj4gPiAgDQo+ID4gKwlvbGRfZmIgPSBvbGRf cGxhbmVfc3RhdGUtPmZiOw0KPiA+ICAJaTkxNV9nZW1fdHJhY2tfZmIoaW50ZWxfZmJfb2JqKG9s ZF9mYiksIGludGVsX2ZiX29iaihmYiksDQo+ID4gIAkJCSAgaW50ZWxfcGxhbmUtPmZyb250YnVm ZmVyX2JpdCk7DQo+ID4gIA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9mYmRldi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYw0KPiA+IGlu ZGV4IDZmMTJhZGMwNjM2NS4uNjVhMzMxMzcyM2M5IDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMNCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9mYmRldi5jDQo+ID4gQEAgLTIyMSw2ICsyMjEsOSBAQCBzdGF0aWMgaW50IGludGVs ZmJfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsDQo+ID4gIAkJZ290byBvdXRf dW5sb2NrOw0KPiA+ICAJfQ0KPiA+ICANCj4gPiArCWZiID0gJmlmYmRldi0+ZmItPmJhc2U7DQo+ ID4gKwlpbnRlbF9mYl9vYmpfZmx1c2goaW50ZWxfZmJfb2JqKGZiKSwgT1JJR0lOX0RJUlRZRkIp Ow0KPiA+ICsNCj4gPiAgCWluZm8gPSBkcm1fZmJfaGVscGVyX2FsbG9jX2ZiaShoZWxwZXIpOw0K PiA+ICAJaWYgKElTX0VSUihpbmZvKSkgew0KPiA+ICAJCURSTV9FUlJPUigiRmFpbGVkIHRvIGFs bG9jYXRlIGZiX2luZm9cbiIpOw0KPiA+IEBAIC0yMzAsOCArMjMzLDYgQEAgc3RhdGljIGludCBp bnRlbGZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLA0KPiA+ICANCj4gPiAg CWluZm8tPnBhciA9IGhlbHBlcjsNCj4gPiAgDQo+ID4gLQlmYiA9ICZpZmJkZXYtPmZiLT5iYXNl Ow0KPiA+IC0NCj4gPiAgCWlmYmRldi0+aGVscGVyLmZiID0gZmI7DQo+ID4gIA0KPiA+ICAJc3Ry Y3B5KGluZm8tPmZpeC5pZCwgImludGVsZHJtZmIiKTsNCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ZlcmxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfb3ZlcmxheS5jDQo+ID4gaW5kZXggMzY2NzFhOTM3ZmE0Li5jMmYxMGQ4OTkzMjkgMTAwNjQ0 DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ZlcmxheS5jDQo+ID4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ZlcmxheS5jDQo+ID4gQEAgLTgwNyw2ICs4 MDcsNyBAQCBzdGF0aWMgaW50IGludGVsX292ZXJsYXlfZG9fcHV0X2ltYWdlKHN0cnVjdCBpbnRl bF9vdmVybGF5ICpvdmVybGF5LA0KPiA+ICAJCXJldCA9IFBUUl9FUlIodm1hKTsNCj4gPiAgCQln b3RvIG91dF9waW5fc2VjdGlvbjsNCj4gPiAgCX0NCj4gPiArCWludGVsX2ZiX29ial9mbHVzaChu ZXdfYm8sIE9SSUdJTl9ESVJUWUZCKTsNCj4gPiAgDQo+ID4gIAlyZXQgPSBpOTE1X3ZtYV9wdXRf ZmVuY2Uodm1hKTsNCj4gPiAgCWlmIChyZXQpDQo+ID4gLS0gDQo+ID4gMi4xNC4xDQo+ID4gDQo+ ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCj4gPiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0DQo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zw0KPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK