From: Philipp Zabel Subject: Re: [PATCH] [v3] gpu: ipu-v3: prg: avoid possible array underflow Date: Thu, 15 Mar 2018 17:53:09 +0100 Message-ID: <1521132789.4624.4.camel@pengutronix.de> References: <20180315162011.807909-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id A386F6E947 for ; Thu, 15 Mar 2018 16:53:12 +0000 (UTC) In-Reply-To: <20180315162011.807909-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: Tobias Jordan , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgQXJuZCwKCk9uIFRodSwgMjAxOC0wMy0xNSBhdCAxNzoxOSArMDEwMCwgQXJuZCBCZXJnbWFu biB3cm90ZToKPiBnY2MtOCByZXBvcnRzIHRoYXQgd2UgYWNjZXNzIGFuIGFycmF5IHdpdGggYSBu ZWdhdGl2ZSBpbmRleAo+IGluIGFuIGVycm9yIGNhc2U6Cj4gCj4gZHJpdmVycy9ncHUvaXB1LXYz L2lwdS1wcmcuYzogSW4gZnVuY3Rpb24gJ2lwdV9wcmdfY2hhbm5lbF9kaXNhYmxlJzoKPiBkcml2 ZXJzL2dwdS9pcHUtdjMvaXB1LXByZy5jOjI1Mjo0MzogZXJyb3I6IGFycmF5IHN1YnNjcmlwdCAt MjIgaXMgYmVsb3cgYXJyYXkgYm91bmRzIG9mICdzdHJ1Y3QgaXB1X3ByZ19jaGFubmVsWzNdJyBb LVdlcnJvcj1hcnJheS1ib3VuZHNdCj4gCj4gVGhpcyBtb3ZlcyB0aGUgcmFuZ2UgY2hlY2sgaW4g ZnJvbnQgb2YgdGhlIGZpcnN0IHRpbWUgdGhhdAo+IHZhcmlhYmxlIGdldHMgdXNlZC4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgoKdGhhbmsgeW91LCBJ J3ZlIHJlcGxhY2VkIHYyIHdpdGggdGhpcyB2ZXJzaW9uIGluIGlteC1kcm0vZml4ZXMuCgpyZWdh cmRzClBoaWxpcHAKCj4gLS0tLQo+IHYxOiBPcmlnaW5hbGx5IHNlbnQgb24gRGVjIDQsIDIwMTcu Cj4gdjI6IFNlbnQgYWdhaW4gb24gSmFuIDE2LCBhZnRlciBubyByZXBseSwgUGhpbGxpcHAgc2Fp ZCBpdCB3YXMgbWVyZ2VkCj4gdjM6IFJhbiBpbnRvIGEgcmVsYXRlZCBwcm9ibGVtIHdpdGggQ09O RklHX1VCU0FOLCBzZW50IGFnYWluIGZpeGluZyBib3RoCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2lw dS12My9pcHUtcHJnLmMgfCAxMiArKysrKysrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv aXB1LXYzL2lwdS1wcmcuYyBiL2RyaXZlcnMvZ3B1L2lwdS12My9pcHUtcHJnLmMKPiBpbmRleCA5 N2I5OTUwMDE1M2QuLjgzZjlkZDkzNGE1ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9pcHUt djMvaXB1LXByZy5jCj4gKysrIGIvZHJpdmVycy9ncHUvaXB1LXYzL2lwdS1wcmcuYwo+IEBAIC0y NTAsMTAgKzI1MCwxNCBAQCB2b2lkIGlwdV9wcmdfY2hhbm5lbF9kaXNhYmxlKHN0cnVjdCBpcHV2 M19jaGFubmVsICppcHVfY2hhbikKPiAgewo+ICAJaW50IHByZ19jaGFuID0gaXB1X3ByZ19pcHVf dG9fcHJnX2NoYW4oaXB1X2NoYW4tPm51bSk7Cj4gIAlzdHJ1Y3QgaXB1X3ByZyAqcHJnID0gaXB1 X2NoYW4tPmlwdS0+cHJnX3ByaXY7Cj4gLQlzdHJ1Y3QgaXB1X3ByZ19jaGFubmVsICpjaGFuID0g JnByZy0+Y2hhbltwcmdfY2hhbl07Cj4gKwlzdHJ1Y3QgaXB1X3ByZ19jaGFubmVsICpjaGFuOwo+ ICAJdTMyIHZhbDsKPiAgCj4gLQlpZiAoIWNoYW4tPmVuYWJsZWQgfHwgcHJnX2NoYW4gPCAwKQo+ ICsJaWYgKHByZ19jaGFuIDwgMCkKPiArCQlyZXR1cm47Cj4gKwo+ICsJY2hhbiA9ICZwcmctPmNo YW5bcHJnX2NoYW5dOwo+ICsJaWYgKCFjaGFuLT5lbmFibGVkKQo+ICAJCXJldHVybjsKPiAgCj4g IAlwbV9ydW50aW1lX2dldF9zeW5jKHByZy0+ZGV2KTsKPiBAQCAtMjgwLDEzICsyODQsMTUgQEAg aW50IGlwdV9wcmdfY2hhbm5lbF9jb25maWd1cmUoc3RydWN0IGlwdXYzX2NoYW5uZWwgKmlwdV9j aGFuLAo+ICB7Cj4gIAlpbnQgcHJnX2NoYW4gPSBpcHVfcHJnX2lwdV90b19wcmdfY2hhbihpcHVf Y2hhbi0+bnVtKTsKPiAgCXN0cnVjdCBpcHVfcHJnICpwcmcgPSBpcHVfY2hhbi0+aXB1LT5wcmdf cHJpdjsKPiAtCXN0cnVjdCBpcHVfcHJnX2NoYW5uZWwgKmNoYW4gPSAmcHJnLT5jaGFuW3ByZ19j aGFuXTsKPiArCXN0cnVjdCBpcHVfcHJnX2NoYW5uZWwgKmNoYW47Cj4gIAl1MzIgdmFsOwo+ICAJ aW50IHJldDsKPiAgCj4gIAlpZiAocHJnX2NoYW4gPCAwKQo+ICAJCXJldHVybiBwcmdfY2hhbjsK PiAgCj4gKwljaGFuID0gJnByZy0+Y2hhbltwcmdfY2hhbl07Cj4gKwo+ICAJaWYgKGNoYW4tPmVu YWJsZWQpIHsKPiAgCQlpcHVfcHJlX3VwZGF0ZShwcmctPnByZXNbY2hhbi0+dXNlZF9wcmVdLCAq ZWJhKTsKPiAgCQlyZXR1cm4gMDsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==