From: "Pandiyan, Dhinakaran" Subject: Re: [PATCH v2 2/5] drm/i915/psr: Tie PSR2 support to Y coordinate requirement in intel_psr_init_dpcd() Date: Sat, 17 Mar 2018 00:17:54 +0000 Message-ID: <1521247318.28442.58.camel@dk-H97M-D3H> References: <20180316230501.974-1-jose.souza@intel.com> <20180316230501.974-2-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81A2A6EC1E for ; Sat, 17 Mar 2018 00:17:56 +0000 (UTC) In-Reply-To: <20180316230501.974-2-jose.souza@intel.com> Content-Language: en-US Content-ID: <394467FA676D564292D7CDAE1491C930@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Souza, Jose" Cc: "intel-gfx@lists.freedesktop.org" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org DQoNCg0KT24gRnJpLCAyMDE4LTAzLTE2IGF0IDE2OjA0IC0wNzAwLCBKb3PDqSBSb2JlcnRvIGRl IFNvdXphIHdyb3RlOg0KPiBNb3ZlIHRvIG9ubHkgb25lIHBsYWNlIHRoZSBzaW5rIHJlcXVpcmVt ZW50cyB0aGF0IHRoZSBhY3R1YWwgZHJpdmVyDQo+IG5lZWRzIHRvIGVuYWJsZSBQU1IyLg0KPiAN Cj4gQWxzbyBpbnRlbF9wc3IyX2NvbmZpZ192YWxpZCgpIGlzIGNhbGxlZCBldmVyeSB0aW1lIHRo ZSBjcnRjIGNvbmZpZw0KPiBpcyBjb21wdXRlZCwgd2FzdGluZyBzb21lIHRpbWUgZXZlcnkgdGlt ZSBpdCB3YXMgY2hlY2tpbmcgZm9yDQo+IFkgY29vcmRpbmF0ZSByZXF1aXJlbWVudC4NCj4gDQo+ IFRoaXMgYWxsb3cgdXMgdG8gbnVrZSB5X2NvcmRfc3VwcG9ydCBhbmQgc29tZSBvZiBWU0Mgc2V0 dXAgY29kZSB0aGF0DQo+IHdhcyBoYW5kbGluZyBhIHNjZW5hcmlvIHRoYXQgd291bGQgbmV2ZXIg aGFwcGVuKFBTUjIgd2l0aG91dCBZDQo+IGNvb3JkaW5hdGUpLg0KPiANCj4gQ2M6IERoaW5ha2Fy YW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPg0KPiBDYzogUm9kcmln byBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKb3PDqSBS b2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4NCj4gLS0tDQo+IA0KPiB2Mjog Q2hhbmdlcyBpbiBjb21tZW50IHJlcXVlc3RlZCBieSBSb2RyaWdvIFZpdmkNCj4gDQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICB8ICAxIC0NCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3Bzci5jIHwgNTYgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLQ0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAyOCBkZWxldGlvbnMo LSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaA0KPiBpbmRleCA4YTU4NDI3M2Y4OTcuLmQ0 YmM4ZDE4ZjU2YyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aA0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oDQo+IEBAIC02MDMsNyAr NjAzLDYgQEAgc3RydWN0IGk5MTVfcHNyIHsNCj4gIAl1bnNpZ25lZCBidXN5X2Zyb250YnVmZmVy X2JpdHM7DQo+ICAJYm9vbCBwc3IyX3N1cHBvcnQ7DQo+ICAJYm9vbCBsaW5rX3N0YW5kYnk7DQo+ IC0JYm9vbCB5X2NvcmRfc3VwcG9ydDsNCj4gIAlib29sIGNvbG9yaW1ldHJ5X3N1cHBvcnQ7DQo+ ICAJYm9vbCBhbHBtOw0KPiAgCWJvb2wgaGFzX2h3X3RyYWNraW5nOw0KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9wc3IuYw0KPiBpbmRleCA5ODExZjVmMGJjNzUuLjU1OTNkMWYzMDQ5YSAxMDA2NDQNCj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMNCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMNCj4gQEAgLTkzLDcgKzkzLDcgQEAgc3RhdGljIHZvaWQg cHNyX2F1eF9pb19wb3dlcl9wdXQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkNCj4gIAlpbnRl bF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgcHNyX2F1eF9kb21haW4oaW50ZWxfZHApKTsN Cj4gIH0NCj4gIA0KPiAtc3RhdGljIGJvb2wgaW50ZWxfZHBfZ2V0X3lfY29yZF9zdGF0dXMoc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCkNCj4gK3N0YXRpYyBib29sIGludGVsX2RwX2dldF95X2Nv b3JkX3JlcXVpcmVkKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApDQo+ICB7DQo+ICAJdWludDhf dCBwc3JfY2FwcyA9IDA7DQo+ICANCj4gQEAgLTEzNywyMiArMTM3LDM5IEBAIHZvaWQgaW50ZWxf cHNyX2luaXRfZHBjZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQ0KPiAgDQo+ICAJaWYgKElO VEVMX0dFTihkZXZfcHJpdikgPj0gOSAmJg0KPiAgCSAgICAoaW50ZWxfZHAtPnBzcl9kcGNkWzBd ICYgRFBfUFNSMl9JU19TVVBQT1JURUQpKSB7DQo+IC0JCXVpbnQ4X3QgZnJhbWVfc3luY19jYXA7 DQo+ICsJCXVpbnQ4X3QgZnJhbWVfc3luY19jYXAsIHlfY29vcmRfcmVxOw0KPiAgDQo+ICAJCWRl dl9wcml2LT5wc3Iuc2lua19zdXBwb3J0ID0gdHJ1ZTsNCj4gKw0KPiArCQkvKiBQU1IyIG5lZWRz IGZyYW1lIHN5bmMgdG8gZG8gc2VsZWN0aXZlIHVwZGF0ZXMgKi8NCj4gIAkJaWYgKGRybV9kcF9k cGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LA0KPiAgCQkJCSAgICAgIERQX1NJTktfREVWSUNFX0FV WF9GUkFNRV9TWU5DX0NBUCwNCj4gIAkJCQkgICAgICAmZnJhbWVfc3luY19jYXApICE9IDEpDQo+ ICAJCQlmcmFtZV9zeW5jX2NhcCA9IDA7DQo+ICAJCWZyYW1lX3N5bmNfY2FwID0gKGZyYW1lX3N5 bmNfY2FwICYgRFBfQVVYX0ZSQU1FX1NZTkNfQ0FQKTsNCj4gLQkJLyogUFNSMiBuZWVkcyBmcmFt ZSBzeW5jIGFzIHdlbGwgKi8NCj4gLQkJZGV2X3ByaXYtPnBzci5wc3IyX3N1cHBvcnQgPSBmcmFt ZV9zeW5jX2NhcDsNCj4gLQkJRFJNX0RFQlVHX0tNUygiUFNSMiAlcyBvbiBzaW5rIiwNCj4gLQkJ CSAgICAgIGRldl9wcml2LT5wc3IucHNyMl9zdXBwb3J0ID8gInN1cHBvcnRlZCIgOiAibm90IHN1 cHBvcnRlZCIpOw0KPiArDQo+ICsJCS8qDQo+ICsJCSAqIEFsbCBwYW5lbHMgdGhhdCBzdXBwb3J0 cyBQU1IgdmVyc2lvbiAwM2ggKFBTUjIgKw0KPiArCQkgKiBZLWNvb3JkaW5hdGUpIA0KDQpuaXQ6 IFBlcmhhcHMgY2hlY2sgZm9yIFBTUiB2ZXJzaW9uIDAzaCBhcyBhIG1pbmltdW0gcmVxdWlyZW1l bnQgZm9yDQpQU1IyLCBhIGJpdCByZWR1bmRhbnQgYnV0IGlzIHVzZWZ1bCBkb2N1bWVudGF0aW9u IGluIGNvZGUuDQoNCg0KDQo+IHN1cHBvcnQgY2FuIGhhbmRsZSBZLWNvb3JkaW5hdGVzIGluIFZT Qw0KPiArCQkgKiBidXQgd2UgYXJlIG9ubHkgc3VyZSB0aGF0IGl0IGlzIGdvaW5nIHRvIGJlIHVz ZWQgd2hlbg0KPiArCQkgKiByZXF1aXJlZCBieSB0aGUgcGFuZWwuIFRoaXMgd2F5IHBhbmVsIGlz IGNhcGFibGUgdG8gZG8NCj4gKwkJICogc2VsZWN0aXZlIHVwZGF0ZSBldmVuIHdpdGhvdXQgYSB2 YWxpZCBhdXggZnJhbWUgc3luYy4NCj4gKwkJICoNCj4gKwkJICogVG8gc3VwcG9ydCBQU1IgdmVy c2lvbiAwMmggYW5kIFBTUiB2ZXJzaW9uIDAzaCB3aXRob3V0DQo+ICsJCSAqIFktY29vcmRpbmF0 ZSByZXF1aXJlbWVudCBwYW5lbHMgd2Ugd291bGQgbmVlZCB0byBlbmFibGUNCj4gKwkJICogR1RD IGZpcnN0Lg0KPiArCQkgKi8NCj4gKwkJeV9jb29yZF9yZXEgPSBpbnRlbF9kcF9nZXRfeV9jb29y ZF9yZXF1aXJlZChpbnRlbF9kcCk7DQo+ICsNCj4gKwkJZGV2X3ByaXYtPnBzci5wc3IyX3N1cHBv cnQgPSBmcmFtZV9zeW5jX2NhcCAmJiB5X2Nvb3JkX3JlcTsNCj4gKwkJaWYgKGRldl9wcml2LT5w c3IucHNyMl9zdXBwb3J0KQ0KPiArCQkJRFJNX0RFQlVHX0tNUygiUFNSMiBzdXBwb3J0ZWQgb24g c2lua1xuIik7DQo+ICsJCWVsc2UNCj4gKwkJCURSTV9ERUJVR19LTVMoIlBTUjIgbm90IHN1cHBv cnRlZCBvbiBzaW5rIg0KPiArCQkJCSAgICAgICIoZnJhbWUgc3luYzogJWQgWS1jb29yZCByZXF1 aXJlZDogJWQpXG4iLA0KPiArCQkJCSAgICAgIGZyYW1lX3N5bmNfY2FwLCB5X2Nvb3JkX3JlcSk7 DQo+ICANCj4gIAkJaWYgKGRldl9wcml2LT5wc3IucHNyMl9zdXBwb3J0KSB7DQo+IC0JCQlkZXZf cHJpdi0+cHNyLnlfY29yZF9zdXBwb3J0ID0NCj4gLQkJCQlpbnRlbF9kcF9nZXRfeV9jb3JkX3N0 YXR1cyhpbnRlbF9kcCk7DQo+ICAJCQlkZXZfcHJpdi0+cHNyLmNvbG9yaW1ldHJ5X3N1cHBvcnQg PQ0KPiAgCQkJCWludGVsX2RwX2dldF9jb2xvcmltZXRyeV9zdGF0dXMoaW50ZWxfZHApOw0KPiAg CQkJZGV2X3ByaXYtPnBzci5hbHBtID0NCj4gQEAgLTE5OCwxNiArMjE1LDEyIEBAIHN0YXRpYyB2 b2lkIGhzd19wc3Jfc2V0dXBfdnNjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsDQo+ICAJCW1l bXNldCgmcHNyX3ZzYywgMCwgc2l6ZW9mKHBzcl92c2MpKTsNCj4gIAkJcHNyX3ZzYy5zZHBfaGVh ZGVyLkhCMCA9IDA7DQo+ICAJCXBzcl92c2Muc2RwX2hlYWRlci5IQjEgPSAweDc7DQo+IC0JCWlm IChkZXZfcHJpdi0+cHNyLmNvbG9yaW1ldHJ5X3N1cHBvcnQgJiYNCj4gLQkJICAgIGRldl9wcml2 LT5wc3IueV9jb3JkX3N1cHBvcnQpIHsNCj4gKwkJaWYgKGRldl9wcml2LT5wc3IuY29sb3JpbWV0 cnlfc3VwcG9ydCkgew0KPiAgCQkJcHNyX3ZzYy5zZHBfaGVhZGVyLkhCMiA9IDB4NTsNCj4gIAkJ CXBzcl92c2Muc2RwX2hlYWRlci5IQjMgPSAweDEzOw0KPiAtCQl9IGVsc2UgaWYgKGRldl9wcml2 LT5wc3IueV9jb3JkX3N1cHBvcnQpIHsNCj4gKwkJfSBlbHNlIHsNCj4gIAkJCXBzcl92c2Muc2Rw X2hlYWRlci5IQjIgPSAweDQ7DQo+ICAJCQlwc3JfdnNjLnNkcF9oZWFkZXIuSEIzID0gMHhlOw0K PiAtCQl9IGVsc2Ugew0KPiAtCQkJcHNyX3ZzYy5zZHBfaGVhZGVyLkhCMiA9IDB4MzsNCj4gLQkJ CXBzcl92c2Muc2RwX2hlYWRlci5IQjMgPSAweGM7DQo+ICAJCX0NCj4gIAl9IGVsc2Ugew0KPiAg CQkvKiBQcmVwYXJlIFZTQyBwYWNrZXQgYXMgcGVyIEVEUCAxLjMgc3BlYywgVGFibGUgMy4xMCAq Lw0KPiBAQCAtNDc4LDE1ICs0OTEsNiBAQCBzdGF0aWMgYm9vbCBpbnRlbF9wc3IyX2NvbmZpZ192 YWxpZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLA0KPiAgCQlyZXR1cm4gZmFsc2U7DQo+ICAJ fQ0KPiAgDQo+IC0JLyoNCj4gLQkgKiBGSVhNRTplbmFibGUgcHNyMiBvbmx5IGZvciB5LWNvcmRp bmF0ZSBwc3IyIHBhbmVscw0KPiAtCSAqIEFmdGVyIGd0YyBpbXBsZW1lbnRhdGlvbiAsIHJlbW92 ZSB0aGlzIHJlc3RyaWN0aW9uLg0KPiAtCSAqLw0KPiAtCWlmICghZGV2X3ByaXYtPnBzci55X2Nv cmRfc3VwcG9ydCkgew0KPiAtCQlEUk1fREVCVUdfS01TKCJQU1IyIG5vdCBlbmFibGVkLCBwYW5l bCBkb2VzIG5vdCBzdXBwb3J0IFkgY29vcmRpbmF0ZVxuIik7DQo+IC0JCXJldHVybiBmYWxzZTsN Cj4gLQl9DQo+IC0NCj4gIAlyZXR1cm4gdHJ1ZTsNCj4gIH0NCj4gIA0KPiBAQCAtNTg2LDE0ICs1 OTAsMTIgQEAgc3RhdGljIHZvaWQgaHN3X3Bzcl9lbmFibGVfc291cmNlKHN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHAsDQo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGRpZ19wb3J0LT5iYXNl LmJhc2UuZGV2Ow0KPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5 MTUoZGV2KTsNCj4gIAllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXIgPSBjcnRjX3N0YXRl LT5jcHVfdHJhbnNjb2RlcjsNCj4gLQl1MzIgY2hpY2tlbjsNCj4gIA0KPiAgCXBzcl9hdXhfaW9f cG93ZXJfZ2V0KGludGVsX2RwKTsNCj4gIA0KPiAgCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfc3Vw cG9ydCkgew0KPiAtCQljaGlja2VuID0gUFNSMl9WU0NfRU5BQkxFX1BST0dfSEVBREVSOw0KPiAt CQlpZiAoZGV2X3ByaXYtPnBzci55X2NvcmRfc3VwcG9ydCkNCj4gLQkJCWNoaWNrZW4gfD0gUFNS Ml9BRERfVkVSVElDQUxfTElORV9DT1VOVDsNCj4gKwkJdTMyIGNoaWNrZW4gPSBQU1IyX1ZTQ19F TkFCTEVfUFJPR19IRUFERVINCj4gKwkJCSAgICAgIHwgUFNSMl9BRERfVkVSVElDQUxfTElORV9D T1VOVDsNCj4gIAkJSTkxNV9XUklURShDSElDS0VOX1RSQU5TKGNwdV90cmFuc2NvZGVyKSwgY2hp Y2tlbik7DQo+ICANCj4gIAkJSTkxNV9XUklURShFRFBfUFNSX0RFQlVHLA0KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==