From: Dhinakaran Pandiyan Subject: Re: [RFC] drm/i915: Rework "Potential atomic update error" to handle PSR exit Date: Thu, 26 Apr 2018 10:47:40 -0700 Message-ID: <1524764860.28916.3.camel@dk-H97M-D3H> References: <20180426021009.178880-1-tarun.vyas@intel.com> <20180426134157.GL23723@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2474A6E036 for ; Thu, 26 Apr 2018 17:22:51 +0000 (UTC) In-Reply-To: <20180426134157.GL23723@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgoKT24gVGh1LCAyMDE4LTA0LTI2IGF0IDE2OjQxICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3Jv dGU6Cj4gT24gV2VkLCBBcHIgMjUsIDIwMTggYXQgMDc6MTA6MDlQTSAtMDcwMCwgdGFydW4udnlh c0BpbnRlbC5jb20gd3JvdGU6Cj4gPiBGcm9tOiBUYXJ1biA8dGFydW4udnlhc0BpbnRlbC5jb20+ Cj4gPiAKPiA+IFRoZSBEaXNwbGF5IHNjYW5saW5lIGNvdW50ZXIgZnJlZXplcyBvbiBQU1IgZW50 cnkuIEluc2lkZQo+ID4gaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQsIG9uY2UgVmJsYW5rIGludGVy cnVwdHMgYXJlIGVuYWJsZWQsIHdlIHN0YXJ0Cj4gPiBleGl0aW5nIFBTUiwgYnV0IGJ5IHRoZSB0 aW1lIHRoZSBzY2FubGluZSBjb3VudGVyIGlzIHJlYWQsIHdlIG1heSBub3QKPiA+IGhhdmUgY29t cGxldGVseSBleGl0ZWQgUFNSIHdoaWNoIGxlYWRzIHVzIHRvIHNjaGVkdWxlIG91dCBhbmQgY2hl Y2sgYmFjawo+ID4gbGF0ZXIuCj4gPiBPbiBDaHJvbWVPUy00LjQga2VybmVsLCB3aGljaCBpcyBm YWlybHkgdXAtdG8tZGF0ZSB3LnIudCBkcm0vaTkxNSBidXQKPiA+IGxhZ3Mgdy5yLnQgY29yZSBr ZXJuZWwgY29kZSwgaG90IHBsdWdnaW5nIGFuIGV4dGVybmFsIGRpc3BsYXkgdHJpZ2dlcnMKPiA+ IHRvbnMgb2YgInBvdGVudGlhbCBhdG9taWMgdXBkYXRlIGVycm9ycyIgaW4gdGhlIGRtZXNnLCBv biAqcGlwZSBBKi4gQQo+ID4gY2xvc2VyIGFuYWx5c2lzIHJldmVhbHMgdGhhdCB3ZSB0cnkgdG8g cmVhZCB0aGUgc2NhbmxpbmUgMyB0aW1lcyBhbmQKPiA+IGV2ZW50dWFsbHkgdGltZW91dCwgYi9j IFBTUiBoYXNuJ3QgZXhpdGVkIGZ1bGx5IGxlYWRpbmcgdG8gYSBQSVBFRFNMIHN0dWNrIEAKPiA+ IDE1OTkuCj4gPiBUaGlzIGlzc3VlIGlzIG5vdCBzZWVuIG9uIHVwc3RyZWFtIGtlcm5lbHMsIGIv YyBmb3IgKnNvbWUqIHJlYXNvbiB3ZQo+ID4gbG9vcCBpbnNpZGUgaW50ZWxfcGlwZV91cGRhdGUg c3RhcnQgZm9yIH4yKyBtc2VjIHdoaWNoIGluIHRoaXMgY2FzZSBpcwo+ID4gbW9yZSB0aGFuIGVu b3VnaCB0byBleGl0IFBTUiBmdWxseSwgaGVuY2UgYW4gKnVuc3R1Y2sqIFBJUEVEU0wgY291bnRl ciwKPiA+IGhlbmNlIG5vIGVycm9yLiBPbiB0aGUgb3RoZXIgaGFuZCwgdGhlIENocm9tZU9TIGtl cm5lbCBzcGVuZHMgfjEuMSBtc2VjCj4gPiBsb29waW5nIGluc2lkZSBpbnRlbF9waXBlX3VwZGF0 ZV9zdGFydCBhbmQgaGVuY2UgZXJyb3JzIG91dCBiL2MgdGhlCj4gPiBzb3VyY2UgaXMgc3RpbGwg aW4gUFNSLgo+ID4gCj4gPiBJZiBQU1IgaXMgZW5hYmxlZCwgdGhlbiB3ZSBzaG91bGQgKndhaXQq IGZvciAgdGhlIFBTUgo+ID4gc3RhdGUgdG8gbW92ZSB0byBJRExFIGJlZm9yZSByZS1yZWFkaW5n IHRoZSBQSVBFRFNMIHNvIGFzIHRvIGF2b2lkIGJvZ3VzCj4gPiBhbmQgYW5ub3lpbmcgInBvdGVu dGlhbCBhdG9taWMgdXBkYXRlIGVycm9yIiBtZXNzYWdlcy4KPiA+IAo+ID4gUC5TOiBUaGlzIHNj ZW5hcmlvIGFwcGxpZXMgdG8gYSBjb25maWd1cmF0aW9uIHdpdGggYW4gYWRkaXRpb25hbCBwaXBl LAo+ID4gYXMgb2Ygbm93Lgo+ID4gCgpWaWxsZSwgCgpBbnkgaWRlYSB3aGF0IGNvdWxkIGJlIHRo ZSByZWFzb24gdGhlIHdhcm5pbmdzIHN0YXJ0IGFwcGVhcmluZyB3aGVuIGFuCmV4dGVybmFsIGRp c3BsYXkgaXMgY29ubmVjdGVkPyBXZSBjb3VsZG4ndCBjb21lIHVwIHdpdGggYW4gZXhwbGFuYXRp b24uCgoKPiA+IFNpZ25lZC1vZmYtYnk6IFRhcnVuIDx0YXJ1bi52eWFzQGludGVsLmNvbT4KPiA+ IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jIHwgMTkgKysrKysr KysrKysrKysrLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA0IGRl bGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ID4gaW5k ZXggYWExZGZhYTY5MmI5Li43N2RkM2I5MzYxMzEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfc3ByaXRlLmMKPiA+IEBAIC05MiwxMSArOTIsMTMgQEAgdm9pZCBpbnRlbF9waXBlX3Vw ZGF0ZV9zdGFydChjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUp Cj4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+ YmFzZS5kZXYpOwo+ID4gIAljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqYWRqdXN0ZWRf bW9kZSA9ICZuZXdfY3J0Y19zdGF0ZS0+YmFzZS5hZGp1c3RlZF9tb2RlOwo+ID4gIAlsb25nIHRp bWVvdXQgPSBtc2Vjc190b19qaWZmaWVzX3RpbWVvdXQoMSk7Cj4gPiAtCWludCBzY2FubGluZSwg bWluLCBtYXgsIHZibGFua19zdGFydDsKPiA+ICsJaW50IHNjYW5saW5lLCBtaW4sIG1heCwgdmJs YW5rX3N0YXJ0LCBvbGRfc2NhbmxpbmUsIG5ld19zY2FubGluZTsKPiA+ICsJYm9vbCByZXRyaWVk ID0gZmFsc2U7Cj4gPiAgCXdhaXRfcXVldWVfaGVhZF90ICp3cSA9IGRybV9jcnRjX3ZibGFua193 YWl0cXVldWUoJmNydGMtPmJhc2UpOwo+ID4gIAlib29sIG5lZWRfdmx2X2RzaV93YSA9IChJU19W QUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkgJiYKPiA+ICAJ CWludGVsX2NydGNfaGFzX3R5cGUobmV3X2NydGNfc3RhdGUsIElOVEVMX09VVFBVVF9EU0kpOwo+ ID4gIAlERUZJTkVfV0FJVCh3YWl0KTsKPiA+ICsJb2xkX3NjYW5saW5lID0gbmV3X3NjYW5saW5l ID0gLTE7Cj4gPiAgCj4gPiAgCXZibGFua19zdGFydCA9IGFkanVzdGVkX21vZGUtPmNydGNfdmJs YW5rX3N0YXJ0Owo+ID4gIAlpZiAoYWRqdXN0ZWRfbW9kZS0+ZmxhZ3MgJiBEUk1fTU9ERV9GTEFH X0lOVEVSTEFDRSkKPiA+IEBAIC0xMjYsMTUgKzEyOCwyNCBAQCB2b2lkIGludGVsX3BpcGVfdXBk YXRlX3N0YXJ0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkK PiA+ICAJCSAqIHJlYWQgdGhlIHNjYW5saW5lLgo+ID4gIAkJICovCj4gPiAgCQlwcmVwYXJlX3Rv X3dhaXQod3EsICZ3YWl0LCBUQVNLX1VOSU5URVJSVVBUSUJMRSk7Cj4gPiAtCj4gPiArcmV0cnk6 Cj4gPiAgCQlzY2FubGluZSA9IGludGVsX2dldF9jcnRjX3NjYW5saW5lKGNydGMpOwo+ID4gKwkJ b2xkX3NjYW5saW5lID0gbmV3X3NjYW5saW5lLCBuZXdfc2NhbmxpbmUgPSBzY2FubGluZTsKPiA+ ICsKPiA+ICAJCWlmIChzY2FubGluZSA8IG1pbiB8fCBzY2FubGluZSA+IG1heCkKPiA+ICAJCQli cmVhazsKPiA+ICAKPiA+ICAJCWlmICh0aW1lb3V0IDw9IDApIHsKPiA+IC0JCQlEUk1fRVJST1Io IlBvdGVudGlhbCBhdG9taWMgdXBkYXRlIGZhaWx1cmUgb24gcGlwZSAlY1xuIiwKPiA+ICsJCQlp ZighaTkxNS5lbmFibGVfcHNyIHx8IHJldHJpZWQpIHsKCllvdSBjb3VsZCB1c2UgdGhlIENBTl9Q U1IoKSBtYWNybyB0aGF0IGNoZWNrcyBmb3Igc291cmNlIGFuZCBzaW5rCnN1cHBvcnQuCgo+ID4g KwkJCQlEUk1fRVJST1IoIlBvdGVudGlhbCBhdG9taWMgdXBkYXRlIGZhaWx1cmUgb24gcGlwZSAl Y1xuIiwKPiA+ICAJCQkJICBwaXBlX25hbWUoY3J0Yy0+cGlwZSkpOwo+ID4gLQkJCWJyZWFrOwo+ ID4gKwkJCQlicmVhazsKPiA+ICsJCQl9Cj4gPiArCQkJZWxzZSBpZihvbGRfc2NhbmxpbmUgPT0g bmV3X3NjYW5saW5lICYmICFyZXRyaWVkKSB7Cj4gPiArCQkJCXJldHJpZWQgPSB0cnVlOwo+ID4g KwkJCQlpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwgRURQX1BTUl9TVEFUVVNfQ1RM LCBFRFBfUFNSX1NUQVRVU19TVEFURV9NQVNLLCBFRFBfUFNSX1NUQVRVU19TVEFURV9JRExFLCAx MCk7Cj4gCj4gV2hhdCdzIHRoZSBwb2ludCBvZiBvYmZ1c2NhdGluZyB0aGUgbG9vcCB3aXRoIHRo aXMgc3R1ZmY/Cj4gSnVzdCB3YWl0IGZvciB0aGUgUFNSIGV4aXQgYmVmb3JlIHdlIGV2ZW4gZW50 ZXIgdGhlIGxvb3A/Cj4gCj4gPiArCQkJCWdvdG8gcmV0cnk7Cj4gPiArCQkJfQo+ID4gIAkJfQo+ ID4gIAo+ID4gIAkJbG9jYWxfaXJxX2VuYWJsZSgpOwo+ID4gLS0gCj4gPiAyLjEzLjUKPiA+IAo+ ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IElu dGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK