Return-Path: Received: from imap1.codethink.co.uk ([176.9.8.82]:51429 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbeEPUvv (ORCPT ); Wed, 16 May 2018 16:51:51 -0400 Message-ID: <1526503907.9159.150.camel@codethink.co.uk> Subject: Re: [PATCH 4.4 53/97] ALSA: pcm: Fix UAF at PCM release via PCM timer access From: Ben Hutchings To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, syzbot+8e62ff4e07aa2ce87826@syzkaller.appspotmail.com, Takashi Iwai Date: Wed, 16 May 2018 21:51:47 +0100 In-Reply-To: <20180422135308.244077643@linuxfoundation.org> References: <20180422135304.577223025@linuxfoundation.org> <20180422135308.244077643@linuxfoundation.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On Sun, 2018-04-22 at 15:53 +0200, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > ------------------ > > From: Takashi Iwai > > commit a820ccbe21e8ce8e86c39cd1d3bc8c7d1cbb949b upstream. > > The PCM runtime object is created and freed dynamically at PCM stream > open / close time.  This is tracked via substream->runtime, and it's > cleared at snd_pcm_detach_substream(). > > The runtime object assignment is protected by PCM open_mutex, so for > all PCM operations, it's safely handled.  However, each PCM substream > provides also an ALSA timer interface, and user-space can access to > this while closing a PCM substream.  This may eventually lead to a > UAF, as snd_pcm_timer_resolution() tries to access the runtime while > clearing it in other side. > > Fortunately, it's the only concurrent access from the PCM timer, and > it merely reads runtime->timer_resolution field.  So, we can avoid the > race by reordering kfree() and wrapping the substream->runtime > clearance with the corresponding timer lock. [...] This seems to depend on: commit f65e0d299807d8a11812845c972493c3f9a18e10 Author: Takashi Iwai Date:   Wed Feb 10 12:47:03 2016 +0100     ALSA: timer: Call notifier in the same spinlock (But I'm not totally convinced that snd_pcm_timer_resolution() is always called with the timer lock held, even after that.) Ben. -- Ben Hutchings Software Developer, Codethink Ltd.