Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UQF9S-00057Q-Bv for mharc-grub-devel@gnu.org; Thu, 11 Apr 2013 06:54:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQF9N-00056X-2R for grub-devel@gnu.org; Thu, 11 Apr 2013 06:54:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQF9J-0002Nq-59 for grub-devel@gnu.org; Thu, 11 Apr 2013 06:54:40 -0400 Received: from collab.rosalab.ru ([217.199.216.181]:55824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQF9I-0002M3-Py for grub-devel@gnu.org; Thu, 11 Apr 2013 06:54:37 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by collab.rosalab.ru (Postfix) with ESMTP id B145029C266 for ; Thu, 11 Apr 2013 14:54:33 +0400 (MSK) X-Virus-Scanned: amavisd-new at rosalab.ru Received: from collab.rosalab.ru ([127.0.0.1]) by localhost (collab.rosalab.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bekau395yLpf for ; Thu, 11 Apr 2013 14:54:33 +0400 (MSK) Received: from icedphoenix.localnet (unknown [10.168.1.56]) by collab.rosalab.ru (Postfix) with ESMTPSA id 4324929C261 for ; Thu, 11 Apr 2013 14:54:33 +0400 (MSK) From: Vladimir Testov To: grub-devel@gnu.org Subject: [PATCH] [0/11] [gfxmenu/list] - "version" parameter Date: Thu, 11 Apr 2013 14:54:33 +0400 Message-ID: <1526551.q1U5oPLDOt@icedphoenix> User-Agent: KMail/4.9.5 (Linux/3.5.0-26-generic; KDE/4.9.5; x86_64; ; ) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart9898573.YSXK7vZnGG" Content-Transfer-Encoding: 7Bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 217.199.216.181 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2013 10:54:44 -0000 This is a multi-part message in MIME format. --nextPart9898573.YSXK7vZnGG Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" There are plenty of misbehaviours of "bootmenu list" component which I would like to correct. Many of following patches can break backward compatibility. So I suggest to make a new parameter of a "bootmenu list" - "version". It equal 0 by default. If some behaviour would change since version 2.XY then we can use XY as start point for some new behaviour and save previous behaviour at the same time. So if version is 0 - every behavour is just the same as was before. If version is 1 - the behaviour can change a little. (1 - for future release of 2.01 version) or it could be 201 version, 202 version etc. -- With best regards, _______________________________ Vladimir Testov, ROSA Laboratory. www.rosalab.ru --nextPart9898573.YSXK7vZnGG Content-Disposition: attachment; filename="grub-2.00-list-version.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="utf-8"; name="grub-2.00-list-version.patch" diff -Naur grub-2.00/grub-core/gfxmenu/gui_list.c grub-new/grub-core/gfxmenu/gui_list.c --- grub-2.00/grub-core/gfxmenu/gui_list.c 2011-12-14 14:36:07.000000000 +0400 +++ grub-new/grub-core/gfxmenu/gui_list.c 2013-03-25 17:24:09.283623915 +0400 @@ -31,6 +31,7 @@ grub_gui_container_t parent; grub_video_rect_t bounds; char *id; + int list_version; int visible; int icon_width; @@ -519,6 +520,10 @@ grub_free (self->theme_dir); self->theme_dir = value ? grub_strdup (value) : 0; } + else if (grub_strcmp (name, "version") == 0) + { + self->list_version = grub_strtol (value, 0, 10); + } else if (grub_strcmp (name, "id") == 0) { grub_free (self->id); @@ -574,6 +579,7 @@ self->list.ops = &list_ops; self->list.component.ops = &list_comp_ops; + self->list_version = 0; self->visible = 1; default_font = grub_font_get ("Unknown Regular 16"); --nextPart9898573.YSXK7vZnGG--