From: Yu-cheng Yu Subject: Re: [PATCH 10/10] mm: Prevent munmap and remap_file_pages of shadow stack Date: Thu, 07 Jun 2018 13:15:01 -0700 Message-ID: <1528402501.5265.23.camel@2b52.sc.intel.com> References: <20180607143807.3611-1-yu-cheng.yu@intel.com> <20180607143807.3611-11-yu-cheng.yu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Lutomirski Cc: LKML , linux-doc@vger.kernel.org, Linux-MM , linux-arch , X86 ML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , "H. J. Lu" , "Shanbhogue, Vedvyas" , "Ravi V. Shankar" , Dave Hansen , Jonathan Corbet , Oleg Nesterov , Arnd Bergmann , mike.kravetz@oracle.com List-Id: linux-arch.vger.kernel.org On Thu, 2018-06-07 at 11:50 -0700, Andy Lutomirski wrote: > On Thu, Jun 7, 2018 at 7:41 AM Yu-cheng Yu wrote: > > blocking remap_file_pages() seems reasonable. I'm not sure what's > wrong with munmap(). Yes, maybe we don't need to block munmap(). If the shadow stack is unmapped, the application gets a fault. I will remove the patch.