From: Dmitry Safonov Subject: Re: [PATCHv2] lib/ratelimit: Lockless ratelimiting Date: Tue, 26 Jun 2018 18:46:23 +0100 Message-ID: <1530035183.3205.6.camel@arista.com> References: <20180626162438.16306-1-dima@arista.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Andy Shevchenko Cc: Theodore Ts'o , Arnd Bergmann , David Airlie , Greg Kroah-Hartman , intel-gfx@lists.freedesktop.org, Dmitry Safonov <0x7f454c46@gmail.com>, Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, Rodrigo Vivi , Thomas Gleixner List-Id: dri-devel@lists.freedesktop.org SGkgQW5keSwgdGhhbmtzIGZvciB0aGUgcmV2aWV3LAoKT24gVHVlLCAyMDE4LTA2LTI2IGF0IDIw OjA0ICswMzAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGUKWy4uXQo+ID4gICNkZWZpbmUgUkFURUxJ TUlUX1NUQVRFX0lOSVQobmFtZSwgaW50ZXJ2YWxfaW5pdCwgYnVyc3RfaW5pdCkKPiA+IHsgICAg ICAgICAgICAgICAgXAo+ID4gLSAgICAgICAgICAgICAgIC5sb2NrICAgICAgICAgICA9Cj4gPiBf X1JBV19TUElOX0xPQ0tfVU5MT0NLRUQobmFtZS5sb2NrKSwgIFwKPiAKPiBuYW1lIGlzIG5vdyBy ZWR1bmRhbnQsIGlzbid0IGl0PwoKSXQgaXMuIFdvcnRoIHRvIHNwbGl0IG9uIHRoZSBzZWNvbmQg cGF0Y2ggb3Iga2VlcCBjYWxsZXJzIGNoYW5nZXMgaW4KdGhpcyBwYXRjaD8KCj4gPiBAQCAtNDIs OSArNDEsMTAgQEAgc3RhdGljIGlubGluZSB2b2lkIHJhdGVsaW1pdF9zdGF0ZV9pbml0KHN0cnVj dAo+ID4gcmF0ZWxpbWl0X3N0YXRlICpycywKPiA+ICB7Cj4gPiAgICAgICAgIG1lbXNldChycywg MCwgc2l6ZW9mKCpycykpOwo+ID4gCj4gPiAtICAgICAgIHJhd19zcGluX2xvY2tfaW5pdCgmcnMt PmxvY2spOwo+ID4gICAgICAgICBycy0+aW50ZXJ2YWwgICAgPSBpbnRlcnZhbDsKPiA+ICAgICAg ICAgcnMtPmJ1cnN0ICAgICAgID0gYnVyc3Q7Cj4gPiArICAgICAgIGF0b21pY19zZXQoJnJzLT5w cmludGVkLCAwKTsKPiA+ICsgICAgICAgYXRvbWljX3NldCgmcnMtPm1pc3NlZCwgMCk7Cj4gCj4g Q2FuIGl0IGJlCj4gCj4gKnJzID0gUkFURUxJTUlUX1NUQVRFX0lOSVQoaW50ZXJ2YWwsIGJ1cnN0 KTsKPiAKPiA/Cj4gCj4gKFllcywgdGhlICcoc3RydWN0IHJhdGVsaW1pdF9zdGF0ZSknIGhhcyB0 byBiZSBhZGRlZCB0byBtYWNybyB0bwo+IGFsbG93IHRoaXMpCgpTdXJlLgoKPiA+ICBzdGF0aWMg aW5saW5lIHZvaWQgcmF0ZWxpbWl0X3N0YXRlX2V4aXQoc3RydWN0IHJhdGVsaW1pdF9zdGF0ZQo+ ID4gKnJzKQo+ID4gIHsKPiA+ICsgICAgICAgaW50IG1pc3NlZDsKPiA+ICsKPiA+ICAgICAgICAg aWYgKCEocnMtPmZsYWdzICYgUkFURUxJTUlUX01TR19PTl9SRUxFQVNFKSkKPiA+ICAgICAgICAg ICAgICAgICByZXR1cm47Cj4gPiAKPiA+IC0gICAgICAgaWYgKHJzLT5taXNzZWQpIHsKPiA+ICsg ICAgICAgaWYgKChtaXNzZWQgPSBhdG9taWNfeGNoZygmcnMtPm1pc3NlZCwgMCkpKQo+IAo+IFBl cmhhcHMKPiAKPiBtaXNzZWQgPSAuLi4KPiBpZiAobWlzc2VkKQo+IAo+ID8KCk9rLCB3aWxsIGNo YW5nZSAtIGNoZWNrcGF0Y2ggaGFzIHdhcm5lZCBtZSwgYnV0IEkgdGhvdWdodCBpdCdzIGp1c3Qg YQpwcmVmZXJlbmNlIHRoYW4gYSBydWxlLgoKPiAKPiA+ICAgICAgICAgICAgICAgICBwcl93YXJu KCIlczogJWQgb3V0cHV0IGxpbmVzIHN1cHByZXNzZWQgZHVlIHRvCj4gPiByYXRlbGltaXRpbmdc biIsCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICBjdXJyZW50LT5jb21tLCBycy0+bWlzc2Vk KTsKPiA+IC0gICAgICAgICAgICAgICBycy0+bWlzc2VkID0gMDsKPiA+IC0gICAgICAgfQo+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgY3VycmVudC0+Y29tbSwgbWlzc2VkKTsKPiA+ICB9Cj4g PiArc3RhdGljIHZvaWQgcmF0ZWxpbWl0X2VuZF9pbnRlcnZhbChzdHJ1Y3QgcmF0ZWxpbWl0X3N0 YXRlICpycywKPiA+IGNvbnN0IGNoYXIgKmZ1bmMpCj4gPiArewo+ID4gKyAgICAgICBycy0+YmVn aW4gPSBqaWZmaWVzOwo+ID4gKwo+ID4gKyAgICAgICBpZiAoIShycy0+ZmxhZ3MgJiBSQVRFTElN SVRfTVNHX09OX1JFTEVBU0UpKSB7Cj4gPiArICAgICAgICAgICAgICAgdW5zaWduZWQgbWlzc2Vk ID0gKHVuc2lnbmVkKWF0b21pY194Y2hnKCZycy0KPiA+ID5taXNzZWQsIDApOwo+ID4gKwo+ID4g KyAgICAgICAgICAgICAgIGlmIChtaXNzZWQpCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBw cl93YXJuKCIlczogJXUgY2FsbGJhY2tzIHN1cHByZXNzZWRcbiIsCj4gPiBmdW5jLCBtaXNzZWQp Owo+IAo+IEluc3RlYWQgb2YgY2FzdGluZywgcGVyaGFwcwo+IAo+IGludCBtaXNzZWQgPSAuLi4K PiAKPiBJIHRoaW5rIHlvdSBhbHJlYWR5IGhhcyBhIGd1YXJkIGFnYWluc3QgZ29pbmcgaXQgYmVs b3cgemVyby4gT3IgSQo+IG1pc3NlZCBzb21ldGhpbmc/CgpObywgSSBkbzoKYXRvbWljX2FkZF91 bmxlc3MoJnJzLT5taXNzZWQsIDEsIC0xKTsKClNvLCBpdCdzIGd1YXJkIGFnYWluc3Qgb3ZlcmZs b3csIGJ1dCBub3QgYWdhaW5zdCBuZWdhdGl2ZS4KVGhhdCdzIHdoeSBJIGRvIHByaW50IGl0IGFz IHVuc2lnbmVkLgoKLS0gClRoYW5rcywKICAgICAgICAgICAgIERtaXRyeQpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK