Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] usb: Avoid use-after-free by flushing endpoints early in usb_set_interface() From: Mathias Nyman Message-Id: <1535978656-22500-1-git-send-email-mathias.nyman@linux.intel.com> Date: Mon, 3 Sep 2018 15:44:16 +0300 To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu, sudipm.mukherjee@gmail.com, Mathias Nyman , stable@vger.kernel.org List-ID: VGhlIHN0ZXBzIHRha2VuIGJ5IHVzYiBjb3JlIHRvIHNldCBhIG5ldyBpbnRlcmZhY2UgaXMgdmVy eSBkaWZmZXJlbnQgZnJvbQp3aGF0IGlzIGRvbmUgb24gdGhlIHhIQyBob3N0IHNpZGUuCgp4SEMg aGFyZHdhcmUgd2lsbCBkbyBldmVyeXRoaW5nIGluIG9uZSBnby4gT25lIGNvbW1hbmQgaXMgdXNl ZCB0byBzZXQgdXAKbmV3IGVuZHBvaW50cywgZnJlZSBvbGQgZW5kcG9pbnRzLCBjaGVjayBiYW5k d2lkdGgsIGFuZCBydW4gdGhlIG5ldwplbmRwb2ludHMuCgpBbGwgdGhpcyBpcyBkb25lIGJ5IHhI QyB3aGVuIHVzYiBjb3JlIGFza3MgdGhlIGhjZCB0byBjaGVjayBmb3IKYXZhaWxhYmxlIGJhbmR3 aWR0aC4gQXQgdGhpcyBwb2ludCB1c2IgY29yZSBoYXMgbm90IHlldCBmbHVzaGVkIHRoZSBvbGQK ZW5kcG9pbnRzLCB3aGljaCB3aWxsIGNhdXNlIHVzZS1hZnRlci1mcmVlIGlzc3VlcyBpbiB4aGNp IGRyaXZlciBhcwpxdWV1ZWQgVVJCcyBhcmUgY2FuY2VsbGVkIG9uIGEgcmUtYWxsb2NhdGVkIGVu ZHBvaW50LgoKVG8gcmVzb2x2ZSB0aGlzIGFkZCBhIGNhbGwgdG8gdXNiX2Rpc2FibGVfaW50ZXJm YWNlKCkgd2hpY2ggd2lsbCBmbHVzaAp0aGUgZW5kcG9pbnRzIGJlZm9yZSBjYWxsaW5nIHVzYl9o Y2RfYWxsb2NfYmFuZHdpZHRoKCkKCkFkZGl0aW9uYWwgY2hlY2tzIGluIHhoY2kgZHJpdmVyIHdp bGwgYWxzbyBiZSBpbXBsZW1lbnRlZCB0byBncmFjZWZ1bGx5CmhhbmRsZSBzdGFsZSBVUkIgY2Fu Y2VsIG9uIGZyZWVkIGFuZCByZS1hbGxvY2F0ZWQgZW5kcG9pbnRzCgpDYzogPHN0YWJsZUB2Z2Vy Lmtlcm5lbC5vcmc+ClJlcG9ydGVkLWJ5OiBTdWRpcCBNdWtoZXJqZWUgPHN1ZGlwbS5tdWtoZXJq ZWVAZ21haWwuY29tPgpTaWduZWQtb2ZmLWJ5OiBNYXRoaWFzIE55bWFuIDxtYXRoaWFzLm55bWFu QGxpbnV4LmludGVsLmNvbT4KLS0tCiAgdjI6IHVwZGF0ZSBrZXJuZWxkb2MgYXMgd2VsbAotLS0K IGRyaXZlcnMvdXNiL2NvcmUvbWVzc2FnZS5jIHwgMTEgKysrKysrKysrKysKIDEgZmlsZSBjaGFu Z2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvY29yZS9tZXNz YWdlLmMgYi9kcml2ZXJzL3VzYi9jb3JlL21lc3NhZ2UuYwppbmRleCAyMjg2NzJmLi5iZmE1ZWRh IDEwMDY0NAotLS0gYS9kcml2ZXJzL3VzYi9jb3JlL21lc3NhZ2UuYworKysgYi9kcml2ZXJzL3Vz Yi9jb3JlL21lc3NhZ2UuYwpAQCAtMTM0MSw2ICsxMzQxLDExIEBAIHZvaWQgdXNiX2VuYWJsZV9p bnRlcmZhY2Uoc3RydWN0IHVzYl9kZXZpY2UgKmRldiwKICAqIGlzIHN1Ym1pdHRlZCB0aGF0IG5l ZWRzIHRoYXQgYmFuZHdpZHRoLiAgU29tZSBvdGhlciBvcGVyYXRpbmcgc3lzdGVtcwogICogYWxs b2NhdGUgYmFuZHdpZHRoIGVhcmx5LCB3aGVuIGEgY29uZmlndXJhdGlvbiBpcyBjaG9zZW4uCiAg KgorICogeEhDSSByZXNlcnZlcyBiYW5kd2lkdGggYW5kIGNvbmZpZ3VyZXMgdGhlIGFsdGVybmF0 ZSBzZXR0aW5nIGluCisgKiB1c2JfaGNkX2FsbG9jX2JhbmR3aWR0aCgpLiBJZiBpdCBmYWlscyB0 aGUgb3JpZ2luYWwgaW50ZXJmYWNlIGFsdHNldHRpbmcKKyAqIG1heSBiZSBkaXNhYmxlZC4gRHJp dmVycyBjYW5ub3QgcmVseSBvbiBhbnkgcGFydGljdWxhciBhbHRlcm5hdGUKKyAqIHNldHRpbmcg YmVpbmcgaW4gZWZmZWN0IGFmdGVyIGEgZmFpbHVyZS4KKyAqCiAgKiBUaGlzIGNhbGwgaXMgc3lu Y2hyb25vdXMsIGFuZCBtYXkgbm90IGJlIHVzZWQgaW4gYW4gaW50ZXJydXB0IGNvbnRleHQuCiAg KiBBbHNvLCBkcml2ZXJzIG11c3Qgbm90IGNoYW5nZSBhbHRzZXR0aW5ncyB3aGlsZSB1cmJzIGFy ZSBzY2hlZHVsZWQgZm9yCiAgKiBlbmRwb2ludHMgaW4gdGhhdCBpbnRlcmZhY2U7IGFsbCBzdWNo IHVyYnMgbXVzdCBmaXJzdCBiZSBjb21wbGV0ZWQKQEAgLTEzNzYsNiArMTM4MSwxMiBAQCBpbnQg dXNiX3NldF9pbnRlcmZhY2Uoc3RydWN0IHVzYl9kZXZpY2UgKmRldiwgaW50IGludGVyZmFjZSwg aW50IGFsdGVybmF0ZSkKIAkJCSBhbHRlcm5hdGUpOwogCQlyZXR1cm4gLUVJTlZBTDsKIAl9CisJ LyoKKwkgKiB1c2IzIGhvc3RzIGNvbmZpZ3VyZSB0aGUgaW50ZXJmYWNlIGluIHVzYl9oY2RfYWxs b2NfYmFuZHdpZHRoLAorCSAqIGluY2x1ZGluZyBmcmVlaW5nIGRyb3BwZWQgZW5kcG9pbnQgcmlu ZyBidWZmZXJzLgorCSAqIE1ha2Ugc3VyZSB0aGUgaW50ZXJmYWNlIGVuZHBvaW50cyBhcmUgZmx1 c2hlZCBiZWZvcmUgdGhhdAorCSAqLworCXVzYl9kaXNhYmxlX2ludGVyZmFjZShkZXYsIGlmYWNl LCBmYWxzZSk7CiAKIAkvKiBNYWtlIHN1cmUgd2UgaGF2ZSBlbm91Z2ggYmFuZHdpZHRoIGZvciB0 aGlzIGFsdGVybmF0ZSBpbnRlcmZhY2UuCiAJICogUmVtb3ZlIHRoZSBjdXJyZW50IGFsdCBzZXR0 aW5nIGFuZCBhZGQgdGhlIG5ldyBhbHQgc2V0dGluZy4K