From: Christopher Clark Subject: [PATCH v2 17/18] argo: validate hypercall arg structures via compat machinery Date: Wed, 19 Dec 2018 22:39:14 -0800 Message-ID: <1545287955-27684-18-git-send-email-christopher.w.clark@gmail.com> References: <1545287955-27684-1-git-send-email-christopher.w.clark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gZs0C-0006tM-1E for xen-devel@lists.xenproject.org; Thu, 20 Dec 2018 06:40:12 +0000 Received: by mail-io1-xd42.google.com with SMTP id l14so488550ioj.5 for ; Wed, 19 Dec 2018 22:40:11 -0800 (PST) In-Reply-To: <1545287955-27684-1-git-send-email-christopher.w.clark@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Wei Liu , Ross Philipson , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Jason Andryuk , Ian Jackson , Rich Persaud , Tim Deegan , Daniel Smith , Julien Grall , Paul Durrant , Jan Beulich , James McKenzie , Eric Chanudet , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org QXJnbyBkb2Vzbid0IHVzZSBjb21wYXQgaHlwZXJjYWxsIG9yIGFyZ3VtZW50IHRyYW5zbGF0aW9u IGJ1dCBjYW4gdXNlIHNvbWUKb2YgdGhlIGluZnJhc3RydWN0dXJlIGZvciB2YWxpZGF0aW5nIHRo ZSBoeXBlcmNhbGwgYXJndW1lbnQgc3RydWN0dXJlcyB0bwplbnN1cmUgdGhhdCB0aGUgc3RydWN0 IHNpemVzLCBvZmZzZXRzIGFuZCBjb21wb3NpdGlvbnMgZG9uJ3QgdmFyeSBiZXR3ZWVuIDMyCmFu ZCA2NGJpdCwgc28gYWRkIHRoYXQgaGVyZSBpbiBhIG5ldyBkZWRpY2F0ZWQgc291cmNlIGZpbGUg Zm9yIHRoaXMgcHVycG9zZS4KClNvbWUgb2YgdGhlIGFyZ28gaHlwZXJjYWxsIGFyZ3VtZW50IHN0 cnVjdHVyZXMgY29udGFpbiBlbGVtZW50cyB0aGF0IGFyZQpoeXBlcmNhbGwgYXJndW1lbnQgc3Ry dWN0dXJlIHR5cGVzIHRoZW1zZWx2ZXMsIGFuZCB0aGUgc3RhbmRhcmQgY29tcGF0CnN0cnVjdHVy ZSB2YWxpZGF0aW9uIGRvZXMgbm90IGhhbmRsZSB0aGlzLCBzaW5jZSB0aGUgdHlwZXMgZGlmZmVy IGluIGNvbXBhdAp2cy4gbm9uLWNvbXBhdCB2ZXJzaW9uczsgc28gZm9yIHNvbWUgb2YgdGhlIHRl c3RzIHRoZSBleGFjdC10eXBlLW1hdGNoIGNoZWNrCmlzIHJlcGxhY2VkIHdpdGggYSB3ZWFrZXIs IGJ1dCBzdGlsbCBzdWZmaWNpZW50LCBzaXplb2YgY2hlY2suCgpUaGVuIHRoZXJlIGFyZSBhZGRp dGlvbmFsIGh5cGVyY2FsbCBhcmd1bWVudCBzdHJ1Y3R1cmVzIHRoYXQgY29udGFpbgplbGVtZW50 cyB0aGF0IGRvIG5vdCBoYXZlIGEgZml4ZWQgc2l6ZSAobGFzdCBlbGVtZW50LCB2YXJpYWJsZSBs ZW5ndGggYXJyYXkKZmllbGRzKSwgc28gd2UgaGF2ZSB0byB0aGVuIGRpc2FibGUgdGhhdCBzaXpl IGNoZWNrIHRvbyBmb3IgdmFsaWRhdGluZyB0aG9zZQpzdHJ1Y3R1cmVzOyB0aGUgY292ZXJhZ2Ug b2Ygb2Zmc2V0IG9mIGVsZW1lbnRzIGlzIHN0aWxsIHJldGFpbmVkLgoKU2lnbmVkLW9mZi1ieTog Q2hyaXN0b3BoZXIgQ2xhcmsgPGNocmlzdG9waGVyLmNsYXJrNkBiYWVzeXN0ZW1zLmNvbT4KLS0t ClRoaXMgaXMgYSBuZXcgcGF0Y2ggaW50cm9kdWNlZCBpbiB2ZXJzaW9uIDIgb2YgdGhlIHNlcmll cy4KClRoZXNlIGNoZWNrcyBjb3VsZCBiZSBpbnRyb2R1Y2VkIGluY3JlbWVudGFsbHkgaW4gbXVs dGlwbGUgcHJldmlvdXMgY29tbWl0cyBhcwp0aGUgZGF0YSBzdHJ1Y3R1cmVzIGFyZSBhZGRlZCB3 aXRoIGVhY2ggaHlwZXJjYWxsIG9wLCBidXQgdGhpcyBjb21taXQgY2FuIHN0YW5kCm9yIGZhbGwg b24gaXRzIG93biBhbmQgdGhlIG1hY3JvIHJlZGVmaW5pdGlvbiBuZWVkZWQgdG8gb3ZlcnJpZGUg YXNwZWN0cyBvZiB0aGUKY2hlY2tpbmcgd2FycmFudHMgcmV2aWV3LiBUaGlzIGNvbW1pdCBkb2Vz IGFkZCBjb21waWxlLXRpbWUgY292ZXJhZ2Ugb2YgdGhlCmh5cGVyY2FsbCBkYXRhIHN0cnVjdHVy ZXMgKGFzIHJlcXVlc3RlZCkuCgogeGVuL2NvbW1vbi9NYWtlZmlsZSAgICAgIHwgIDIgKy0KIHhl bi9jb21tb24vY29tcGF0L2FyZ28uYyB8IDYwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA2MSBpbnNlcnRpb25zKCspLCAx IGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2NvbW1vbi9jb21wYXQvYXJnby5j CgpkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9NYWtlZmlsZSBiL3hlbi9jb21tb24vTWFrZWZpbGUK aW5kZXggOGM2NWM2Zi4uODhiOWIyZiAxMDA2NDQKLS0tIGEveGVuL2NvbW1vbi9NYWtlZmlsZQor KysgYi94ZW4vY29tbW9uL01ha2VmaWxlCkBAIC03MCw3ICs3MCw3IEBAIG9iai15ICs9IHhtYWxs b2NfdGxzZi5vCiBvYmotYmluLSQoQ09ORklHX1g4NikgKz0gJChmb3JlYWNoIG4sZGVjb21wcmVz cyBidW56aXAyIHVueHogdW5sem1hIHVubHpvIHVubHo0IGVhcmx5Y3BpbywkKG4pLmluaXQubykK IAogCi1vYmotJChDT05GSUdfQ09NUEFUKSArPSAkKGFkZHByZWZpeCBjb21wYXQvLGRvbWFpbi5v IGtlcm5lbC5vIG1lbW9yeS5vIG11bHRpY2FsbC5vIHhsYXQubykKK29iai0kKENPTkZJR19DT01Q QVQpICs9ICQoYWRkcHJlZml4IGNvbXBhdC8sYXJnby5vIGRvbWFpbi5vIGtlcm5lbC5vIG1lbW9y eS5vIG11bHRpY2FsbC5vIHhsYXQubykKIAogdG1lbS15IDo9IHRtZW0ubyB0bWVtX3hlbi5vIHRt ZW1fY29udHJvbC5vCiB0bWVtLSQoQ09ORklHX0NPTVBBVCkgKz0gY29tcGF0L3RtZW1feGVuLm8K ZGlmZiAtLWdpdCBhL3hlbi9jb21tb24vY29tcGF0L2FyZ28uYyBiL3hlbi9jb21tb24vY29tcGF0 L2FyZ28uYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4yMDljNGZkCi0tLSAv ZGV2L251bGwKKysrIGIveGVuL2NvbW1vbi9jb21wYXQvYXJnby5jCkBAIC0wLDAgKzEsNjAgQEAK Ky8qKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioKKyAqIEFyZ28gOiBIeXBlcnZpc29yLU1lZGlhdGVkIGRh dGEgZVhjaGFuZ2UKKyAqCisgKiBDb3B5cmlnaHQgKGMpIDIwMTgsIEJBRSBTeXN0ZW1zCisgKgor ICogVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBi ZSB1c2VmdWwsCisgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUg aW1wbGllZCB3YXJyYW50eSBvZgorICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEg UEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorICogR05VIEdlbmVyYWwgUHVibGljIExpY2Vu c2UgZm9yIG1vcmUgZGV0YWlscy4KKyAqCisgKiBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBj b3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorICogYWxvbmcgd2l0aCB0aGlz IHByb2dyYW07IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29mdHdhcmUKKyAqIEZvdW5kYXRp b24sIEluYy4sIDU5IFRlbXBsZSBQbGFjZSwgU3VpdGUgMzMwLCBCb3N0b24sIE1BICAwMjExMS0x MzA3ICBVU0EKKyAqLworCisjaW5jbHVkZSA8eGVuL3R5cGVzLmg+CisjaW5jbHVkZSA8eGVuL2xp Yi5oPgorI2luY2x1ZGUgPHB1YmxpYy9hcmdvLmg+CisjaW5jbHVkZSA8Y29tcGF0L2FyZ28uaD4K KworQ0hFQ0tfYXJnb19hZGRyOworCisvKgorICogRGlzYWJsZSBzdHJpY3QgdHlwZSBjaGVja2lu ZyBpbiB0aGlzIGNvbXBhdCB2YWxpZGF0aW9uIG1hY3JvIGZvciB0aGUKKyAqIGZvbGxvd2luZyBz dHJ1Y3QgY2hlY2tzIGJlY2F1c2UgaXQgY2Fubm90IGhhbmRsZSBmaWVsZHMgd2l0aGluIHN0cnVj dHMgdGhhdAorICogaGF2ZSB0eXBlcyB0aGF0IGRpZmZlciBpbiB0aGUgY29tcGF0IHZlcnN1cyBu b24tY29tcGF0IHN0cnVjdHMuCisgKiBSZXBsYWNlIGl0IHdpdGggYSBmaWVsZCBzaXplIGNoZWNr IHdoaWNoIGlzIHN1ZmZpY2llbnQgaGVyZS4KKyAqLworCisjdW5kZWYgQ0hFQ0tfRklFTERfQ09N TU9OXworI2RlZmluZSBDSEVDS19GSUVMRF9DT01NT05fKGssIG5hbWUsIG4sIGYpIFwKK3N0YXRp YyBpbmxpbmUgaW50IF9fbWF5YmVfdW51c2VkIG5hbWUoayB4ZW5fICMjIG4gKngsIGsgY29tcGF0 XyAjIyBuICpjKSBcCit7IFwKKyAgICBCVUlMRF9CVUdfT04ob2Zmc2V0b2YoayB4ZW5fICMjIG4s IGYpICE9IFwKKyAgICAgICAgICAgICAgICAgb2Zmc2V0b2YoayBjb21wYXRfICMjIG4sIGYpKTsg XAorICAgIHJldHVybiBzaXplb2YoeC0+ZikgPT0gc2l6ZW9mKGMtPmYpOyBcCit9CisKK0NIRUNL X2FyZ29fcmluZ19pZDsKK0NIRUNLX2FyZ29fc2VuZF9hZGRyOworQ0hFQ0tfYXJnb19yaW5nX2Rh dGFfZW50OworQ0hFQ0tfYXJnb19pb3Y7CisKKy8qCisgKiBEaXNhYmxlIHNpemVvZiB0eXBlIGNo ZWNraW5nIGZvciB0aGUgZm9sbG93aW5nIHN0cnVjdCBjaGVja3MgYmVjYXVzZQorICogdGhlc2Ug c3RydWN0cyBoYXZlIGZpZWxkcyB3aXRoIHZhcmlhYmxlIHNpemUgdGhhdCB0aGUgc2l6ZSBjaGVj aworICogY2Fubm90IHZhbGlkYXRlLgorICovCisKKyN1bmRlZiBDSEVDS19GSUVMRF9DT01NT05f CisjZGVmaW5lIENIRUNLX0ZJRUxEX0NPTU1PTl8oaywgbmFtZSwgbiwgZikgXAorc3RhdGljIGlu bGluZSBpbnQgX19tYXliZV91bnVzZWQgbmFtZShrIHhlbl8gIyMgbiAqeCwgayBjb21wYXRfICMj IG4gKmMpIFwKK3sgXAorICAgIEJVSUxEX0JVR19PTihvZmZzZXRvZihrIHhlbl8gIyMgbiwgZikg IT0gXAorICAgICAgICAgICAgICAgICBvZmZzZXRvZihrIGNvbXBhdF8gIyMgbiwgZikpOyBcCisg ICAgcmV0dXJuIDE7IFwKK30KKworQ0hFQ0tfYXJnb19yaW5nOworQ0hFQ0tfYXJnb19yaW5nX2Rh dGE7Ci0tIAoyLjcuNAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qu b3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2 ZWw=