From: Mimi Zohar Date: Thu, 17 Jan 2019 23:25:01 +0000 Subject: Re: [PATCH v3 2/2] kexec, KEYS: Make use of platform keyring for signature verify Message-Id: <1547767501.3931.60.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20190116101654.7288-1-kasong@redhat.com> <20190116101654.7288-3-kasong@redhat.com> In-Reply-To: <20190116101654.7288-3-kasong@redhat.com> To: Kairui Song , linux-kernel@vger.kernel.org Cc: dhowells@redhat.com, dwmw2@infradead.org, jwboyer@fedoraproject.org, keyrings@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, bauerman@linux.ibm.com, ebiggers@google.com, nayna@linux.ibm.com, dyoung@redhat.com, linux-integrity@vger.kernel.org, kexec@lists.infradead.org T24gV2VkLCAyMDE5LTAxLTE2IGF0IDE4OjE2ICswODAwLCBLYWlydWkgU29uZyB3cm90ZToKPiBX aXRoIEtFWEVDX0JaSU1BR0VfVkVSSUZZX1NJRyBlbmFibGVkLCBrZXhlY19maWxlX2xvYWQgd2ls bCBuZWVkIHRvCj4gdmVyaWZ5IHRoZSBrZXJuZWwgaW1hZ2UuIAoKVGhlIGtleGVjX2ZpbGVfbG9h ZCBzeXNjYWxsIGNhbiB2ZXJpZnkgdGhlIFBFIHNpZ25lZCBrZXJuZWwgaW1hZ2UKc2lnbmF0dXJl LCB0aGUga2VybmVsIGltYWdlIHNpZ25hdHVyZSBzdG9yZWQgYXMgYW4geGF0dHIsIG9yIGJvdGgu CgpBbnlvbmUgYm9vdGluZyB0aGUgc3lzdGVtIHdpdGggdGhlICJhcHByYWlzZV90Y2IiIHBvbGlj eSBvciB3aXRoIGEKc2ltaWxhciBhcHByYWlzZSBwb2xpY3kgcnVsZSwgd2FudGluZyB0byBvbmx5 IHZlcmlmeWluZyB0aGUgUEUgc2lnbmVkCmtlcm5lbCBpbWFnZSwgd2lsbCBuZWVkIHRvIGluY2x1 ZGUgYSAiZG9udF9hcHByYWlzZQpmdW5jPUtFWEVDX0tFUk5FTF9DSEVDSyIgcnVsZSBpbiB0aGVp ciBjdXN0b20gcG9saWN5LgoKPiBUaGUgaW1hZ2UgbWlnaHQgYmUgc2lnbmVkIHdpdGggdGhpcmQg cGFydCBrZXlzLAo+IGFuZCB0aGUga2V5cyBjb3VsZCBiZSBzdG9yZWQgaW4gZmlybXdhcmUsIHRo ZW4gZ290IGxvYWRlZCBpbnRvIHRoZQo+IC5wbGF0Zm9ybSBrZXlyaW5nLiBOb3cgd2UgaGF2ZSBh IHN5bWJvbCAucGxhdGZvcm1fdHJ1c3RlZF9rZXlyaW5nIGFzIHRoZQo+IHJlZmVyZW5jZSB0byAu cGxhdGZvcm0ga2V5cmluZywgdGhpcyBwYXRjaCBtYWtlcyB1c2UgaWYgaXQgYW5kIGFsbG93Cj4g a2V4ZWNfZmlsZV9sb2FkIHRvIHZlcmlmeSB0aGUgaW1hZ2UgYWdhaW5zdCBrZXlzIGluIC5wbGF0 Zm9ybSBrZXlyaW5nLgoKVGhlcmUncyBubyBuZWVkIHRvIGludHJvZHVjZSB0aGUgY29uY2VwdCBv ZiAidGhpcmQgcGFydHkiIG9yICJmaXJtd2FyZQprZXlzIiBoZXJlLiDCoFJlZmVycmluZyB0byB0 aGVtIGFzIHRoZSAicHJlYm9vdCIga2V5cywgY2FuIHNpbXBsaWZ5IHRoZQphYm92ZSBwYXJhZ3Jh cGguCgo+IAo+IFRoaXMgY29tbWl0IGFkZHMgYSBWRVJJRllfVVNFX1BMQVRGT1JNX0tFWVJJTkcg c2ltaWxhciB0byBwcmV2aW91cwo+IFZFUklGWV9VU0VfU0VDT05EQVJZX0tFWVJJTkcgaW5kaWNh dGluZyB0aGF0IHZlcmlmeV9wa2NzN19zaWduYXR1cmUKPiBzaG91bGQgdmVyaWZ5IHRoZSBzaWdu YXR1cmUgdXNpbmcgcGxhdGZvcm0ga2V5cmluZy4gQWxzbywgZGVjcmVhc2UKPiB0aGUgZXJyb3Ig bWVzc2FnZSBsb2cgbGV2ZWwgd2hlbiB2ZXJpZmljYXRpb24gZmFpbGVkIHdpdGggLUVOT0tFWSwK PiBzbyB0aGF0IGlmIGNhbGxlZCB0cmllZCBtdWx0aXBsZSB0aW1lIHdpdGggZGlmZmVyZW50IGtl eXJpbmcgaXQKPiB3b24ndCBnZW5lcmF0ZSBleHRyYSBub2lzZXMuCj4gCj4gU2lnbmVkLW9mZi1i eTogS2FpcnVpIFNvbmcgPGthc29uZ0ByZWRoYXQuY29tPgoKUmV2aWV3ZWQvVGVzdGVkLWJ5OiBN aW1pIFpvaGFyIDx6b2hhckBsaW51eC5pYm0uY29tPgoKPiAtLS0KPiAgYXJjaC94ODYva2VybmVs L2tleGVjLWJ6aW1hZ2U2NC5jIHwgMTMgKysrKysrKysrKy0tLQo+ICBjZXJ0cy9zeXN0ZW1fa2V5 cmluZy5jICAgICAgICAgICAgfCAxMyArKysrKysrKysrKystCj4gIGluY2x1ZGUvbGludXgvdmVy aWZpY2F0aW9uLmggICAgICB8ICAxICsKPiAgMyBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25z KCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9rZXJuZWwva2V4 ZWMtYnppbWFnZTY0LmMgYi9hcmNoL3g4Ni9rZXJuZWwva2V4ZWMtYnppbWFnZTY0LmMKPiBpbmRl eCA3ZDk3ZTQzMmNiYmMuLjJjMDA3YWJkM2Q0MCAxMDA2NDQKPiAtLS0gYS9hcmNoL3g4Ni9rZXJu ZWwva2V4ZWMtYnppbWFnZTY0LmMKPiArKysgYi9hcmNoL3g4Ni9rZXJuZWwva2V4ZWMtYnppbWFn ZTY0LmMKPiBAQCAtNTM0LDkgKzUzNCwxNiBAQCBzdGF0aWMgaW50IGJ6SW1hZ2U2NF9jbGVhbnVw KHZvaWQgKmxvYWRlcl9kYXRhKQo+ICAjaWZkZWYgQ09ORklHX0tFWEVDX0JaSU1BR0VfVkVSSUZZ X1NJRwo+ICBzdGF0aWMgaW50IGJ6SW1hZ2U2NF92ZXJpZnlfc2lnKGNvbnN0IGNoYXIgKmtlcm5l bCwgdW5zaWduZWQgbG9uZyBrZXJuZWxfbGVuKQo+ICB7Cj4gLQlyZXR1cm4gdmVyaWZ5X3BlZmls ZV9zaWduYXR1cmUoa2VybmVsLCBrZXJuZWxfbGVuLAo+IC0JCQkJICAgICAgIFZFUklGWV9VU0Vf U0VDT05EQVJZX0tFWVJJTkcsCj4gLQkJCQkgICAgICAgVkVSSUZZSU5HX0tFWEVDX1BFX1NJR05B VFVSRSk7Cj4gKwlpbnQgcmV0Owo+ICsJcmV0ID0gdmVyaWZ5X3BlZmlsZV9zaWduYXR1cmUoa2Vy bmVsLCBrZXJuZWxfbGVuLAo+ICsJCQkJICAgICAgVkVSSUZZX1VTRV9TRUNPTkRBUllfS0VZUklO RywKPiArCQkJCSAgICAgIFZFUklGWUlOR19LRVhFQ19QRV9TSUdOQVRVUkUpOwo+ICsJaWYgKHJl dCA9IC1FTk9LRVkgJiYgSVNfRU5BQkxFRChDT05GSUdfSU5URUdSSVRZX1BMQVRGT1JNX0tFWVJJ TkcpKSB7Cj4gKwkJcmV0ID0gdmVyaWZ5X3BlZmlsZV9zaWduYXR1cmUoa2VybmVsLCBrZXJuZWxf bGVuLAo+ICsJCQkJCSAgICAgIFZFUklGWV9VU0VfUExBVEZPUk1fS0VZUklORywKPiArCQkJCQkg ICAgICBWRVJJRllJTkdfS0VYRUNfUEVfU0lHTkFUVVJFKTsKPiArCX0KPiArCXJldHVybiByZXQ7 Cj4gIH0KPiAgI2VuZGlmCj4gIAo+IGRpZmYgLS1naXQgYS9jZXJ0cy9zeXN0ZW1fa2V5cmluZy5j IGIvY2VydHMvc3lzdGVtX2tleXJpbmcuYwo+IGluZGV4IDQ2OTBlZjljZGE4YS4uNzA4NWMyODZm NGJkIDEwMDY0NAo+IC0tLSBhL2NlcnRzL3N5c3RlbV9rZXlyaW5nLmMKPiArKysgYi9jZXJ0cy9z eXN0ZW1fa2V5cmluZy5jCj4gQEAgLTI0MCwxMSArMjQwLDIyIEBAIGludCB2ZXJpZnlfcGtjczdf c2lnbmF0dXJlKGNvbnN0IHZvaWQgKmRhdGEsIHNpemVfdCBsZW4sCj4gICNlbHNlCj4gIAkJdHJ1 c3RlZF9rZXlzID0gYnVpbHRpbl90cnVzdGVkX2tleXM7Cj4gICNlbmRpZgo+ICsJfSBlbHNlIGlm ICh0cnVzdGVkX2tleXMgPSBWRVJJRllfVVNFX1BMQVRGT1JNX0tFWVJJTkcpIHsKPiArI2lmZGVm IENPTkZJR19JTlRFR1JJVFlfUExBVEZPUk1fS0VZUklORwo+ICsJCXRydXN0ZWRfa2V5cyA9IHBs YXRmb3JtX3RydXN0ZWRfa2V5czsKPiArI2Vsc2UKPiArCQl0cnVzdGVkX2tleXMgPSBOVUxMOwo+ ICsjZW5kaWYKPiArCQlpZiAoIXRydXN0ZWRfa2V5cykgewo+ICsJCQlyZXQgPSAtRU5PS0VZOwo+ ICsJCQlwcl9kZXZlbCgiUEtDUyM3IHBsYXRmb3JtIGtleXJpbmcgaXMgbm90IGF2YWlsYWJsZVxu Iik7Cj4gKwkJCWdvdG8gZXJyb3I7Cj4gKwkJfQo+ICAJfQo+ICAJcmV0ID0gcGtjczdfdmFsaWRh dGVfdHJ1c3QocGtjczcsIHRydXN0ZWRfa2V5cyk7Cj4gIAlpZiAocmV0IDwgMCkgewo+ICAJCWlm IChyZXQgPSAtRU5PS0VZKQo+IC0JCQlwcl9lcnIoIlBLQ1MjNyBzaWduYXR1cmUgbm90IHNpZ25l ZCB3aXRoIGEgdHJ1c3RlZCBrZXlcbiIpOwo+ICsJCQlwcl9kZXZlbCgiUEtDUyM3IHNpZ25hdHVy ZSBub3Qgc2lnbmVkIHdpdGggYSB0cnVzdGVkIGtleVxuIik7Cj4gIAkJZ290byBlcnJvcjsKPiAg CX0KPiAgCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvdmVyaWZpY2F0aW9uLmggYi9pbmNs dWRlL2xpbnV4L3ZlcmlmaWNhdGlvbi5oCj4gaW5kZXggY2ZhNDczMGQ2MDdhLi4wMThmYjVmMTNk NDQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC92ZXJpZmljYXRpb24uaAo+ICsrKyBiL2lu Y2x1ZGUvbGludXgvdmVyaWZpY2F0aW9uLmgKPiBAQCAtMTcsNiArMTcsNyBAQAo+ICAgKiBzaG91 bGQgYmUgdXNlZC4KPiAgICovCj4gICNkZWZpbmUgVkVSSUZZX1VTRV9TRUNPTkRBUllfS0VZUklO RyAoKHN0cnVjdCBrZXkgKikxVUwpCj4gKyNkZWZpbmUgVkVSSUZZX1VTRV9QTEFURk9STV9LRVlS SU5HICAoKHN0cnVjdCBrZXkgKikyVUwpCj4gIAo+ICAvKgo+ICAgKiBUaGUgdXNlIHRvIHdoaWNo IGFuIGFzeW1tZXRyaWMga2V5IGlzIGJlaW5nIHB1dC4K