From: "cron2 (Code Review)" Date: Sun, 5 Apr 2026 10:28:06 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <154df37cad51505f114718171ba29ac3f934331c-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="a/v8BNb/EJE="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --a/v8BNb/EJE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1609?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: mtcp: Remove noop statement in multi_tcp_process_outgoing_l= ink_ready ...................................................................... mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready Assigning to a parameter here has no effect. I can see no obvious alternative statement that might have been intended. Found by cppcheck. Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609 Message-Id: <20260404203335.30650-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 478.html Signed-off-by: Gert Doering --- M src/openvpn/mtcp.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/09/1609/2 diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index 2eab7b7..7651b4d 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -155,10 +155,6 @@ ASSERT(mi =3D=3D item.instance); mi->context.c2.to_link =3D item.buffer->buf; ret =3D multi_process_outgoing_link_dowork(m, mi, mpp_flags); - if (!ret) - { - mi =3D NULL; - } mbuf_free_buf(item.buffer); } return ret; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1609?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9 Gerrit-Change-Number: 1609 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --a/v8BNb/EJE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by cron2

mtcp: Remove noop statement in mult=
i_tcp_process_outgoing_link_ready

Assigning to a parameter here has = no effect. I can see no
obvious alternative statement that might have be= en intended.

Found by cppcheck.

Change-Id: I04a01cf536ee6d48d= 54ba623dda460c4a98859f9
Signed-off-by: Frank Lichtenheld <frank@...2375...= 41...>
Acked-by: Gert Doering <gert@...1296...>
Gerrit URL: = https://gerrit.openvpn.net/c/openvpn/+/1609
Message-Id: <202604042033= 35.30650-1-gert@...1296...>
URL: https://www.mail-archive.com/openvpn= -devel@lists.sourceforge.net/msg36478.html
Signed-off-by: Gert Doering &= lt;gert@...1296...>
---
M src/openvpn/mtcp.c
1 file changed, 0 = insertions(+), 4 deletions(-)

git pull ssh://ger=
rit.openvpn.net:29418/openvpn refs/changes/09/1609/2
diff --git a/s=
rc/openvpn/mtcp.c b/src/openvpn/mtcp.c
index 2eab7b7..7651b= 4d 100644
--- a/src/openvpn/mtcp.c
+++ b/sr= c/openvpn/mtcp.c
@@ -155,10 +155,6 @@
= ASSERT(mi =3D=3D item.instance);
mi->contex= t.c2.to_link =3D item.buffer->buf;
ret =3D mult= i_process_outgoing_link_dowork(m, mi, mpp_flags);
- if (!ret)
- {
- mi =3D NULL;
- }
mbuf_free_buf(item.buffer= );
}
return ret;
=

To view, visit change 1609. To unsubscribe, or for help wri= ting mail filters, visit settings.

=
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04a01cf536ee6d48d54ba623dda= 460c4a98859f9
Gerrit-Change-Number: 1609
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --a/v8BNb/EJE=--