From: "cron2 (Code Review)" Date: Sun, 5 Apr 2026 10:28:08 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <154df37cad51505f114718171ba29ac3f934331c-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="q8LqR006Yao="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --q8LqR006Yao= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/16= 09?usp=3Demail ) Change subject: mtcp: Remove noop statement in multi_tcp_process_outgoing_l= ink_ready ...................................................................... mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready Assigning to a parameter here has no effect. I can see no obvious alternative statement that might have been intended. Found by cppcheck. Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609 Message-Id: <20260404203335.30650-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 478.html Signed-off-by: Gert Doering --- M src/openvpn/mtcp.c 1 file changed, 0 insertions(+), 4 deletions(-) diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index 2eab7b7..7651b4d 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -155,10 +155,6 @@ ASSERT(mi =3D=3D item.instance); mi->context.c2.to_link =3D item.buffer->buf; ret =3D multi_process_outgoing_link_dowork(m, mi, mpp_flags); - if (!ret) - { - mi =3D NULL; - } mbuf_free_buf(item.buffer); } return ret; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1609?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9 Gerrit-Change-Number: 1609 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --q8LqR006Yao= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 sub= mitted this change.

View Change

mtcp: Remove noop statement in multi_tcp_process=
_outgoing_link_ready

Assigning to a parameter here has no effect. I = can see no
obvious alternative statement that might have been intended.<= br>
Found by cppcheck.

Change-Id: I04a01cf536ee6d48d54ba623dda460= c4a98859f9
Signed-off-by: Frank Lichtenheld <frank@...2641...>
= Acked-by: Gert Doering <gert@...1296...>
Gerrit URL: https://gerri= t.openvpn.net/c/openvpn/+/1609
Message-Id: <20260404203335.30650-1-ge= rt@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@...1199...= sourceforge.net/msg36478.html
Signed-off-by: Gert Doering <gert@...1711...= 96...>
---
M src/openvpn/mtcp.c
1 file changed, 0 insertions(+)= , 4 deletions(-)

diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c
ind= ex 2eab7b7..7651b4d 100644
--- a/src/openvpn/mtcp.c<= br>+++ b/src/openvpn/mtcp.c
@@ -155,10 +155,6 @@
ASSERT(mi =3D=3D item.instance);
= mi->context.c2.to_link =3D item.buffer->buf;
= ret =3D multi_process_outgoing_link_dowork(m, mi, mpp_flags);- if (!ret)
- {

- mi =3D NULL;
- }
mbuf_fre= e_buf(item.buffer);
}
return ret;=

To view, visit change 1609. To unsubscribe= , or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04a01cf536ee6d48d54ba623dda= 460c4a98859f9
Gerrit-Change-Number: 1609
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --q8LqR006Yao=--