Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AD29C43381 for ; Sun, 17 Mar 2019 17:59:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55F2A2086A for ; Sun, 17 Mar 2019 17:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726954AbfCQR7W (ORCPT ); Sun, 17 Mar 2019 13:59:22 -0400 Received: from authsmtp23.register.it ([81.88.48.46]:48511 "EHLO authsmtp.register.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726115AbfCQR7V (ORCPT ); Sun, 17 Mar 2019 13:59:21 -0400 X-Greylist: delayed 490 seconds by postgrey-1.27 at vger.kernel.org; Sun, 17 Mar 2019 13:59:20 EDT Received: from [192.168.1.1] ([93.41.32.9]) by cmsmtp with ESMTPSA id 5ZwDhWZDYjSal5ZwDhLYg8; Sun, 17 Mar 2019 18:51:09 +0100 X-Rid: guido@trentalancia.com@93.41.32.9 Message-ID: <1552845068.5940.6.camel@trentalancia.com> Subject: [PATCH] scsi: ignore Synchronize Cache command failures to keep using drives not supporting it From: Guido Trentalancia To: linux-kernel@vger.kernel.org Date: Sun, 17 Mar 2019 18:51:08 +0100 X-Priority: 1 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfKlZb5edfOVWOran40zjuv9f15oy+xiWfqgl7B/bI6yqvZpHOArq/t56XlJmtER1iQW0Ib0SiP1AH75UDqCX03vlZ/RvsGU9mGNsShRBnnNNn0nwyl5Y rS1mi0CBwG9kq8CKhR579jDbjSqEr54WfUplx9ptL+sqJJ7iHIxT2N3O Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Many obsolete hard drives do not support the Synchronize Cache SCSI command. Such command is generally issued during fsync() calls which at the moment therefore fail with the ILLEGAL_REQUEST sense key. Since this failure is currently treated as critical in the kernel SCSI disk driver, such obsolete hard drives cannot be used anymore (at least since kernel 4.10, maybe even earlier): they cannot be formatted, mounted and/or checked using tools such as e2fsprogs. Because there is nothing which can be done if the drive does not support such command, such ILLEGAL_REQUEST should be treated as non-critical so that the underlying operation does not fail and the obsolete hard drive can be used normally. Of course, using such hard drives which do not feature the Synchronize Cache SCSI command implies a very high risk (or maybe even certainty) of data loss in case of power cuts, USB cable disconnects and so on - SO YOU HAVE BEEN WARNED - IN DOUBT, UPGRADE TO A NEWER HARD DRIVE !!! Signed-off-by: Guido Trentalancia --- drivers/scsi/sd.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) --- linux-5.0.2-orig/drivers/scsi/sd.c 2019-03-17 18:22:04.822720851 +0100 +++ linux-5.0.2/drivers/scsi/sd.c 2019-03-17 18:47:06.405881720 +0100 @@ -1633,6 +1633,16 @@ static int sd_sync_cache(struct scsi_dis } if (res) { + /* + * sshdr.sense_key == ILLEGAL_REQUEST means this drive + * doesn't support sync. There's not much to do and + * sync shouldn't fail. + */ + if (sshdr->sense_key == ILLEGAL_REQUEST && sshdr->asc == 0x20) { + sd_printk(KERN_NOTICE, sdkp, "Drive does not support Synchronize Cache(10) command: ignoring.\n"); + return 0; + } + sd_print_result(sdkp, "Synchronize Cache(10) failed", res); if (driver_byte(res) == DRIVER_SENSE) @@ -2022,6 +2032,13 @@ static int sd_done(struct scsi_cmnd *SCp req->rq_flags |= RQF_QUIET; } break; + case SYNCHRONIZE_CACHE: + if (sshdr.asc == 0x20) { + sd_printk(KERN_NOTICE, sdkp, "Drive does not support Synchronize Cache(10) command: ignoring.\n"); + SCpnt->result = 0; + good_bytes = scsi_bufflen(SCpnt); + } + break; } } break;