From: "Nuernberger, Stefan" Subject: Re: [PATCH RFC 06/55] x86/mm: map_pages_to_xen should have one exit path Date: Mon, 18 Mar 2019 21:14:14 +0000 Message-ID: <1552943654.6788.95.camel@amazon.de> References: <20190207164456.9260-1-wei.liu2@citrix.com> <20190207164456.9260-7-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1h5zaP-0007je-Ay for xen-devel@lists.xenproject.org; Mon, 18 Mar 2019 21:14:21 +0000 In-Reply-To: <20190207164456.9260-7-wei.liu2@citrix.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "xen-devel@lists.xenproject.org" , "wei.liu2@citrix.com" Cc: "andrew.cooper3@citrix.com" , "jbeulich@suse.com" , "roger.pau@citrix.com" List-Id: xen-devel@lists.xenproject.org T24gVGh1LCAyMDE5LTAyLTA3IGF0IDE2OjQ0ICswMDAwLCBXZWkgTGl1IHdyb3RlOg0KPiBXZSB3 aWxsIHNvb24gcmV3cml0ZSB0aGUgZnVuY3Rpb24gdG8gaGFuZGxlIGR5bmFtaWNhbGx5IG1hcHBp bmcgYW5kDQo+IHVubWFwcGluZyBvZiBwYWdlIHRhYmxlcy4NCj4gDQo+IE5vIGZ1bmN0aW9uYWwg Y2hhbmdlLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNv bT4NCj4gLS0tDQo+IMKgeGVuL2FyY2gveDg2L21tLmMgfCAzNCArKysrKysrKysrKysrKysrKysr KysrKysrKystLS0tLS0tDQo+IMKgMSBmaWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDcg ZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L21tLmMgYi94ZW4v YXJjaC94ODYvbW0uYw0KPiBpbmRleCA0MTQ3YTcxYzVkLi4zYWIyMjJjOGVhIDEwMDY0NA0KPiAt LS0gYS94ZW4vYXJjaC94ODYvbW0uYw0KPiArKysgYi94ZW4vYXJjaC94ODYvbW0uYw0KPiBAQCAt NDg4Nyw5ICs0ODg3LDExIEBAIGludCBtYXBfcGFnZXNfdG9feGVuKA0KPiDCoMKgwqDCoMKgdW5z aWduZWQgaW50IGZsYWdzKQ0KPiDCoHsNCj4gwqDCoMKgwqDCoGJvb2wgbG9ja2luZyA9IHN5c3Rl bV9zdGF0ZSA+IFNZU19TVEFURV9ib290Ow0KPiArwqDCoMKgwqBsM19wZ2VudHJ5X3QgKnBsM2Us IG9sM2U7DQoNCkFmdGVyIGxpbWl0aW5nIHRoZSBzY29wZSBvZiBvdGhlciB2YXJpYWJsZXMgaW4g dGhlIHByZXZpb3VzIHBhdGNoZXMsDQp5b3Ugbm93IHdpZGVuIHRoZSBzY29wZSBmb3IgdGhpcyBv bmUuIElzIHRoaXMgc28geW91IGNhbiBoYW5kbGUgdW5tYXANCmluIGEgY29tbW9uIGV4aXQvZXJy b3IgcGF0aCBsYXRlcj8NCg0KPiDCoMKgwqDCoMKgbDJfcGdlbnRyeV90ICpwbDJlLCBvbDJlOw0K PiDCoMKgwqDCoMKgbDFfcGdlbnRyeV90ICpwbDFlLCBvbDFlOw0KPiDCoMKgwqDCoMKgdW5zaWdu ZWQgaW50wqDCoGk7DQo+ICvCoMKgwqDCoGludCByYyA9IC1FTk9NRU07DQo+IMKgDQo+IMKgI2Rl ZmluZSBmbHVzaF9mbGFncyhvbGRmKSBkbyB7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoFwNCj4gwqDCoMKgwqDCoHVuc2lnbmVkIGludCBvXyA9IChvbGRmKTvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBcDQo+IEBAIC00OTA3LDEwICs0OTA5LDEzIEBAIGludCBt YXBfcGFnZXNfdG9feGVuKA0KPiDCoA0KPiDCoMKgwqDCoMKgd2hpbGUgKCBucl9tZm5zICE9IDAg KQ0KPiDCoMKgwqDCoMKgew0KPiAtwqDCoMKgwqDCoMKgwqDCoGwzX3BnZW50cnlfdCBvbDNlLCAq cGwzZSA9IHZpcnRfdG9feGVuX2wzZSh2aXJ0KTsNCj4gK8KgwqDCoMKgwqDCoMKgwqBwbDNlID0g dmlydF90b194ZW5fbDNlKHZpcnQpOw0KPiDCoA0KPiDCoMKgwqDCoMKgwqDCoMKgwqBpZiAoICFw bDNlICkNCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiAtRU5PTUVNOw0KPiArwqDC oMKgwqDCoMKgwqDCoHsNCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoEFTU0VSVChyYyA9PSAt RU5PTUVNKTsNCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGdvdG8gb3V0Ow0KPiArwqDCoMKg wqDCoMKgwqDCoH0NCj4gwqDCoMKgwqDCoMKgwqDCoMKgb2wzZSA9ICpwbDNlOw0KPiDCoA0KPiDC oMKgwqDCoMKgwqDCoMKgwqBpZiAoIGNwdV9oYXNfcGFnZTFnYiAmJg0KPiBAQCAtNTAwMiw3ICs1 MDA3LDEwIEBAIGludCBtYXBfcGFnZXNfdG9feGVuKA0KPiDCoA0KPiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoGwydCA9IGFsbG9jX3hlbl9wYWdldGFibGUoKTsNCj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqBpZiAoIGwydCA9PSBOVUxMICkNCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgcmV0dXJuIC1FTk9NRU07DQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB7DQo+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoEFTU0VSVChyYyA9PSAtRU5PTUVNKTsN Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZ290byBvdXQ7DQo+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqB9DQo+IMKgDQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZm9y ICggaSA9IDA7IGkgPCBMMl9QQUdFVEFCTEVfRU5UUklFUzsgaSsrICkNCj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoGwyZV93cml0ZShsMnQgKyBpLA0KPiBAQCAtNTAzMSw3ICs1 MDM5LDEwIEBAIGludCBtYXBfcGFnZXNfdG9feGVuKA0KPiDCoA0KPiDCoMKgwqDCoMKgwqDCoMKg wqBwbDJlID0gdmlydF90b194ZW5fbDJlKHZpcnQpOw0KPiDCoMKgwqDCoMKgwqDCoMKgwqBpZiAo ICFwbDJlICkNCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiAtRU5PTUVNOw0KPiAr wqDCoMKgwqDCoMKgwqDCoHsNCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoEFTU0VSVChyYyA9 PSAtRU5PTUVNKTsNCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGdvdG8gb3V0Ow0KPiArwqDC oMKgwqDCoMKgwqDCoH0NCj4gwqANCj4gwqDCoMKgwqDCoMKgwqDCoMKgaWYgKCAoKCgodmlydCA+ PiBQQUdFX1NISUZUKSB8IG1mbl94KG1mbikpICYNCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAoKDF1IDw8IFBBR0VUQUJMRV9PUkRFUikgLSAxKSkgPT0gMCkgJiYNCj4gQEAgLTUw NzYsNyArNTA4NywxMCBAQCBpbnQgbWFwX3BhZ2VzX3RvX3hlbigNCj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqB7DQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBwbDFlID0g dmlydF90b194ZW5fbDFlKHZpcnQpOw0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgaWYgKCBwbDFlID09IE5VTEwgKQ0KPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoHJldHVybiAtRU5PTUVNOw0KPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqB7DQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgQVNTRVJU KHJjID09IC1FTk9NRU0pOw0KPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoGdvdG8gb3V0Ow0KPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB9DQo+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfQ0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGVs c2UgaWYgKCBsMmVfZ2V0X2ZsYWdzKCpwbDJlKSAmIF9QQUdFX1BTRSApDQo+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgew0KPiBAQCAtNTEwNCw3ICs1MTE4LDEwIEBAIGludCBtYXBfcGFnZXNf dG9feGVuKA0KPiDCoA0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgbDF0ID0g YWxsb2NfeGVuX3BhZ2V0YWJsZSgpOw0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgaWYgKCBsMXQgPT0gTlVMTCApDQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgcmV0dXJuIC1FTk9NRU07DQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoHsNCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBBU1NFUlQo cmMgPT0gLUVOT01FTSk7DQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgZ290byBvdXQ7DQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoH0NCj4gwqAN Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGZvciAoIGkgPSAwOyBpIDwgTDFf UEFHRVRBQkxFX0VOVFJJRVM7IGkrKyApDQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoGwxZV93cml0ZSgmbDF0W2ldLA0KPiBAQCAtNTI1MCw3ICs1MjY3LDEwIEBA IGludCBtYXBfcGFnZXNfdG9feGVuKA0KPiDCoA0KPiDCoCN1bmRlZiBmbHVzaF9mbGFncw0KPiDC oA0KPiAtwqDCoMKgwqByZXR1cm4gMDsNCj4gK8KgwqDCoMKgcmMgPSAwOw0KPiArDQo+ICsgb3V0 Og0KPiArwqDCoMKgwqByZXR1cm4gcmM7DQo+IMKgfQ0KPiDCoA0KPiDCoGludCBwb3B1bGF0ZV9w dF9yYW5nZSh1bnNpZ25lZCBsb25nIHZpcnQsIHVuc2lnbmVkIGxvbmcgbnJfbWZucykKCgoKQW1h em9uIERldmVsb3BtZW50IENlbnRlciBHZXJtYW55IEdtYkgKS3JhdXNlbnN0ci4gMzgKMTAxMTcg QmVybGluCkdlc2NoYWVmdHNmdWVocmVyOiBDaHJpc3RpYW4gU2NobGFlZ2VyLCBSYWxmIEhlcmJy aWNoClVzdC1JRDogREUgMjg5IDIzNyA4NzkKRWluZ2V0cmFnZW4gYW0gQW10c2dlcmljaHQgQ2hh cmxvdHRlbmJ1cmcgSFJCIDE0OTE3MyBCCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGlu Zm8veGVuLWRldmVs