From: Reza Arbab Subject: [PATCH 1/2] drm/udl: Fix off-by-one error in udl_get_edid() Date: Fri, 22 Mar 2019 15:56:12 -0500 Message-ID: <1553288173-10845-2-git-send-email-arbab@linux.ibm.com> References: <1553288173-10845-1-git-send-email-arbab@linux.ibm.com> Return-path: In-Reply-To: <1553288173-10845-1-git-send-email-arbab@linux.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: Dave Airlie , Sean Paul , David Airlie , Daniel Vetter , Robert Tarasov , Linus Walleij , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: wzabolot@elektron.elka.pw.edu.pl, Pavel Machek , Alex Deucher , =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= List-Id: dri-devel@lists.freedesktop.org The loop which reads EDID extension blocks is off by one. Fix it. Fixes: 75c65ee20ade ("drm/udl: Reading all edid blocks in DRM/UDL driver") Signed-off-by: Reza Arbab --- drivers/gpu/drm/udl/udl_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c index 66885c24590f..820543415a78 100644 --- a/drivers/gpu/drm/udl/udl_connector.c +++ b/drivers/gpu/drm/udl/udl_connector.c @@ -71,7 +71,7 @@ static bool udl_get_edid(struct udl_device *udl, u8 **result_buff, memcpy(buff_ptr, block_buff, EDID_LENGTH); kfree(block_buff); buff_ptr += EDID_LENGTH; - for (i = 1; i < extensions; ++i) { + for (i = 1; i <= extensions; ++i) { if (udl_get_edid_block(udl, i, buff_ptr)) { buff_ptr += EDID_LENGTH; } else { -- 1.8.3.1