Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AC1DC10F13 for ; Mon, 8 Apr 2019 21:40:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBA7420833 for ; Mon, 8 Apr 2019 21:40:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="a7+N+saF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbfDHVkL (ORCPT ); Mon, 8 Apr 2019 17:40:11 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40405 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbfDHVkK (ORCPT ); Mon, 8 Apr 2019 17:40:10 -0400 Received: by mail-pg1-f195.google.com with SMTP id d31so3500592pgl.7 for ; Mon, 08 Apr 2019 14:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bAkr2jgikd0HOEUBDYrKyUdXZu+Sx8qmphd9mj9dvdo=; b=a7+N+saFcbirTDgMxBXmKldKR1D1tWmuQDk7BiUhtKzPV9vjZDXMcgI08VZuE6CsA6 bSvMOchX65D9sDf1IH0sRb0s9U2xSIH42f7rC/skKGWBunlLl+yOekHQ3pt+CXjKPMm3 l0yo74+Ka+G3BizfL3JUHg0tvMuaCBrt8LDws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bAkr2jgikd0HOEUBDYrKyUdXZu+Sx8qmphd9mj9dvdo=; b=ApedZT4O50F1/BgYXSb2LOzFTPuE/NB509un4vAnrTvSSXZ9qSU5NBC1WXHX0SeIDS VhKeQ/hAGS42NfxD5E+H/zj0CKg3TDtvrrS4exoG8lZ0PrU4tHH4Y6gVW64h09xgxQHQ k/7WjZ2YWGdFnk37JWiBXPi5/q1upHCmrYheICO67rMH39BxH/z+ixnBbgcf3mteC88z /FQtuHYUnktZdIZcGkylh/hDtUW3YtTsuvNK0h+/vvEeIE0J6OPkwdcPczw9/6gB0nY+ GD1+FR28KdkvXPLGKNYqjkra8Wr7eMutFeAs8WnPA+qRce9JhFr42JZUqns/O+YGOShT 4Zlg== X-Gm-Message-State: APjAAAWovb8wRhVqLaH1Gsm73sNh+2ZzL3J1MBe0QeRPnDfkswGST1sq BDK9P5h4G/ykklTgCbVYpU+XSIFSQqo= X-Google-Smtp-Source: APXvYqz5WGYfBNmODLmhi4BenwZ2Qy5vdMHvB8Ph7SRCMQ2uIbXN+panG7trtD0Rj7jx3fgamfFKug== X-Received: by 2002:a65:420b:: with SMTP id c11mr30885726pgq.24.1554759609308; Mon, 08 Apr 2019 14:40:09 -0700 (PDT) Received: from localhost.dhcp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id d25sm41210644pfn.154.2019.04.08.14.40.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Apr 2019 14:40:08 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org Subject: [PATCH net 2/2] bnxt_en: Reset device on RX buffer errors. Date: Mon, 8 Apr 2019 17:39:55 -0400 Message-Id: <1554759595-31506-3-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1554759595-31506-1-git-send-email-michael.chan@broadcom.com> References: <1554759595-31506-1-git-send-email-michael.chan@broadcom.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If the RX completion indicates RX buffers errors, the RX ring will be disabled by firmware and no packets will be received on that ring from that point on. Recover by resetting the device. Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 3df847b..4c586ba 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -1614,11 +1614,17 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, rx_buf->data = NULL; if (rxcmp1->rx_cmp_cfa_code_errors_v2 & RX_CMP_L2_ERRORS) { + u32 rx_err = le32_to_cpu(rxcmp1->rx_cmp_cfa_code_errors_v2); + bnxt_reuse_rx_data(rxr, cons, data); if (agg_bufs) bnxt_reuse_rx_agg_bufs(cpr, cp_cons, agg_bufs); rc = -EIO; + if (rx_err & RX_CMPL_ERRORS_BUFFER_ERROR_MASK) { + netdev_warn(bp->dev, "RX buffer error %x\n", rx_err); + bnxt_sched_reset(bp, rxr); + } goto next_rx; } -- 2.5.1