Received: from list by lists.gnu.org with archive (Exim 4.71) id 1hEZMr-0006o1-Iy for mharc-grub-devel@gnu.org; Thu, 11 Apr 2019 09:03:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEVVE-0007jX-8y for grub-devel@gnu.org; Thu, 11 Apr 2019 04:56:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEVVD-00017L-7c for grub-devel@gnu.org; Thu, 11 Apr 2019 04:56:12 -0400 Received: from out30-51.freemail.mail.aliyun.com ([115.124.30.51]:34447) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEVVC-00014G-7l for grub-devel@gnu.org; Thu, 11 Apr 2019 04:56:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aliyun.com; s=s1024; t=1554972964; h=From:To:Subject:Date:Message-Id; bh=JJxyAac1YeYMi+3P9PUX6SIDjdw/nQ93oFpGsrni4hU=; b=kiv/jctdlMWkB5RzXGYBnMW6UDVW8kAoQV/YtMoDnKm2R1ua24XvcgMT5bo977uhDasZ6pbBSIvSR8C6/0Y9WG+rDVfNtyI8UZTRPdeeS3drV80tvFxommo8GvccVCqLpAuvgEDzpG2GFoP7z8i51pV3HM03TXLcK82EtC4SaQM= X-Alimail-AntiSpam: AC=CONTINUE; BC=0.07360081|-1; CH=green; DM=||false|; FP=0|0|0|0|0|-1|-1|-1; HT=e01e04400; MF=printer.wx@aliyun.com; NM=1; PH=DS; RN=2; RT=2; SR=0; TI=SMTPD_---0TP1Zg58_1554972004; Received: from xiaomi-vm.localdomain(mailfrom:printer.wx@aliyun.com fp:SMTPD_---0TP1Zg58_1554972004) by smtp.aliyun-inc.com(127.0.0.1); Thu, 11 Apr 2019 16:40:08 +0800 From: Milo Wenxiang Niu To: grub-devel@gnu.org Cc: Milo Wenxiang X Niu Subject: [PATCH v2] Optimization calculation expression of FOR_MODULES(var) Date: Thu, 11 Apr 2019 04:39:47 -0400 Message-Id: <1554971987-44519-1-git-send-email-printer.wx@aliyun.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 115.124.30.51 X-Mailman-Approved-At: Thu, 11 Apr 2019 09:03:48 -0400 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2019 08:56:13 -0000 From: Milo Wenxiang X Niu It's just to remove the common factor: "sizeof (grub_addr_t)" from the numerator and denominator of the fractional expression of next var. Let me explain it: Shortly: H: struct grub_module_header ; B: grub_uint32_t ; A: grub_addr_t; Thus, original expression can be expressed as: var = (H *)((B*)var) + ( offset_exp )) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ (((H*)var)->size + sizeof(A) - 1) sizeof(A) | offset_exp = --------------------------------- * ----------- | sizeof(A) sizeof(B) | ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remove the common factor "sizeof(A)" of fractional offset_exp, we got the result. offset_exp_new = ((H*)->size + sizeof(A) - 1) / sizeof(B) = ((struct grub_module_header *) var)->size + sizeof (grub_addr_t) -1) / sizeof (grub_uint32_t) so: var =(H *)(((B*)var) + ( (((H*)var)->size + sizeof(A) - 1) / sizeof(B) )) That's what I do. Still, the new offset express is meaningfull: *numerator: ((struct grub_module_header *) var)->size + sizeof (grub_addr_t) -1) it present the offset value united by byte. *denominator: sizeof (grub_uint32_t) it's means "struct grub_module_header" aligned by sizeof(grub_uint32_t) --- include/grub/kernel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/grub/kernel.h b/include/grub/kernel.h index 133a37c..b257224 100644 --- a/include/grub/kernel.h +++ b/include/grub/kernel.h @@ -104,7 +104,7 @@ extern grub_addr_t EXPORT_VAR (grub_modbase); var && (grub_addr_t) var \ < (grub_modbase + (((struct grub_module_info *) grub_modbase)->size)); \ var = (struct grub_module_header *) \ - (((grub_uint32_t *) var) + ((((struct grub_module_header *) var)->size + sizeof (grub_addr_t) - 1) / sizeof (grub_addr_t)) * (sizeof (grub_addr_t) / sizeof (grub_uint32_t)))) + (((grub_uint32_t *) var) + ((((struct grub_module_header *) var)->size + sizeof (grub_addr_t) - 1) / sizeof (grub_uint32_t)))) grub_addr_t grub_modules_get_end (void); -- 1.8.3.1