From: Boris Derzhavets Subject: Re: [PATCH] fs-backend: fix compile problems Date: Wed, 18 Mar 2009 09:13:02 -0700 (PDT) Message-ID: <155851.243.qm@web56102.mail.re3.yahoo.com> References: Reply-To: bderzhavets@yahoo.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1746816499==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini , Keir Fraser Cc: xen-devel List-Id: xen-devel@lists.xenproject.org --===============1746816499== Content-Type: multipart/alternative; boundary="0-1227885259-1237392782=:243" --0-1227885259-1237392782=:243 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The most recent Xen Unstable installed:- make xen OK make install-xen OK make tools=20 gcc=C2=A0 -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -= fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-valu= e -Wdeclaration-after-statement=C2=A0 -D__XEN_TOOLS__ -MMD -MF .xc_domain_r= estore.o.d=C2=A0 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I= ../../xen/common/libelf -Werror -Wmissing-prototypes=C2=A0 -I. -I../xenstor= e -I../include -c -o xc_domain_restore.o xc_domain_restore.c gcc=C2=A0 -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -= fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-valu= e -Wdeclaration-after-statement=C2=A0 -D__XEN_TOOLS__ -MMD -MF .xc_domain_s= ave.o.d=C2=A0 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I../= ../xen/common/libelf -Werror -Wmissing-prototypes=C2=A0 -I. -I../xenstore -= I../include -c -o xc_domain_save.o xc_domain_save.c cc1: warnings being treated as errors xc_domain_save.c: In function =E2=80=98lock_suspend_event=E2=80=99: xc_domain_save.c:764: error: ignoring return value of =E2=80=98write=E2=80= =99, declared with attribute warn_unused_result make[4]: *** [xc_domain_save.o] Error 1 make[4]: Leaving directory `/usr/src/xen-unstable.hg/tools/libxc' make[3]: *** [build] Error 2 make[3]: Leaving directory `/usr/src/xen-unstable.hg/tools/libxc' make[2]: *** [subdir-install-libxc] Error 2 make[2]: Leaving directory `/usr/src/xen-unstable.hg/tools' make[1]: *** [subdirs-install] Error 2 make[1]: Leaving directory `/usr/src/xen-unstable.hg/tools' make: *** [install-tools] Error 2 I belive requires same patch as fs-backend.c Boris --- On Wed, 3/18/09, Keir Fraser wrote: From: Keir Fraser Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems To: "bderzhavets@yahoo.com" , "Stefano Stabellini" <= Stefano.Stabellini@eu.citrix.com> Cc: "xen-devel" Date: Wednesday, March 18, 2009, 11:00 AM Re: [Xen-devel] [PATCH] fs-backend: fix compile problems Upgrade to latest xen-unstable. It=E2=80=99s fixed there. =C2=A0-- Keir On 18/03/2009 14:53, "Boris Derzhavets" wrote: Now "make install-xen" fails :- make[6]: Entering directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mche= ck' gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-st= rict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wde= claration-after-statement =C2=A0-nostdinc -fno-builtin -fno-common -iwithpr= efix include -Werror -Wno-pointer-arith -pipe -I/usr/src/xen-unstable.hg/xe= n/include =C2=A0-I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-generic= -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-float -= fno-stack-protector -mno-red-zone -fpic -fno-reorder-blocks -fno-asynchrono= us-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g -D__XEN__ -DVERBOSE -fno= -omit-frame-pointer -DCONFIG_FRAME_POINTER -MMD -MF .mce_intel.o.d -c mce_i= ntel.c -o mce_intel.o mce_intel.c:17: error: static declaration of =E2=80=98firstbank=E2=80=99 fo= llows non-static declaration x86_mca.h:95: error: previous declaration of =E2=80=98firstbank=E2=80=99 wa= s here make[6]: *** [mce_intel.o] Error 1 make[6]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mchec= k' make[5]: *** [mcheck/built_in.o] Error 2 make[5]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu' make[4]: *** [cpu/built_in.o] Error 2 make[4]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86' make[3]: *** [/usr/src/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2 make[3]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86' make[2]: *** [/usr/src/xen-unstable.hg/xen/xen] Error 2 make[2]: Leaving directory `/usr/src/xen-unstable.hg/xen' make[1]: *** [install] Error 2 make[1]: Leaving directory `/usr/src/xen-unstable.hg/xen' make: *** [install-xen] Error 2 --- On Wed, 3/18/09, Boris Derzhavets wrote: From: Boris Derzhavets Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems To: "Stefano Stabellini" Cc: "xen-devel" Date: Wednesday, March 18, 2009, 10:48 AM Thank you. It's done Boris --- On Wed, 3/18/09, Stefano Stabellini = wrote: From: Stefano Stabellini Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems To: "bderzhavets@yahoo.com" Cc: "xen-devel" Date: Wednesday, March 18, 2009, 10:19 AM Boris Derzhavets wrote: > Removed unresolved reference in > /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined reference > to `pci_emulation_add' >=20 > /* =C2=A0=C2=A0=C2=A0for (i =3D 0; i < nb_pci_emulation; i++) { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if(pci_emulation_add(pci_= emulation_config_text[i]) < 0) =C2=A0{ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0f= printf(stderr, "Warning: could not add PCI device %s\n", > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pci_emulation_config_text[i= ]); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > =C2=A0=C2=A0=C2=A0=C2=A0} > */ >=20 > "make tools" completed OK. > Is it acceptable ? >=20 I think we are missing an ifdef =C2=A0CONFIG_PASSTHROUGH diff --git a/vl.c b/vl.c index 9b9f7d5..6c0ffb3 100644 --- a/vl.c +++ b/vl.c @@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} =C2=A0 +#ifdef CONFIG_PASSTHROUGH =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0for (i =3D 0; i < nb_pci_emulation; i++) { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if(pci_emulation_add(= pci_emulation_config_text[i]) < 0) { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0fprintf(stderr, "Warning: could not add PCI device %s\n", =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pci_emulation_config_tex= t[i]); =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} +#endif =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (strlen(direct_pci_str) > 0) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0direct_pci =3D =C2=A0direct_pci_str; _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel =C2=A0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel =C2=A0 =20 =0A=0A=0A --0-1227885259-1237392782=:243 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
The most recent Xen Unstable installed:-
m= ake xen OK
make install-xen OK
make tools


gcc  -O1 -= fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-strict-alia= sing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration= -after-statement  -D__XEN_TOOLS__ -MMD -MF .xc_domain_restore.o.d = ; -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I../../xen/commo= n/libelf -Werror -Wmissing-prototypes  -I. -I../xenstore -I../include = -c -o xc_domain_restore.o xc_domain_restore.c
gcc  -O1 -fno-omit-fr= ame-pointer -fno-optimize-sibling-calls -m64 -g -fno-strict-aliasing -std= =3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-st= atement  -D__XEN_TOOLS__ -MMD -MF .xc_domain_save.o.d  -D_LARGEFI= LE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I../../xen/common/libelf -We= rror -Wmissing-prototypes  -I. -I../xenstore -I../include -c -o xc_domain_= save.o xc_domain_save.c
cc1: warnings being treated as errors
xc_doma= in_save.c: In function =E2=80=98lock_suspend_event=E2=80=99:
xc_domain_s= ave.c:764: error: ignoring return value of =E2=80=98write=E2=80=99, declare= d with attribute warn_unused_result
make[4]: *** [xc_domain_save.o] Erro= r 1
make[4]: Leaving directory `/usr/src/xen-unstable.hg/tools/libxc'make[3]: *** [build] Error 2
make[3]: Leaving directory `/usr/src/xen-u= nstable.hg/tools/libxc'
make[2]: *** [subdir-install-libxc] Error 2
m= ake[2]: Leaving directory `/usr/src/xen-unstable.hg/tools'
make[1]: *** = [subdirs-install] Error 2
make[1]: Leaving directory `/usr/src/xen-unsta= ble.hg/tools'
make: *** [install-tools] Error 2

I belive requires= same patch as fs-backend.c


Boris



--- On Wed, = 3/18/09, Keir Fraser <keir.fraser@eu.citrix.com> wrote:
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subjec= t: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
To: "bderzha= vets@yahoo.com" <bderzhavets@yahoo.com>, "Stefano Stabellini" <Ste= fano.Stabellini@eu.citrix.com>
Cc: "xen-devel" <xen-devel@lists.xe= nsource.com>
Date: Wednesday, March 18, 2009, 11:00 AM

Re: [Xen-devel] [PATCH] fs-backend: fix compile problems Upgrade to latest xen-unstable. It=E2=80=99s fixed there.

 -- Keir

On 18/03/2009 14:53, "Boris Derzhavets" <bderzhavets= @yahoo.com> wrote:

Now "make install-xen" fails :-

make[6]: Entering directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mche= ck'
gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-st= rict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wde= claration-after-statement  -nostdinc -fno-builtin -fno-common -iwithpr= efix include -Werror -Wno-pointer-arith -pipe -I/usr/src/xen-unstable.hg/xe= n/include  -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-generic= -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-float -= fno-stack-protector -mno-red-zone -fpic -fno-reorder-blocks -fno-asynchrono= us-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g -D__XEN__ -DVERBOSE -fno= -omit-frame-pointer -DCONFIG_FRAME_POINTER -MMD -MF .mce_intel.o.d -c mce_i= ntel.c -o mce_intel.o
mce_intel.c:17: error: static declaration of =E2=80=98firstbank=E2=80=99 fo= llows non-static declaration
x86_mca.h:95: error: previous declaration of =E2=80=98firstbank=E2=80=99 wa= s here
make[6]: *** [mce_intel.o] Error 1
make[6]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mchec= k'
make[5]: *** [mcheck/built_in.o] Error 2
make[5]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu'
make[4]: *** [cpu/built_in.o] Error 2
make[4]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86'
make[3]: *** [/usr/src/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2
make[3]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86'
make[2]: *** [/usr/src/xen-unstable.hg/xen/xen] Error 2
make[2]: Leaving directory `/usr/src/xen-unstable.hg/xen'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/usr/src/xen-unstable.hg/xen'
make: *** [install-xen] Error 2


--- On Wed, 3/18/09, Boris Derzhavets <bderzha= vets@yahoo.com> wrote:
From: Boris Derzhavets <bderzhavets@yahoo.com>
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
To: "Stefano Stabellini" <stefano.stabellini@eu.citr= ix.com>
Cc: "xen-devel" <xen-devel@lists.xensource.com&g= t;
Date: Wednesday, March 18, 2009, 10:48 AM

Thank you. It's done
Boris

--- On Wed, 3/18/09, Stefano Stabellini <stefa= no.stabellini@eu.citrix.com> wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
Cc: "xen-devel" <xen-devel@lists.xensource.com&g= t;
Date: Wednesday, March 18, 2009, 10:19 AM

Boris Derzhavets wrote:

> Removed unresolved reference in
> /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined referenc= e
> to `pci_emulation_add'
>
> /*    for (i =3D 0; i < nb_pci_emulation; i++) {
>         if(pci_emulation_add(p= ci_emulation_config_text[i]) < 0)
 {
>            &nbs= p;fprintf(stderr, "Warning: could not add PCI device
%s\n",
>            &nbs= p;        pci_emulation_config_text= [i]);
>         }
>     }
> */
>
> "make tools" completed OK.
> Is it acceptable ?
>



I think we are missing an ifdef
 CONFIG_PASSTHROUGH


diff --git a/vl.c b/vl.c
index 9b9f7d5..6c0ffb3 100644
--- a/vl.c
+++ b/vl.c
@@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp)
         }
     }
 
+#ifdef CONFIG_PASSTHROUGH
     for (i =3D 0; i < nb_pci_emulation; i++) {=
         if(pci_emulation_add(= pci_emulation_config_text[i]) < 0) {
            &nb= sp;fprintf(stderr, "Warning: could not add PCI device
%s\n",
            &nb= sp;        pci_emulation_config_tex= t[i]);
         }
     }
+#endif
 
     if (strlen(direct_pci_str) > 0)
         direct_pci =3D
 direct_pci_str;

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

 
=20

=0A=0A --0-1227885259-1237392782=:243-- --===============1746816499== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1746816499==--