From: Philipp Zabel
Subject: Re: [PATCH V2 1/2] dt-bindings: reset: imx7: Add support for i.MX8MM
Date: Thu, 04 Jul 2019 11:47:51 +0200
Message-ID: <1562233671.6641.9.camel@pengutronix.de>
References: <20190704092600.38015-1-Anson.Huang@nxp.com>
<1562233305.6641.8.camel@pengutronix.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path:
In-Reply-To:
Sender: linux-kernel-owner@vger.kernel.org
To: Anson Huang , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , Leonard Crestez , Jacky Bai , Daniel Baluta , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org"
Cc: dl-linux-imx
List-Id: devicetree@vger.kernel.org
On Thu, 2019-07-04 at 09:46 +0000, Anson Huang wrote:
> Hi, Philipp
>
> > On Thu, 2019-07-04 at 17:25 +0800, Anson.Huang@nxp.com wrote:
> > > From: Anson Huang
> > >
> > > i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible
> > > property and related info to support i.MX8MM.
> > >
> > > Signed-off-by: Anson Huang
> > > ---
> > > New patch.
> > > ---
> > > Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > index 13e0951..bc24c45 100644
> > > --- a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > +++ b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> > > @@ -7,7 +7,7 @@ controller binding usage.
> > > Required properties:
> > > - compatible:
> > > - For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
> > > - - For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
> > > + - For i.MX8MQ/i.MX8MM SoCs should be "fsl,imx8mq-src", "syscon"
> >
> > Please still add the "fsl,imx8mm-src" for i.MX8MM, just in case a significant
> > difference is discovered later.
>
> OK, then I will add a new line as below:
>
> For i.MX8MM SoCs should be "fsl,imx8mm-src", "fsl,imx8mq-src", "syscon"
Yes, that looks good, thanks.
regards
Philipp