From: Weijie Gao Date: Fri, 19 Jul 2019 10:17:31 +0800 Subject: [U-Boot] [PATCH v4 0/6] Add spi-mem driver for MediaTek MT7629 SoC In-Reply-To: References: <1562728747-21278-1-git-send-email-weijie.gao@mediatek.com> <1563243488.2874.5.camel@mcddlt001> Message-ID: <1563502651.2874.9.camel@mcddlt001> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 2019-07-16 at 17:03 +0530, Jagan Teki wrote: > On Tue, Jul 16, 2019 at 7:48 AM Weijie Gao wrote: > > > > On Mon, 2019-07-15 at 12:59 +0530, Jagan Teki wrote: > > > On Wed, Jul 10, 2019 at 8:51 AM Weijie Gao wrote: > > > > > > > > Since u-boot has added the spi-mem framework and replaced the spi-nor framework, > > > > the mtk_qspi is no longer compatible with the new spi-nor driver. > > > > > > > > This patch series add a new spi-mem driver to replace the mtk_qspi driver, > > > > with one patch to fix watchdog not feeding during spi operation. > > > > > > > > Weijie Gao (6): > > > > mtd: spi-nor: add watchdog reset to flash operation loops > > > > spi: remove obsolete mtk_qspi driver > > > > spi: add spi-mem driver for MediaTek MT7629 SoC > > > > arm: dts: change MT7629 to use spi-mem rather than qspi > > > > configs: mt7629_rfb: change MTK_QSPI to MTK_SNFI_SPI > > > > MAINTAINERS: change spi driver entry > > > > > > What is v4 change log? I wouldn't find it on individual patches? > > > > Oh, I forgot to write this to cover letter. But I have written change > > log to "spi: add spi-mem driver for MediaTek MT7629 SoC". > > There is only one change in this patch: remove chip select checking. > > I think this should be implemented in spi-uclass. > > Okay, np. except 0001 rest look fine for me. > > Reviewed-by: Jagan Teki I have tested another solution. I just move WATCHDOG_RESET() into the mtk_snfi_exec_op() so there is no need to modify the spi-nor driver. I think this is better for mt7629.