From: Bin Meng Date: Thu, 29 Aug 2019 07:09:38 -0700 Subject: [U-Boot] [PATCH 2/2] dm: spi: Check cs number before accessing slaves In-Reply-To: <1567087778-23575-1-git-send-email-bmeng.cn@gmail.com> References: <1567087778-23575-1-git-send-email-bmeng.cn@gmail.com> Message-ID: <1567087778-23575-2-git-send-email-bmeng.cn@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In spi_get_bus_and_cs() only bus number is checked before accessing slaves. We should check cs number as well. Signed-off-by: Bin Meng --- drivers/spi/spi-uclass.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c index 24de0b5..f633eb5 100644 --- a/drivers/spi/spi-uclass.c +++ b/drivers/spi/spi-uclass.c @@ -271,6 +271,7 @@ int spi_get_bus_and_cs(int busnum, int cs, int speed, int mode, { struct udevice *bus, *dev; struct dm_spi_slave_platdata *plat; + struct spi_cs_info info; bool created = false; int ret; @@ -283,6 +284,11 @@ int spi_get_bus_and_cs(int busnum, int cs, int speed, int mode, printf("Invalid bus %d (err=%d)\n", busnum, ret); return ret; } + ret = spi_cs_info(bus, cs, &info); + if (ret) { + printf("Invalid cs %d (err=%d)\n", cs, ret); + return ret; + } ret = spi_find_chip_select(bus, cs, &dev); /* -- 2.7.4