From: Bin Meng Date: Sun, 27 Oct 2019 05:28:22 -0700 Subject: [U-Boot] [PATCH 2/5] tools: buildman: Remove useless mkdir() in Make() in test.py In-Reply-To: <1572179306-26650-1-git-send-email-bmeng.cn@gmail.com> References: <1572179306-26650-1-git-send-email-bmeng.cn@gmail.com> Message-ID: <1572179306-26650-3-git-send-email-bmeng.cn@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In the 'Make' function, the codes tries to create a directory if current stage is 'build'. But the directory isn't used at all anywhere. Signed-off-by: Bin Meng --- tools/buildman/test.py | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tools/buildman/test.py b/tools/buildman/test.py index de02f61..0dd8516 100644 --- a/tools/buildman/test.py +++ b/tools/buildman/test.py @@ -22,6 +22,7 @@ import commit import terminal import test_util import toolchain +from terminal import Print use_network = True @@ -156,14 +157,6 @@ class TestBuild(unittest.TestCase): result.return_code = commit.return_code result.stderr = (''.join(commit.error_list) % {'basedir' : base_dir + '/.bm-work/00/'}) - if stage == 'build': - target_dir = None - for arg in args: - if arg.startswith('O='): - target_dir = arg[2:] - - if not os.path.isdir(target_dir): - os.mkdir(target_dir) result.combined = result.stdout + result.stderr return result -- 2.7.4