From: Mimi Zohar Date: Tue, 12 Nov 2019 17:04:56 +0000 Subject: Re: [PATCH v5 01/10] IMA: Added KEYRING_CHECK func in IMA policy to measure keys Message-Id: <1573578296.17949.41.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20191111193303.12781-1-nramas@linux.microsoft.com> <20191111193303.12781-2-nramas@linux.microsoft.com> In-Reply-To: <20191111193303.12781-2-nramas@linux.microsoft.com> To: Lakshmi Ramasubramanian , dhowells@redhat.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org T24gTW9uLCAyMDE5LTExLTExIGF0IDExOjMyIC0wODAwLCBMYWtzaG1pIFJhbWFzdWJyYW1hbmlh biB3cm90ZToKPiBJTUEgcG9saWN5IG5lZWRzIHRvIHN1cHBvcnQgYSBmdW5jIHRvIGVuYWJsZSBt ZWFzdXJlbWVudCBvZgo+IGFzeW1tZXRyaWMga2V5cy4KPiAKPiBUaGlzIHBhdGNoIGRlZmluZXMg YSBuZXcgSU1BIHBvbGljeSBmdW5jIG5hbWVseSBLRVlSSU5HX0NIRUNLIHRvCj4gbWVhc3VyZSBh c3ltbWV0cmljIGtleXMuCgpUaGlzIG5ldyBmZWF0dXJlIG1lYXN1cmVzICJrZXlzIiBiYXNlZCBv biBwb2xpY3ksIG5vdCAia2V5cmluZ3MiLgrCoFBsZWFzZSBjaGFuZ2UgdGhlIG5hbWUgdG8gS0VZ X0NIRUNLLgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBMYWtzaG1pIFJhbWFzdWJyYW1hbmlhbiA8bnJh bWFzQGxpbnV4Lm1pY3Jvc29mdC5jb20+Cj4gLS0tCj4gIERvY3VtZW50YXRpb24vQUJJL3Rlc3Rp bmcvaW1hX3BvbGljeSB8IDYgKysrKysrCj4gIHNlY3VyaXR5L2ludGVncml0eS9pbWEvaW1hLmgg ICAgICAgICB8IDEgKwo+ICBzZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9wb2xpY3kuYyAgfCA0 ICsrKy0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vQUJJL3Rlc3RpbmcvaW1hX3BvbGljeSBi L0RvY3VtZW50YXRpb24vQUJJL3Rlc3RpbmcvaW1hX3BvbGljeQo+IGluZGV4IDI5YWFlZGYzMzI0 Ni4uMzQxZGY0OWI1YWQxIDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vQUJJL3Rlc3Rpbmcv aW1hX3BvbGljeQo+ICsrKyBiL0RvY3VtZW50YXRpb24vQUJJL3Rlc3RpbmcvaW1hX3BvbGljeQo+ IEBAIC0zMCw2ICszMCw3IEBAIERlc2NyaXB0aW9uOgo+ICAJCQkJW0ZJUk1XQVJFX0NIRUNLXQo+ ICAJCQkJW0tFWEVDX0tFUk5FTF9DSEVDS10gW0tFWEVDX0lOSVRSQU1GU19DSEVDS10KPiAgCQkJ CVtLRVhFQ19DTURMSU5FXQo+ICsJCQkJW0tFWVJJTkdfQ0hFQ0tdCj4gIAkJCW1hc2s6PSBbW15d TUFZX1JFQURdIFtbXl1NQVlfV1JJVEVdIFtbXl1NQVlfQVBQRU5EXQo+ICAJCQkgICAgICAgW1te XU1BWV9FWEVDXQo+ICAJCQlmc21hZ2ljOj0gaGV4IHZhbHVlCj4gQEAgLTExMywzICsxMTQsOCBA QCBEZXNjcmlwdGlvbjoKPiAgCQlFeGFtcGxlIG9mIGFwcHJhaXNlIHJ1bGUgYWxsb3dpbmcgbW9k c2lnIGFwcGVuZGVkIHNpZ25hdHVyZXM6Cj4gIAo+ICAJCQlhcHByYWlzZSBmdW5jPUtFWEVDX0tF Uk5FTF9DSEVDSyBhcHByYWlzZV90eXBlPWltYXNpZ3xtb2RzaWcKPiArCj4gKwkJRXhhbXBsZSBv ZiBtZWFzdXJlIHJ1bGUgdXNpbmcgS0VZUklOR19DSEVDSyB0byBtZWFzdXJlCj4gKwkJYWxsIGtl eXM6Cj4gKwo+ICsJCQltZWFzdXJlIGZ1bmM9S0VZUklOR19DSEVDSwo+IGRpZmYgLS1naXQgYS9z ZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYS5oIGIvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWEu aAo+IGluZGV4IGRmNGNhNDgyZmI1My4uN2YyMzQwNWIyNzE4IDEwMDY0NAo+IC0tLSBhL3NlY3Vy aXR5L2ludGVncml0eS9pbWEvaW1hLmgKPiArKysgYi9zZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2lt YS5oCj4gQEAgLTE5Myw2ICsxOTMsNyBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGxvbmcgaW1h X2hhc2hfa2V5KHU4ICpkaWdlc3QpCj4gIAlob29rKEtFWEVDX0lOSVRSQU1GU19DSEVDSykJXAo+ ICAJaG9vayhQT0xJQ1lfQ0hFQ0spCQlcCj4gIAlob29rKEtFWEVDX0NNRExJTkUpCQlcCj4gKwlo b29rKEtFWVJJTkdfQ0hFQ0spCQlcCj4gIAlob29rKE1BWF9DSEVDSykKPiAgI2RlZmluZSBfX2lt YV9ob29rX2VudW1pZnkoRU5VTSkJRU5VTSwKPiAgCj4gZGlmZiAtLWdpdCBhL3NlY3VyaXR5L2lu dGVncml0eS9pbWEvaW1hX3BvbGljeS5jIGIvc2VjdXJpdHkvaW50ZWdyaXR5L2ltYS9pbWFfcG9s aWN5LmMKPiBpbmRleCBmMTlhODk1YWQ3Y2QuLjljYTMyZmZhYWE5ZCAxMDA2NDQKPiAtLS0gYS9z ZWN1cml0eS9pbnRlZ3JpdHkvaW1hL2ltYV9wb2xpY3kuYwo+ICsrKyBiL3NlY3VyaXR5L2ludGVn cml0eS9pbWEvaW1hX3BvbGljeS5jCj4gQEAgLTM3Myw3ICszNzMsNyBAQCBzdGF0aWMgYm9vbCBp bWFfbWF0Y2hfcnVsZXMoc3RydWN0IGltYV9ydWxlX2VudHJ5ICpydWxlLCBzdHJ1Y3QgaW5vZGUg Kmlub2RlLAo+ICB7Cj4gIAlpbnQgaTsKPiAgCj4gLQlpZiAoZnVuYyA9IEtFWEVDX0NNRExJTkUp IHsKPiArCWlmICgoZnVuYyA9IEtFWEVDX0NNRExJTkUpIHx8IChmdW5jID0gS0VZUklOR19DSEVD SykpIHsKPiAgCQlpZiAoKHJ1bGUtPmZsYWdzICYgSU1BX0ZVTkMpICYmIChydWxlLT5mdW5jID0g ZnVuYykpCj4gIAkJCXJldHVybiB0cnVlOwo+ICAJCXJldHVybiBmYWxzZTsKPiBAQCAtOTk3LDYg Kzk5Nyw4IEBAIHN0YXRpYyBpbnQgaW1hX3BhcnNlX3J1bGUoY2hhciAqcnVsZSwgc3RydWN0IGlt YV9ydWxlX2VudHJ5ICplbnRyeSkKPiAgCQkJCWVudHJ5LT5mdW5jID0gUE9MSUNZX0NIRUNLOwo+ ICAJCQllbHNlIGlmIChzdHJjbXAoYXJnc1swXS5mcm9tLCAiS0VYRUNfQ01ETElORSIpID0gMCkK PiAgCQkJCWVudHJ5LT5mdW5jID0gS0VYRUNfQ01ETElORTsKPiArCQkJZWxzZSBpZiAoc3RyY21w KGFyZ3NbMF0uZnJvbSwgIktFWVJJTkdfQ0hFQ0siKSA9IDApCj4gKwkJCQllbnRyeS0+ZnVuYyA9 IEtFWVJJTkdfQ0hFQ0s7Cj4gIAkJCWVsc2UKPiAgCQkJCXJlc3VsdCA9IC1FSU5WQUw7Cj4gIAkJ CWlmICghcmVzdWx0KQoKCgo=